Author: ro
Date: Tue May 15 04:36:00 2018
New Revision: 332343
URL: http://llvm.org/viewvc/llvm-project?rev=332343&view=rev
Log:
[Solaris] Only define _REENTRANT if -pthread
When looking at lib/Basic/Targets/OSTargets.h, I noticed that _REENTRANT is
defined
unconditionally on Solaris, unlike all
Author: ro
Date: Thu Jun 21 06:40:50 2018
New Revision: 335234
URL: http://llvm.org/viewvc/llvm-project?rev=335234&view=rev
Log:
[liblang] Remove DOS line endings in libclang.exports
Undefined first referenced
symbol in file
clang_getCompletionFi
Author: ro
Date: Mon Apr 8 08:01:06 2019
New Revision: 357917
URL: http://llvm.org/viewvc/llvm-project?rev=357917&view=rev
Log:
[python, tests] Disable Clang Python tests on SPARC
Running `make check-all` fails on Solaris 11/SPARC since the clang python
tests FAIL:
...
Author: ro
Date: Mon Jun 17 13:21:25 2019
New Revision: 363612
URL: http://llvm.org/viewvc/llvm-project?rev=363612&view=rev
Log:
Clang :: Sema/wchar.c has long been failing on Solaris:
error: 'error' diagnostics expected but not seen:
File /vol/llvm/src/clang/local/test/Sema/wchar.c Line 2
Author: ro
Date: Tue Jul 16 04:06:43 2019
New Revision: 366202
URL: http://llvm.org/viewvc/llvm-project?rev=366202&view=rev
Log:
[Driver] Don't pass --dynamic-linker to ld on Solaris
I noticed that clang currently passes --dynamic-linker to ld. This has been
the case
since Solaris 11 support wa
Author: ro
Date: Wed Jul 17 01:37:00 2019
New Revision: 366305
URL: http://llvm.org/viewvc/llvm-project?rev=366305&view=rev
Log:
[Driver] Enable __cxa_atexit on Solaris
Starting with Solaris 11.4 (which is now the required minimal version), Solaris
does
support __cxa_atexit. This patch reflects
Author: ro
Date: Tue Jul 23 09:24:00 2019
New Revision: 366820
URL: http://llvm.org/viewvc/llvm-project?rev=366820&view=rev
Log:
[clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC
Clang :: Headers/max_align.c currently FAILs on 64-bit SPARC:
error: 'error' diagnostics seen but not
Author: ro
Date: Tue Jul 30 03:38:41 2019
New Revision: 367305
URL: http://llvm.org/viewvc/llvm-project?rev=367305&view=rev
Log:
[Driver] Define _FILE_OFFSET_BITS=64 on Solaris
make check-all currently fails on x86_64-pc-solaris2.11 when building with GCC
9:
Undefined fi
Author: ro
Date: Tue Jul 30 13:04:53 2019
New Revision: 367351
URL: http://llvm.org/viewvc/llvm-project?rev=367351&view=rev
Log:
[Driver] Support -fsanitize=function on Solaris/x86
UBSan-Standalone-x86_64 :: TestCases/TypeCheck/Function/function.cpp currently
FAILs on Solaris/x86_64:
clang-9:
Author: ro
Date: Mon Aug 5 06:59:26 2019
New Revision: 367864
URL: http://llvm.org/viewvc/llvm-project?rev=367864&view=rev
Log:
Move LangStandard*, InputKind::Language to Basic
This patch is a prerequisite for using LangStandard from Driver in
https://reviews.llvm.org/D64793.
It moves LangStand
Author: ro
Date: Mon Aug 5 07:06:16 2019
New Revision: 367866
URL: http://llvm.org/viewvc/llvm-project?rev=367866&view=rev
Log:
[Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris
Builtins-*-sunos :: compiler_rt_logbf_test.c currently FAILs on Solaris, both
SPARC and
x86, 32 and 6
Author: ro
Date: Thu Jun 20 14:33:09 2019
New Revision: 363985
URL: http://llvm.org/viewvc/llvm-project?rev=363985&view=rev
Log:
[test][Driver] Fix Clang :: Driver/cl-response-file.c
Clang :: Driver/cl-response-file.c currently FAILs on Solaris:
Command Output (stderr):
--
/vol/llvm/src/cl
Hi Douglas,
> Your change appears to have broken the one platform you didn't test, Windows.
> :)
sorry about that. Unfortunately, I know next to nothing about Windows
and don't have access to any system to test.
That said...
> Script:
> --
> : 'RUN: at line 7'; printf
> '/IC:\ps4-buildslave2\
Hi Douglas,
> I figured it out. Because you are using printf, you no longer need the
> '\\c'. If I use the following RUN line, the test passes on both
> Windows/linux (I don't have solaris to test unfortunately):
>
> // RUN: printf '%%s\n' '/I%S\Inputs\cl-response-file\ /DFOO=2' > %t.rsp
I've now
Author: ro
Date: Mon Jul 8 15:04:25 2019
New Revision: 365396
URL: http://llvm.org/viewvc/llvm-project?rev=365396&view=rev
Log:
[Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris
As explained in https://reviews.llvm.org/D63601, there's no point using
clang_rt.sancov_{begin,end}
on So
Author: ro
Date: Mon Apr 23 02:28:08 2018
New Revision: 330572
URL: http://llvm.org/viewvc/llvm-project?rev=330572&view=rev
Log:
[Solaris] __float128 is supported on Solaris/x86
When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I
ran
into a few instances of
In file inc
Author: Rainer Orth
Date: 2020-08-06T10:47:16+02:00
New Revision: 710949482edb96a329104317164909979f2387aa
URL:
https://github.com/llvm/llvm-project/commit/710949482edb96a329104317164909979f2387aa
DIFF:
https://github.com/llvm/llvm-project/commit/710949482edb96a329104317164909979f2387aa.diff
L
Author: Rainer Orth
Date: 2020-08-13T22:42:58+02:00
New Revision: f59bec7acb8228fc215fca3ee1e524c38083c50b
URL:
https://github.com/llvm/llvm-project/commit/f59bec7acb8228fc215fca3ee1e524c38083c50b
DIFF:
https://github.com/llvm/llvm-project/commit/f59bec7acb8228fc215fca3ee1e524c38083c50b.diff
L
Author: Rainer Orth
Date: 2022-09-10T09:37:35+02:00
New Revision: 1e56821bac02a5d3c6249bbf3ef43b8b569d2551
URL:
https://github.com/llvm/llvm-project/commit/1e56821bac02a5d3c6249bbf3ef43b8b569d2551
DIFF:
https://github.com/llvm/llvm-project/commit/1e56821bac02a5d3c6249bbf3ef43b8b569d2551.diff
L
rorth wrote:
This patch broke builders like
[Solaris/amd64](https://lab.llvm.org/staging/#/builders/8/builds/761) that
include `clang-tools-extra`.
https://github.com/llvm/llvm-project/pull/70543
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
rorth wrote:
Since this patch, all asan tests loop on Solaris. This had been hidden for a
bit by an unrelated extended build breakage on the bots, but now every `ninja
check-all` on the Solaris/amd64 bot times out. I could trace this to this
patch.
E.g. when running
`projects/compiler-rt/t
rorth wrote:
It took me a bit to notice this snippet in `sanitizer_solaris.cpp`:
```
DECLARE__REAL_AND_INTERNAL(int, fork, void) {
// TODO(glider): this may call user's pthread_atfork() handlers which is bad.
return _REAL(fork)();
}
```
which didn't show up in searches for `internal_fork`.
>
rorth wrote:
> I'll give such a patch a try...
That would be something like
```
int internal_fork(void) {
// Call syscall directly to avoid pthread_atfork handler processing.
//
// This is highly unportable on Solaris since syscalls are an implementation
// detail subject to change.
re
rorth wrote:
This patch broke the [Solaris/sparcv9
buildbot](https://lab.llvm.org/buildbot/#/builders/72/builds/1709): the
new/changed tests `FAIL` with
```
File
/opt/llvm-buildbot/home/solaris11-sparcv9/clang-solaris11-sparcv9/llvm/clang/test/SemaCXX/format-strings-scanf.cpp
Line 25: _Floa
rorth wrote:
This patch broke the Solaris build:
```
FAILED: tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/extensions.cpp.o
[...]
/vol/llvm/src/llvm-project/dist/flang/runtime/extensions.cpp:60:24: error: use
of undeclared identifier 'LOGIN_NAME_MAX'
60 | const int nameMaxLen{LOGIN
rorth wrote:
Sure: I've just created one slightly changed from the attached patch: [[flang]
Handle missing LOGIN_NAME_MAX definition in
runtime](https://github.com/llvm/llvm-project/pull/5)
https://github.com/llvm/llvm-project/pull/74628
___
cfe-
Author: Rainer Orth
Date: 2022-07-29T09:19:38+02:00
New Revision: 9b1897bbd0e3a6e9ef099e74c3d3ed35428c0460
URL:
https://github.com/llvm/llvm-project/commit/9b1897bbd0e3a6e9ef099e74c3d3ed35428c0460
DIFF:
https://github.com/llvm/llvm-project/commit/9b1897bbd0e3a6e9ef099e74c3d3ed35428c0460.diff
L
Author: Rainer Orth
Date: 2022-07-29T09:27:09+02:00
New Revision: bf3714884ae4b4a0301bc6af78e8b4deff12558b
URL:
https://github.com/llvm/llvm-project/commit/bf3714884ae4b4a0301bc6af78e8b4deff12558b
DIFF:
https://github.com/llvm/llvm-project/commit/bf3714884ae4b4a0301bc6af78e8b4deff12558b.diff
L
Author: Rainer Orth
Date: 2022-02-10T12:40:32+01:00
New Revision: a6afa9e6b0d9a08ecc878e62343a2af80ff30435
URL:
https://github.com/llvm/llvm-project/commit/a6afa9e6b0d9a08ecc878e62343a2af80ff30435
DIFF:
https://github.com/llvm/llvm-project/commit/a6afa9e6b0d9a08ecc878e62343a2af80ff30435.diff
L
rorth wrote:
I'm pretty certain this patch broke the [Solaris/sparcv9
buildbot](https://lab.llvm.org/buildbot/#/builders/72/builds/2541).
https://github.com/llvm/llvm-project/pull/73176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
rorth wrote:
Confirmed: reverting the patch locally restores the build.
https://github.com/llvm/llvm-project/pull/73176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rorth wrote:
The libcalls per se wouldn't be a problem since on 32-bit Solaris/sparc
`-latomic` is always linked due to that. However, the `__sync_*` libcalls
aren't defined in `libatomic.so`, thus the link failure.
https://github.com/llvm/llvm-project/pull/73176
_
rorth wrote:
GCC also supports `-mcmodel=embmedany`. Maybe it would be good to reject that
with a clear message?
As for the generated code (not this PR, I'd say), it would certainly be good to
test that on some larger code base (like LLVM itself) and, preferably, also
test actual interoperab
rorth wrote:
> `embmedany` is already rejected by the driver at the moment:
>
> ```
> error: unsupported argument 'embmedany' to option '-mcmodel=' for target
> 'sparc64'
> ```
Seems sensible indeed.
> On the testing issue, however, would compiling LLVM with each of the code
> models + running
rorth wrote:
However, the patch broke the [Solaris/sparcv9
buildbot](https://lab.llvm.org/buildbot/#/builders/72/builds/1834):
```
llc: error: unable to get target for 'x86_64-unknown-linux-gnu', see --version
and --triple.
```
The bot is configured to do a Sparc-only build.
https://github.com
rorth wrote:
I wonder what the current flurry of patdhes to support Illumos is about. I'd
originally filed Issue #53919 to make clear what's needed from the Illumos
project to keep it as an LLVM target, given that they haven't contributed
either bug reports, code or testing in a long time. W
rorth wrote:
This patch broke both the
[Solaris/sparcv9](https://lab.llvm.org/buildbot/#/builders/72/builds/2015) and
[Solaris/amd64](https://lab.llvm.org/staging/#/builders/94/builds/394)
buildbots.
If it really requires recent `lld`, this is guaranteed to not work: `lld`
hasn't even been p
@@ -2,8 +2,9 @@
! invocation. These libraries are added on top of other standard runtime
! libraries that the Clang driver will include.
-! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 |
FileCheck %s --check-prefixes=CHECK,GNU
+! RUN: %flang -### -targe
@@ -21,12 +22,12 @@
! run on any other platform, such as Windows that use a .exe
! suffix. Clang's driver will try to resolve the path to the ld
! executable and may find the GNU linker from MinGW or Cygwin.
-! GNU-LABEL: "{{.*}}ld{{(\.exe)?}}"
-! GNU-SAME: "
https://github.com/rorth updated https://github.com/llvm/llvm-project/pull/65644
>From 31bdd3477d9f54996b71584598bdd75f2cef31db Mon Sep 17 00:00:00 2001
From: Rainer Orth
Date: Thu, 7 Sep 2023 19:19:32 +0200
Subject: [PATCH 1/3] [Driver] Link Flang runtime on Solaris
I noticed that `flang-new`
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/65644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rorth wrote:
This patch also broke the [Solaris/amd64
buildbot](https://lab.llvm.org/staging/#/builders/8/builds/484). I suspect
this happens because that one is configured with `-DLLVM_TARGETS_TO_BUILD=X86`,
thus lacking cuda support. In fact, when manually building with support for
all ta
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/70322
As discussed in [[Driver] Link Flang runtime on
Solaris](https://github.com/llvm/llvm-project/pull/65644), `clang -r`
incorrectly passes both `-Bdynamic` and `-e _start` to `ld` which lets the
linker choke.
This
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/70322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Rainer Orth
Date: 2020-09-11T09:53:19+02:00
New Revision: 76e85ae268f8e64540703b0d1710d27ef0d36040
URL:
https://github.com/llvm/llvm-project/commit/76e85ae268f8e64540703b0d1710d27ef0d36040
DIFF:
https://github.com/llvm/llvm-project/commit/76e85ae268f8e64540703b0d1710d27ef0d36040.diff
L
Author: Rainer Orth
Date: 2021-08-07T21:14:15+02:00
New Revision: a382a746275b4a1eb1867331efa2319c614305d8
URL:
https://github.com/llvm/llvm-project/commit/a382a746275b4a1eb1867331efa2319c614305d8
DIFF:
https://github.com/llvm/llvm-project/commit/a382a746275b4a1eb1867331efa2319c614305d8.diff
L
Author: Rainer Orth
Date: 2023-01-13T10:08:33+01:00
New Revision: 7c4a70f8f6f37c0d22770fa60e079aaf8928a01c
URL:
https://github.com/llvm/llvm-project/commit/7c4a70f8f6f37c0d22770fa60e079aaf8928a01c
DIFF:
https://github.com/llvm/llvm-project/commit/7c4a70f8f6f37c0d22770fa60e079aaf8928a01c.diff
L
rorth wrote:
The different behaviour can easily be seen since Solaris `clang` supports
linker selection at compile time:
```
$ clang -r -o hello-r.o hello.o -fuse-ld=gld
/usr/gnu/bin/ld: warning: cannot find entry symbol _start; not setting start
address
$ clang -r -o hello-r.o hello.o
ld: fata
Author: Rainer Orth
Date: 2023-07-27T11:32:48+02:00
New Revision: 6b5149aa442efc10afa00e8864e58a24a9cf5c9f
URL:
https://github.com/llvm/llvm-project/commit/6b5149aa442efc10afa00e8864e58a24a9cf5c9f
DIFF:
https://github.com/llvm/llvm-project/commit/6b5149aa442efc10afa00e8864e58a24a9cf5c9f.diff
L
Author: Rainer Orth
Date: 2023-08-16T09:57:59+02:00
New Revision: ae84ad15efd7ef7da95146e900ec72ceadf98058
URL:
https://github.com/llvm/llvm-project/commit/ae84ad15efd7ef7da95146e900ec72ceadf98058
DIFF:
https://github.com/llvm/llvm-project/commit/ae84ad15efd7ef7da95146e900ec72ceadf98058.diff
L
Author: Rainer Orth
Date: 2023-08-16T10:37:14+02:00
New Revision: 18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e
URL:
https://github.com/llvm/llvm-project/commit/18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e
DIFF:
https://github.com/llvm/llvm-project/commit/18252e6c8e2b1bb9901b5cca9e9a75edfeda2c4e.diff
L
Author: Rainer Orth
Date: 2023-08-18T21:09:37+02:00
New Revision: 62945bb811169ffac7cf22c64b6dd3a3ad8d38f0
URL:
https://github.com/llvm/llvm-project/commit/62945bb811169ffac7cf22c64b6dd3a3ad8d38f0
DIFF:
https://github.com/llvm/llvm-project/commit/62945bb811169ffac7cf22c64b6dd3a3ad8d38f0.diff
L
rorth wrote:
> > I wonder how to proceed with the patch at hand.
>
> I'm not a Solaris expert, but based on this discussion I'd consider adding
> support for `-fuse-ld` in Flang. This sort of changes are often as simple as
> updating Options.td. Same for `-r`.
Support of `-fuse-ld` is not Sol
rorth wrote:
> I'd like for this to move forward.
Agreed: AFAICS the only open issue is whether the Solaris test should use the
`GNU` label as I have done, introduce an new common one (like `UNIX`; there's
nothing GNU-specific in that test), or really introduce a separate copy of the
check un
rorth wrote:
> I feel that we are bike-shedding here a bit. Please prioritise correctness -
> using `GNU` as a label for Solaris would not be correct. The following would
> be:
>
> * duplicating tests with a different label (e.g. `SOLARIS`) would be
> correct,
>
> * renaming the curr
https://github.com/rorth updated https://github.com/llvm/llvm-project/pull/65644
>From 31bdd3477d9f54996b71584598bdd75f2cef31db Mon Sep 17 00:00:00 2001
From: Rainer Orth
Date: Thu, 7 Sep 2023 19:19:32 +0200
Subject: [PATCH 1/2] [Driver] Link Flang runtime on Solaris
I noticed that `flang-new`
Author: Rainer Orth
Date: 2023-08-03T09:54:25+02:00
New Revision: d0dc887d7ed285688004c75de3784cfe94febd34
URL:
https://github.com/llvm/llvm-project/commit/d0dc887d7ed285688004c75de3784cfe94febd34
DIFF:
https://github.com/llvm/llvm-project/commit/d0dc887d7ed285688004c75de3784cfe94febd34.diff
L
Author: Rainer Orth
Date: 2023-08-03T20:01:13+02:00
New Revision: 43dfe0f08ecaf50f986512d0548bd3ac84d1813b
URL:
https://github.com/llvm/llvm-project/commit/43dfe0f08ecaf50f986512d0548bd3ac84d1813b
DIFF:
https://github.com/llvm/llvm-project/commit/43dfe0f08ecaf50f986512d0548bd3ac84d1813b.diff
L
https://github.com/rorth created
https://github.com/llvm/llvm-project/pull/65632:
As noticed in D158846, the Solaris driver deviates from other targets in that
it links every executable with `-lm`, but doesn't for shared objects. For C
code, this is unnecessary, while for C++ `libm` is always
https://github.com/rorth review_requested
https://github.com/llvm/llvm-project/pull/65632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rorth review_requested
https://github.com/llvm/llvm-project/pull/65632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/65632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rorth review_requested
https://github.com/llvm/llvm-project/pull/65644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rorth review_requested
https://github.com/llvm/llvm-project/pull/65644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rorth created
https://github.com/llvm/llvm-project/pull/65644:
I noticed that `flang-new` cannot link Fortran executables on Solaris since the
runtime libs are missing.
This patch fixes this, following `Gnu.cpp`. The `linker-flags.f90` testcase is
augmented to test for thi
https://github.com/rorth review_requested
https://github.com/llvm/llvm-project/pull/65644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4,6 +4,7 @@
! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 |
FileCheck %s --check-prefixes=CHECK,GNU
! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 |
FileCheck %s --check-prefixes=CHECK,DARWIN
+! RUN: %flang -### -target s
https://github.com/rorth edited https://github.com/llvm/llvm-project/pull/65644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4,6 +4,7 @@
! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 |
FileCheck %s --check-prefixes=CHECK,GNU
! RUN: %flang -### -target aarch64-apple-darwin %S/Inputs/hello.f90 2>&1 |
FileCheck %s --check-prefixes=CHECK,DARWIN
+! RUN: %flang -### -target s
rorth wrote:
I'd argue that handling the Flang runtime libs like C++ is the right thing to
do here. However, `flang-new` currently rejects all of `-r`, `-nostdlib`, and
`-nodefaultlibs` on both Linux and Solaris. On top of that, Solaris `clang`
doesn't handle `-r` correctly, passing `-e _sta
Author: Rainer Orth
Date: 2023-08-27T21:15:43+02:00
New Revision: 03dff0d4acafb61bbb3b765507de79c5e5b6681a
URL:
https://github.com/llvm/llvm-project/commit/03dff0d4acafb61bbb3b765507de79c5e5b6681a
DIFF:
https://github.com/llvm/llvm-project/commit/03dff0d4acafb61bbb3b765507de79c5e5b6681a.diff
L
Author: Rainer Orth
Date: 2023-08-28T09:25:47+02:00
New Revision: 779353e576eaa6ababdfc242784484f3656ecfe0
URL:
https://github.com/llvm/llvm-project/commit/779353e576eaa6ababdfc242784484f3656ecfe0
DIFF:
https://github.com/llvm/llvm-project/commit/779353e576eaa6ababdfc242784484f3656ecfe0.diff
L
Author: Rainer Orth
Date: 2023-09-01T20:02:37+02:00
New Revision: b1b1f364d63382637fa5f64871ee06bf74bd0405
URL:
https://github.com/llvm/llvm-project/commit/b1b1f364d63382637fa5f64871ee06bf74bd0405
DIFF:
https://github.com/llvm/llvm-project/commit/b1b1f364d63382637fa5f64871ee06bf74bd0405.diff
L
Author: Rainer Orth
Date: 2023-09-01T21:42:05+02:00
New Revision: d39a9e3b4d4afc0321fea72b9d6b8a3908c45fc1
URL:
https://github.com/llvm/llvm-project/commit/d39a9e3b4d4afc0321fea72b9d6b8a3908c45fc1
DIFF:
https://github.com/llvm/llvm-project/commit/d39a9e3b4d4afc0321fea72b9d6b8a3908c45fc1.diff
L
Author: Rainer Orth
Date: 2023-09-01T21:45:22+02:00
New Revision: 1bc7b753a5cd1599ecf0575d629460ba08f7121e
URL:
https://github.com/llvm/llvm-project/commit/1bc7b753a5cd1599ecf0575d629460ba08f7121e
DIFF:
https://github.com/llvm/llvm-project/commit/1bc7b753a5cd1599ecf0575d629460ba08f7121e.diff
L
https://github.com/rorth updated
https://github.com/llvm/llvm-project/pull/65489:
>From b867ca65e585427a6d02c245d90797a08f6dfc8e Mon Sep 17 00:00:00 2001
From: Rainer Orth
Date: Wed, 6 Sep 2023 16:35:27 +0200
Subject: [PATCH 1/2] [Driver] Always use gas with -fno-integrated-as on
Solaris
`cla
@@ -0,0 +1,11 @@
+/// General tests for assembler invocations on Solaris.
+
+/// Test that clang uses gas on Solaris.
+// RUN: %clang -x assembler %s -### -c -fno-integrated-as \
rorth wrote:
Sure, done.
https://github.com/llvm/llvm-project/pull/65489
__
https://github.com/rorth resolved
https://github.com/llvm/llvm-project/pull/65489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/65489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rorth wrote:
This patch broke the
[Solaris/amd64](https://lab.llvm.org/staging/#/builders/94/builds/4729)
buildbot.
For god's sake, can you please either test your Illumos patches on Solaris, too
(there are Solaris buildbots in the cfarm for exactly such a purpose) and
finally handle Issue #
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/98001
At the end of the recent flurry of Illumos (and implicitly Solaris) safestack
patches, the tests were disabled in
b0260c5b1052f8e3ff1ec77dc42a11f42da762cc without explanation.
After re-enabling them, there were man
rorth wrote:
The mentioned patch to switch safestack to use the `sanitizer_common` functions
instead of their own ones in `sanitizer_platform.h` has to wait until this one
is approved: AFAIT github doesn't support stacked pull requests.
https://github.com/llvm/llvm-project/pull/98001
_
rorth wrote:
> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
> You can test this locally with the following command:
> View the diff from clang-format here.
>
> ```diff
> diff --git a/compiler-rt/lib/safestack/safestack_platform.h
> b/compiler-rt/lib/safestack/safestack_pl
https://github.com/rorth created
https://github.com/llvm/llvm-project/pull/107403
Once PR #107223 lands, ASan can be enabled on Solaris/SPARC. This patch does
just that. As on Solaris/x86, the dynamic ASan runtime lib needs to be linked
with `-z now` to avoid an `AsanInitInternal` cycle.
Te
rorth wrote:
> Do we still need to fix this for 19.1.0-final?
I think so, yes. E.g. when building on LLVM without specifying
`LLVM_HOST_TRIPLE` explicitly (like when using `test-release.sh`), the
`config.guess` output is used which is `sparc64-unknown-linux-gnu`. However,
`compiler-rt` alwa
@@ -766,9 +766,19 @@ ToolChain::getTargetSubDirPath(StringRef BaseDir) const {
return {};
};
- if (auto Path = getPathForTriple(getTriple()))
+ llvm::Triple Triple = getTriple();
+
+ // Try triple as is.
+ if (auto Path = getPathForTriple(Triple))
return *Path;
rorth wrote:
FWIW, the hack even breaks when doing a `Debug` build: in that case the
unresolved reference returns despite the hack.
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
rorth wrote:
The patch also broke the [Solaris/sparcv9
buildbot](https://lab.llvm.org/buildbot/#/builders/13/builds/1579).
https://github.com/llvm/llvm-project/pull/96240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/rorth created
https://github.com/llvm/llvm-project/pull/100091
As explained in [[Driver] Support non-canonical triples with new runtime lib
layout](https://reviews.llvm.org/D133407), there are massive problems if
`clang`'s and `compiler-rt`'s ideas of the target triple don't
rorth wrote:
This seems to have broken the
[Solaris/amd64](https://lab.llvm.org/staging/#/builders/120/builds/187) and
[Solaris/sparcv9](https://lab.llvm.org/buildbot/#/builders/13/builds/1030)
buildbots.
https://github.com/llvm/llvm-project/pull/99075
rorth wrote:
> Aha!
>
> https://bugs.llvm.org/show_bug.cgi?id=33767
Ah, old sins (from the GCC side no less) keep haunting me.
> We have a mixture of both `std::tm` and `::tm` in here, try switching to
> using `::tm` and see if that helps.
Unfortunately not: I always get the undefined refere
rorth wrote:
> If you dump the symbols from the STL shared library on the system, is there
> one for `time_put` at all? If so, what is the mangled symbol it exports?
While the source requires
```
_ZNKSt8time_putIcSt19ostreambuf_iteratorIcSt11char_traitsIcEEE3putES3_RSt8ios_basecPKSt2tmPKcSB_
s
rorth wrote:
At least in the short term. ISTM that `clang++` may need to do something along
the lines of Bug 33767 (resp. the underlying GCC bug/patch), otherwise users
are in for a nasty surprise.
https://github.com/llvm/llvm-project/pull/99075
___
rorth wrote:
> > At least in the short term. ISTM that `clang++` may need to do something
> > along the lines of Bug 33767 (resp. the underlying GCC bug/patch),
> > otherwise users are in for a nasty surprise.
>
> Agreed; long-term we need a better solution. Hopefully someone maintaining
> So
https://github.com/rorth created
https://github.com/llvm/llvm-project/pull/100724
The introduction of `std::put_time` in
fad17b43dbc09ac7e0a95535459845f72c2b739a broke the Solaris build:
```
Undefined first referenced
symbol in file
_ZNKSt8time_
rorth wrote:
> Thank you for helping out with this odd edge case! I don't suppose there's a
> way we can shove this hack into CMake (basically, like a kind of linker
> script hack)? If so, can we apply it broadly enough so that any use of
> `time_put` in other TUs will also benefit?
This woul
rorth wrote:
> > Whatever the case, we need at least a short-term solution now: the Solaris
> > buildbots have been broken for two days now.
>
> Agreed that we need something in the short term, I'm just trying to find the
> cleanest "something" under the assumption that this hack will live for
rorth wrote:
Right, as is it's just a ugly hack with the underlying problem like to rear its
ugly head again in the future.
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rorth milestoned
https://github.com/llvm/llvm-project/pull/100091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 160 matches
Mail list logo
