rorth wrote: > I feel that we are bike-shedding here a bit. Please prioritise correctness - > using `GNU` as a label for Solaris would not be correct. The following would > be: > > * duplicating tests with a different label (e.g. `SOLARIS`) would be > correct, > > * renaming the current label from `GNU` to e.g. `UNIX` would be correct. > > > Unless I am missing something?
I'd go for renaming the label to `UNIX` then: it avoids unnecessary duplication and better describes what those cases are about. https://github.com/llvm/llvm-project/pull/65644 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
