[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. Herald added subscribers: cfe-commits, guansong. Add the capability to nest multiple declare target directives - including header files within a declare

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster added a comment. In https://reviews.llvm.org/D51378#1216600, @RaviNarayanaswamy wrote: > Is there a way to tell if the header files have matching omp declare > target/omp end declare target. > The reason is if one of the header files is missing a matching omp end > declare targ

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster added a comment. In https://reviews.llvm.org/D51378#1218184, @RaviNarayanaswamy wrote: > We should just go with generating an error if the DeclareTargetNestingLevel > is not 0 at the end of compilation unit. > Hard to detect if user accidentally forgot to have end declare in hea

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster added a comment. In https://reviews.llvm.org/D51378#1219474, @RaviNarayanaswamy wrote: > I did not see the code where check is done if Nestingdepth is 0 at end of > compilation. Sorry I should clarify. You will get an error if you have an unmatched `#pragma omp declare target` o

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster updated this revision to Diff 164037. patricklyster added a comment. Previous implementation only supported immediately nested declare targets such as below: #pragma omp declare target #pragma omp declare target int foo(); #pragma omp end declare target int bar(

[PATCH] D52097: [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer - NFC

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: OpenMP, clang. Herald added subscribers: cfe-commits, jfb, guansong. Move declarations for `OMPClauseReader`, `OMPClauseWrit

[PATCH] D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added a project: clang. Herald added subscribers: cfe-commits, arphaman, guansong. Added new `dynamic_allocators` clause to existing OMP5.0

[PATCH] D53079: [OPENMP] Add 'dynamic_allocators' clause to OMP5.0 'requires' directive

patricklyster closed this revision. patricklyster added a comment. Closed by commit https://reviews.llvm.org/rL344249 sha: 851f70b951e5e068b0afa6f69ec58e0e80b0a1a4 Repository: rC Clang https://reviews.llvm.org/D53079 ___ cfe-commits mailing list

[PATCH] D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added subscribers: cfe-commits, jfb, arphaman, guansong. Added new `atomic_default_mem_order` clause w

[PATCH] D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive

patricklyster added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:930 + /// Returns location of clause kind. + SourceLocation getAtomicDefaultMemOrderKindKwLoc() const { return KindKwLoc; } + ABataev wrote: > Again, probably too long line

[PATCH] D54493: [OPENMP] Check target architecture supports unified shared memory for requires directive

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: OpenMP, clang. Herald added subscribers: cfe-commits, guansong, jholewinski. Restriction on `unified_shared_memory` clause o

[PATCH] D52359: [OPENMP] Add support for OMP5 requires directive + unified_address clause

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added subscribers: cfe-commits, jfb, guansong, jholewinski. Add support for new OMP5.0 `requires` dire

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added a subscriber: guansong. Added new `unified_shared_memory` clause to existing OMP5.0 `requires` d

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster added a comment. In https://reviews.llvm.org/D52625#1248436, @ABataev wrote: > I forgot to mention that you need an ast print test (the positive test) Thanks for the reminder. I will add that Repository: rC Clang https://reviews.llvm.org/D52625

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster updated this revision to Diff 167459. patricklyster added a comment. Added AST print test for `unified_shared_memory https://reviews.llvm.org/D52625 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/OpenMPKi

[PATCH] D52780: [OPENMP] Add 'reverse_offload' clause to OMP5.0 'requires' directive

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added subscribers: cfe-commits, arphaman, guansong. Added new `reverse_offload` clause to existing OMP

[PATCH] D55982: [OPENMP] Add support for explicit mapping of classes using 'this' pointer

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added subscribers: cfe-commits, guansong. Add support for explicit mapping of `this` pointer in OpenMP