I can commit sometime today; thanks.
-- HT
On Thu, Aug 16, 2018 at 1:24 PM, Marshall Clow via Phabricator <
revi...@reviews.llvm.org> wrote:
> mclow.lists accepted this revision.
> mclow.lists added a comment.
> This revision is now accepted and ready to land.
>
> This LGTM. Do you want me to co
Author: hubert.reinterpretcast
Date: Thu Aug 16 16:56:54 2018
New Revision: 339969
URL: http://llvm.org/viewvc/llvm-project?rev=339969&view=rev
Log:
[libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback
Summary:
When a seed sequence would lead to having no non-zero significant bits
Author: hubert.reinterpretcast
Date: Wed Jan 3 17:15:52 2018
New Revision: 321778
URL: http://llvm.org/viewvc/llvm-project?rev=321778&view=rev
Log:
Replace cp -a in various Clang tests
Summary:
cp -a is neither part of POSIX nor the LSB. The nearest equivalent under
POSIX is cp -RPp; however, cp
Author: hubert.reinterpretcast
Date: Thu Jan 4 14:58:30 2018
New Revision: 321828
URL: http://llvm.org/viewvc/llvm-project?rev=321828&view=rev
Log:
Use backslash escape, replacing xargs -0 in test macro-multiline.c
Summary:
xargs supports escaping of newline characters with backslash.
xargs -0 i
Author: hubert.reinterpretcast
Date: Thu Jan 4 15:03:48 2018
New Revision: 321830
URL: http://llvm.org/viewvc/llvm-project?rev=321830&view=rev
Log:
Use POSIX argument syntax in test rewrite-includes-messages.c
Invoke diff such that options precede operands. Not doing so leads to
unspecified beha
I am also hitting this. GCC 4.8 is still the minimum at this time.
-- HT
On Tue, Jan 22, 2019 at 8:10 AM Axel Naumann via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> This broke our clang builds with
>
> $ gcc --version
> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
>
> on CentOS Li
Author: hubert.reinterpretcast
Date: Sat Mar 23 11:10:45 2019
New Revision: 356843
URL: http://llvm.org/viewvc/llvm-project?rev=356843&view=rev
Log:
libclang/CIndexer.cpp: Use loadquery() on AIX for path to library
Summary:
`dladdr` is not available on AIX. Similar functionality is presented
thro
Author: hubert.reinterpretcast
Date: Fri Mar 29 16:33:04 2019
New Revision: 357334
URL: http://llvm.org/viewvc/llvm-project?rev=357334&view=rev
Log:
[lit] Set shlibpath_var on AIX
Summary:
When building the `check-all` target on AIX, lit produces
```
warning: unable to inject shared library path
Author: hubert.reinterpretcast
Date: Wed May 1 08:53:56 2019
New Revision: 359691
URL: http://llvm.org/viewvc/llvm-project?rev=359691&view=rev
Log:
[analyzer][tests] Use diff_plist, correct order of arguments for missed cases;
NFC
For various files under `clang/test/Analysis`, D52036 applied
`%
Author: hubert.reinterpretcast
Date: Wed May 1 08:57:00 2019
New Revision: 359692
URL: http://llvm.org/viewvc/llvm-project?rev=359692&view=rev
Log:
[analyzer][tests][NFC] Add EOF newlines, normalize reference expected files
Reference expected files not ending with a newline are normalized to
hav
Author: hubert.reinterpretcast
Date: Wed Feb 13 12:17:13 2019
New Revision: 353975
URL: http://llvm.org/viewvc/llvm-project?rev=353975&view=rev
Log:
[PowerPC] Stop defining _ARCH_PWR6X on POWER7 and up
Summary:
The predefined macro `_ARCH_PWR6X` is associated with GCC's
`-mcpu=power6x` option, wh
Author: hubert.reinterpretcast
Date: Sat Jun 8 06:48:25 2019
New Revision: 362876
URL: http://llvm.org/viewvc/llvm-project?rev=362876&view=rev
Log:
[analyzer][NFC][tests] Remove unused expected-plist files
Removed:
cfe/trunk/test/Analysis/Inputs/expected-plists/cstring-plist.c.plist
cfe/
Author: hubert.reinterpretcast
Date: Sat Jun 8 06:51:37 2019
New Revision: 362877
URL: http://llvm.org/viewvc/llvm-project?rev=362877&view=rev
Log:
[analyzer][NFC][tests] Pre-normalize expected-plists
As suggested in the review for D62949, this patch pre-normalizes the
reference expected output
Author: hubert.reinterpretcast
Date: Mon Jun 10 15:28:20 2019
New Revision: 362991
URL: http://llvm.org/viewvc/llvm-project?rev=362991&view=rev
Log:
[CUDA] Fix grep pattern in cuda-types.cu
Summary:
vertical-line is not a BRE special character.
POSIX.1-2017 XBD Section 9.3.2 indicates that the i
Author: hubert.reinterpretcast
Date: Mon Jun 10 15:30:57 2019
New Revision: 362992
URL: http://llvm.org/viewvc/llvm-project?rev=362992&view=rev
Log:
[PlistSupport] Produce a newline to end plist output files
Summary:
As suggested in the review of D62949, this patch updates the plist
output to hav
Author: hubert.reinterpretcast
Date: Mon Jun 10 15:33:34 2019
New Revision: 362994
URL: http://llvm.org/viewvc/llvm-project?rev=362994&view=rev
Log:
[analyzer][tests] Add normalize_plist to replace diff_plist
Summary:
The `%diff_plist` lit substitution invokes `diff` with a non-portable
`-I` opti
Author: hubert.reinterpretcast
Date: Mon Jun 10 15:37:31 2019
New Revision: 362996
URL: http://llvm.org/viewvc/llvm-project?rev=362996&view=rev
Log:
[analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)
Summary:
The `%diff_plist` lit substitution invokes `diff` with a non-por
Author: hubert.reinterpretcast
Date: Mon Jun 10 15:40:35 2019
New Revision: 362998
URL: http://llvm.org/viewvc/llvm-project?rev=362998&view=rev
Log:
[analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)
Summary:
The `%diff_plist` lit substitution invokes `diff` with a non-po
Author: hubert.reinterpretcast
Date: Tue Jun 11 07:21:32 2019
New Revision: 363069
URL: http://llvm.org/viewvc/llvm-project?rev=363069&view=rev
Log:
Reapply r362994 & co "[analyzer][tests] Add normalize_plist to replace
diff_plist"
Following r363007, which reverted r362998, r362996, and r362994,
Author: hubert.reinterpretcast
Date: Tue Jun 11 07:23:55 2019
New Revision: 363070
URL: http://llvm.org/viewvc/llvm-project?rev=363070&view=rev
Log:
[NFC][PowerPC] Header-dependent test requires "native"
Two recently added tests mention complications for cross-compile, but
they do not actually en
Author: hubert.reinterpretcast
Date: Wed Jun 19 04:19:51 2019
New Revision: 363788
URL: http://llvm.org/viewvc/llvm-project?rev=363788&view=rev
Log:
[analyzer][NFC][tests] Pre-normalize expected-sarif files
As discussed in the review for D62952, this patch pre-normalizes the
reference expected ou
Author: hubert.reinterpretcast
Date: Wed Jun 19 08:27:35 2019
New Revision: 363822
URL: http://llvm.org/viewvc/llvm-project?rev=363822&view=rev
Log:
[analyzer] SARIF: Add EOF newline; replace diff_sarif
Summary:
This patch applies a change similar to rC363069, but for SARIF files.
The `%diff_sar
Author: hubert.reinterpretcast
Date: Wed Jun 19 08:48:12 2019
New Revision: 363826
URL: http://llvm.org/viewvc/llvm-project?rev=363826&view=rev
Log:
[NFC][codeview] Avoid undefined grep in debug-info-codeview-display-name.cpp
vertical-line is not a BRE special character.
POSIX.1-2017 XBD Section
Author: hubert.reinterpretcast
Date: Fri Jul 19 01:46:18 2019
New Revision: 366544
URL: http://llvm.org/viewvc/llvm-project?rev=366544&view=rev
Log:
[sanitizers] Use covering ObjectFormatType switches
Summary:
This patch removes the `default` case from some switches on
`llvm::Triple::ObjectFormat
Author: hubert.reinterpretcast
Date: Fri Jul 26 13:09:37 2019
New Revision: 367147
URL: http://llvm.org/viewvc/llvm-project?rev=367147&view=rev
Log:
Partially revert rC365414; `ln -n` is not portable
This restores the use of `rm` instead of the non-portable `ln -n`. Such
use being the status quo
Author: hubert.reinterpretcast
Date: Fri Aug 2 12:26:05 2019
New Revision: 367709
URL: http://llvm.org/viewvc/llvm-project?rev=367709&view=rev
Log:
[Driver][test] Avoid undefined grep in darwin-ld.c
Summary:
question-mark is not a BRE special character.
POSIX.1-2017 XBD Section 9.3.2 indicates
Author: hubert.reinterpretcast
Date: Tue Aug 13 06:38:15 2019
New Revision: 368690
URL: http://llvm.org/viewvc/llvm-project?rev=368690&view=rev
Log:
[AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX
Summary:
Some tests perform deep recursion, which requires a larger pthread stack
size than th
I don't see how the resolution of Core Issue 2140 changes the status of
nullptr_t lvalue-to-rvalue conversion for constexpr evaluation. PR42440 has
been opened concerning the change to constexpr evaluation.
-- HT
On Fri, Jun 14, 2019 at 1:43 PM Richard Smith via cfe-commits <
cfe-commits@lists.ll
Author: hubert.reinterpretcast
Date: Thu Jul 4 14:40:28 2019
New Revision: 365160
URL: http://llvm.org/viewvc/llvm-project?rev=365160&view=rev
Log:
[NFC] Make some ObjectFormatType switches covering
Summary:
This patch removes the `default` case from some switches on
`llvm::Triple::ObjectFormatT
Author: hubert.reinterpretcast
Date: Wed Dec 12 08:53:43 2018
New Revision: 348938
URL: http://llvm.org/viewvc/llvm-project?rev=348938&view=rev
Log:
[ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element
types
Summary:
`memchr` and `memcmp` operate upon the character units
Author: Hubert Tong
Date: 2020-05-31T16:38:10-04:00
New Revision: c15d5d12c625df52bf82828a6af5ef2dfb6b4533
URL:
https://github.com/llvm/llvm-project/commit/c15d5d12c625df52bf82828a6af5ef2dfb6b4533
DIFF:
https://github.com/llvm/llvm-project/commit/c15d5d12c625df52bf82828a6af5ef2dfb6b4533.diff
L
Author: Hubert Tong
Date: 2020-04-14T18:38:35-04:00
New Revision: 021a333bfca363ecb672d22dcff6295d4ecee3b7
URL:
https://github.com/llvm/llvm-project/commit/021a333bfca363ecb672d22dcff6295d4ecee3b7
DIFF:
https://github.com/llvm/llvm-project/commit/021a333bfca363ecb672d22dcff6295d4ecee3b7.diff
L
Author: Hubert Tong
Date: 2020-04-15T10:45:00-04:00
New Revision: a73a81dce5bcae4f14004c09ee1844d7572d4f1e
URL:
https://github.com/llvm/llvm-project/commit/a73a81dce5bcae4f14004c09ee1844d7572d4f1e
DIFF:
https://github.com/llvm/llvm-project/commit/a73a81dce5bcae4f14004c09ee1844d7572d4f1e.diff
L
@shuhong@ibm.com: I'm not sure what process you followed to commit
this, but the commit message does not seem right. It might make sense to
revert this and commit again with the proper message to make annotations
from `git blame` work better.
-- HT
On Mon, Aug 10, 2020 at 10:33 AM Shuhong Liu
Author: Abhina Sreeskantharajan
Date: 2020-08-13T16:02:07-04:00
New Revision: dedaf78fa71433d3c9da2e3d2f3dad3e9cd3bdd2
URL:
https://github.com/llvm/llvm-project/commit/dedaf78fa71433d3c9da2e3d2f3dad3e9cd3bdd2
DIFF:
https://github.com/llvm/llvm-project/commit/dedaf78fa71433d3c9da2e3d2f3dad3e9cd3
Author: Hubert Tong
Date: 2020-05-08T16:51:34-04:00
New Revision: b116ded57da3530e661f871f4191c59cd9e091cd
URL:
https://github.com/llvm/llvm-project/commit/b116ded57da3530e661f871f4191c59cd9e091cd
DIFF:
https://github.com/llvm/llvm-project/commit/b116ded57da3530e661f871f4191c59cd9e091cd.diff
L
Author: Hubert Tong
Date: 2020-05-15T17:34:00-04:00
New Revision: 15f0f824b36ea06fcb17bc56ecd181520b4bfbcf
URL:
https://github.com/llvm/llvm-project/commit/15f0f824b36ea06fcb17bc56ecd181520b4bfbcf
DIFF:
https://github.com/llvm/llvm-project/commit/15f0f824b36ea06fcb17bc56ecd181520b4bfbcf.diff
L
Author: Hubert Tong
Date: 2020-05-15T17:34:00-04:00
New Revision: 3f5fc73a9d52fc7f128dc4e53ccc63b88fc44fb6
URL:
https://github.com/llvm/llvm-project/commit/3f5fc73a9d52fc7f128dc4e53ccc63b88fc44fb6
DIFF:
https://github.com/llvm/llvm-project/commit/3f5fc73a9d52fc7f128dc4e53ccc63b88fc44fb6.diff
L
hubert.reinterpretcast added a comment.
A test should probably be added as well.
https://reviews.llvm.org/D25480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D25480#567552, @ahatanak wrote:
> __builtin_fpclassify takes five int arguments followed by one last argument
> that is of floating point type. Do you know if there is a way to specify the
> last one argument is a floating poin
hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: rsmith, faisalv, aaron.ballman.
hubert.reinterpretcast added subscribers: nwilson, cfe-commits.
This adds associated constraints as a property of class templates.
An error is produced if redeclarations are not si
Author: hubert.reinterpretcast
Date: Wed Dec 6 16:34:20 2017
New Revision: 319992
URL: http://llvm.org/viewvc/llvm-project?rev=319992&view=rev
Log:
Remove old concepts parsing code
Summary:
This is so we can implement concepts per P0734R0. Relevant failing test
cases are disabled.
Reviewers: hu
hubert-reinterpretcast wrote:
> The manual change says "the TOC data transformation will be applied to [...]
> block-scope static variables". But later, you mention "internal linkage",
> which is a bit confusing when you're dealing with C++. Block-scope static
> variables don't have "linkage"
Author: Hubert Tong
Date: 2022-07-01T00:03:58-04:00
New Revision: 6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7
URL:
https://github.com/llvm/llvm-project/commit/6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7
DIFF:
https://github.com/llvm/llvm-project/commit/6bd53df9b6e9fffb440ee2f9020f15b61f8b39e7.diff
L
Author: Hubert Tong
Date: 2022-07-08T18:33:16-04:00
New Revision: bd8b55e609c825f1063a28ef94502a6bfed7a0fd
URL:
https://github.com/llvm/llvm-project/commit/bd8b55e609c825f1063a28ef94502a6bfed7a0fd
DIFF:
https://github.com/llvm/llvm-project/commit/bd8b55e609c825f1063a28ef94502a6bfed7a0fd.diff
L
Author: Hubert Tong
Date: 2022-03-24T20:17:49-04:00
New Revision: ce21c926f8efe969717e21e3ae6c5a3246b3d455
URL:
https://github.com/llvm/llvm-project/commit/ce21c926f8efe969717e21e3ae6c5a3246b3d455
DIFF:
https://github.com/llvm/llvm-project/commit/ce21c926f8efe969717e21e3ae6c5a3246b3d455.diff
L
Author: Anjan Kumar Guttahalli Krishna
Date: 2021-07-22T15:47:22-04:00
New Revision: 7d669ec1d67c1b4aecd90687013636d8037c
URL:
https://github.com/llvm/llvm-project/commit/7d669ec1d67c1b4aecd90687013636d8037c
DIFF:
https://github.com/llvm/llvm-project/commit/7d669ec1d67c1b4aecd906870
Author: Hubert Tong
Date: 2022-03-23T11:07:56-04:00
New Revision: da167a53c87f53ce582de6cc122d5e090f341b42
URL:
https://github.com/llvm/llvm-project/commit/da167a53c87f53ce582de6cc122d5e090f341b42
DIFF:
https://github.com/llvm/llvm-project/commit/da167a53c87f53ce582de6cc122d5e090f341b42.diff
L
Author: Ken Matsui
Date: 2022-04-28T22:22:27-04:00
New Revision: 52ce95a1a55424256f0d56e32392396896ed7f76
URL:
https://github.com/llvm/llvm-project/commit/52ce95a1a55424256f0d56e32392396896ed7f76
DIFF:
https://github.com/llvm/llvm-project/commit/52ce95a1a55424256f0d56e32392396896ed7f76.diff
LO
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation
Loc, FieldDecl *Field) {
ImmediateCallVisitor V(getASTContext());
if (!NestedDefaultChecking)
V.TraverseDecl(Field);
- if (V.HasImmediateCalls) {
+ if (V.HasImmediateCalls || InLifetimeEx
hubert-reinterpretcast wrote:
@daltenty, can we also have a check that the driver does not pass `-pthread` to
the frontend when `-no-pthread` is used?
As a complication, I think the code responsible is common cross-platform code
in
[clang/Driver/ToolChains/Clang.cpp](https://github.com/llvm/l
Author: Abhina Sreeskantharajan
Date: 2020-08-25T15:51:59-04:00
New Revision: 97ccf93b3615ff4c0d5fe116e6a7c7b616d8ec0c
URL:
https://github.com/llvm/llvm-project/commit/97ccf93b3615ff4c0d5fe116e6a7c7b616d8ec0c
DIFF:
https://github.com/llvm/llvm-project/commit/97ccf93b3615ff4c0d5fe116e6a7c7b616d8
Author: Hubert Tong
Date: 2020-08-31T17:57:22-04:00
New Revision: d563d7a7313cf47dcb24c6370a035bd803965b4e
URL:
https://github.com/llvm/llvm-project/commit/d563d7a7313cf47dcb24c6370a035bd803965b4e
DIFF:
https://github.com/llvm/llvm-project/commit/d563d7a7313cf47dcb24c6370a035bd803965b4e.diff
L
Author: Hubert Tong
Date: 2020-11-08T12:07:51-05:00
New Revision: 09fc7796e57417071523c82bdac8b3bf050648a0
URL:
https://github.com/llvm/llvm-project/commit/09fc7796e57417071523c82bdac8b3bf050648a0
DIFF:
https://github.com/llvm/llvm-project/commit/09fc7796e57417071523c82bdac8b3bf050648a0.diff
L
Author: Hubert Tong
Date: 2020-09-30T17:01:32-04:00
New Revision: ae4c400e02fc3f7cff11cc332e6b107353b3e6a2
URL:
https://github.com/llvm/llvm-project/commit/ae4c400e02fc3f7cff11cc332e6b107353b3e6a2
DIFF:
https://github.com/llvm/llvm-project/commit/ae4c400e02fc3f7cff11cc332e6b107353b3e6a2.diff
L
Author: Hubert Tong
Date: 2020-10-01T15:57:01-04:00
New Revision: 35ecc7fe49ba881a77e8146b51870a60a52b211f
URL:
https://github.com/llvm/llvm-project/commit/35ecc7fe49ba881a77e8146b51870a60a52b211f
DIFF:
https://github.com/llvm/llvm-project/commit/35ecc7fe49ba881a77e8146b51870a60a52b211f.diff
L
The bots don't seem happy building with a Clang that incorporates this
change:
```
/b/sanitizer-x86_64-linux-bootstrap/build/llvm-project/clang/lib/ASTMatchers/ASTMatchersInternal.cpp:943:5:
error: redefinition of 'hasAnyName' with a different type: 'const
VariadicFunction<...>' vs 'const VariadicF
ParsedASTTest.TopLevelDecls has not recovered on clang-ppc64le-rhel since
this went in (even when including f1bf41e433e196ecffcc4fb7cd04c58d48445425,
which is purported to fix buildbot failures from this commit).
http://lab.llvm.org:8011/#/builders/57/builds/81
On Mon, Oct 12, 2020 at 5:06 AM Hao
On Mon, Oct 12, 2020 at 9:43 AM Haojian Wu wrote:
> sorry, I'm looking at it.
>
No problem, thanks!
> On Mon, 12 Oct 2020 at 15:35, Hubert Tong <
> hubert.reinterpretc...@gmail.com> wrote:
>
>> ParsedASTTest.TopLevelDecls has not recovered on clang-ppc64le-rhel since
>> this went in (even when
Author: Hubert Tong
Date: 2020-11-24T12:15:07-05:00
New Revision: 44174b3d518ed70482ff5df2879523a4e26f92cc
URL:
https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc
DIFF:
https://github.com/llvm/llvm-project/commit/44174b3d518ed70482ff5df2879523a4e26f92cc.diff
L
Author: Hubert Tong
Date: 2020-10-18T12:39:16-04:00
New Revision: 126094485ab99dac3e6df9c201124d48a1d798ce
URL:
https://github.com/llvm/llvm-project/commit/126094485ab99dac3e6df9c201124d48a1d798ce
DIFF:
https://github.com/llvm/llvm-project/commit/126094485ab99dac3e6df9c201124d48a1d798ce.diff
L
Author: Hubert Tong
Date: 2020-10-20T20:52:10-04:00
New Revision: 134ffa8138c31444685013e10f592cd7c88d675b
URL:
https://github.com/llvm/llvm-project/commit/134ffa8138c31444685013e10f592cd7c88d675b
DIFF:
https://github.com/llvm/llvm-project/commit/134ffa8138c31444685013e10f592cd7c88d675b.diff
L
Author: Hubert Tong
Date: 2021-05-15T22:41:45-04:00
New Revision: 9ae529d0db2d6841b3b2e49525e03b33e8445636
URL:
https://github.com/llvm/llvm-project/commit/9ae529d0db2d6841b3b2e49525e03b33e8445636
DIFF:
https://github.com/llvm/llvm-project/commit/9ae529d0db2d6841b3b2e49525e03b33e8445636.diff
L
Author: Hubert Tong
Date: 2021-05-20T09:51:21-04:00
New Revision: 603818b97c795114f66a6fc13e8a5f0e54b49a13
URL:
https://github.com/llvm/llvm-project/commit/603818b97c795114f66a6fc13e8a5f0e54b49a13
DIFF:
https://github.com/llvm/llvm-project/commit/603818b97c795114f66a6fc13e8a5f0e54b49a13.diff
L
On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> We talked about this with the IWG (Infrastructure Working Group) just
> last week coincidentally.
> Two major blocking tracks that were identified at the roundtable
> during the LLVM Dev Meeting exac
On Tue, Jun 8, 2021 at 11:43 AM Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Jun 07, 2021 at 07:04:36PM -0700, via cfe-commits wrote:
> >
> > Author: =Jake Egan
> > Date: 2021-06-07T22:04:18-04:00
> > New Revision: e6629be31e67190f0a524f009752d73410894560
> >
>
On Fri, Jul 30, 2021 at 12:05 PM Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> Author: Paul Robinson
> Date: 2021-07-30T09:05:14-07:00
> New Revision: 9ca905b52d53c46aceb4d28e44dfbf4a815d0c68
>
> URL:
> https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44
On Fri, Jul 30, 2021 at 12:59 PM wrote:
> Do you have a suggestion for how to fix it? This isn’t actually my test,
> I tripped over it and it seemed like it would be easy to get it to work.
> ☹
>
I think removing all of the `-target` options might help. Alternatively, I
don't see why the test s
Author: Hubert Tong
Date: 2022-11-04T12:26:53-04:00
New Revision: 6ace52e5e49cff6664fc301fa4985fc28c88f26f
URL:
https://github.com/llvm/llvm-project/commit/6ace52e5e49cff6664fc301fa4985fc28c88f26f
DIFF:
https://github.com/llvm/llvm-project/commit/6ace52e5e49cff6664fc301fa4985fc28c88f26f.diff
L
Author: Nicole Rabjohn
Date: 2023-01-24T01:14:05-05:00
New Revision: 0f5099cd94226479fe30b4fc2d6a9743ebe2b12b
URL:
https://github.com/llvm/llvm-project/commit/0f5099cd94226479fe30b4fc2d6a9743ebe2b12b
DIFF:
https://github.com/llvm/llvm-project/commit/0f5099cd94226479fe30b4fc2d6a9743ebe2b12b.diff
@@ -660,14 +671,16 @@ void PPCAsmPrinter::EmitTlsCall(const MachineInstr *MI,
"GETtls[ld]ADDR[32] must read GPR3");
if (Subtarget->isAIXABI()) {
-// On AIX, the variable offset should already be in R4 and the region
handle
-// should already be in R3.
-
Author: Zheng Qian
Date: 2023-07-24T22:56:18-04:00
New Revision: cead1497ae0c1d57ee6883500c7c205f83798440
URL:
https://github.com/llvm/llvm-project/commit/cead1497ae0c1d57ee6883500c7c205f83798440
DIFF:
https://github.com/llvm/llvm-project/commit/cead1497ae0c1d57ee6883500c7c205f83798440.diff
LO
@@ -807,6 +807,7 @@ ArrayRef
PPCTargetInfo::getGCCRegAliases() const {
// PPC ELFABIv2 DWARF Definitoin "Table 2.26. Mappings of Common Registers".
// vs0 ~ vs31 is mapping to 32 - 63,
// vs32 ~ vs63 is mapping to 77 - 108.
+// And this mapping applies to all OSes which runs o
@@ -2,6 +2,10 @@
// RUN: %clang_cc1 -triple powerpc64le-unknown-linux-gnu -target-feature +vsx \
// RUN: -target-cpu pwr9 -emit-llvm %s -o - | FileCheck %s
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix -target-feature +vsx \
+// RUN: -target-cpu pwr9 -emit-llvm %s -o - | F
https://github.com/hubert-reinterpretcast edited
https://github.com/llvm/llvm-project/pull/68476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -807,7 +807,7 @@ ArrayRef
PPCTargetInfo::getGCCRegAliases() const {
// PPC ELFABIv2 DWARF Definitoin "Table 2.26. Mappings of Common Registers".
// vs0 ~ vs31 is mapping to 32 - 63,
// vs32 ~ vs63 is mapping to 77 - 108.
hubert-reinterpretcast wrote:
I am
@@ -807,7 +807,7 @@ ArrayRef
PPCTargetInfo::getGCCRegAliases() const {
// PPC ELFABIv2 DWARF Definitoin "Table 2.26. Mappings of Common Registers".
// vs0 ~ vs31 is mapping to 32 - 63,
// vs32 ~ vs63 is mapping to 77 - 108.
hubert-reinterpretcast wrote:
> To
@@ -828,10 +829,7 @@ const TargetInfo::AddlRegName GCCAddlRegNames[] = {
};
ArrayRef PPCTargetInfo::getGCCAddlRegNames() const {
- if (ABI == "elfv2")
-return llvm::ArrayRef(GCCAddlRegNames);
- else
-return TargetInfo::getGCCAddlRegNames();
+ return llvm::ArrayRef(G
@@ -807,7 +807,7 @@ ArrayRef
PPCTargetInfo::getGCCRegAliases() const {
// PPC ELFABIv2 DWARF Definitoin "Table 2.26. Mappings of Common Registers".
// vs0 ~ vs31 is mapping to 32 - 63,
// vs32 ~ vs63 is mapping to 77 - 108.
hubert-reinterpretcast wrote:
> I p
https://github.com/hubert-reinterpretcast approved this pull request.
LGTM, but I am not sure if @stefanp-ibm continues to be concerned about
enabling this for ABIs that have not been updated to specify a treatment of the
VSX registers.
https://github.com/llvm/llvm-project/pull/68476
_
hubert-reinterpretcast wrote:
The code formatting check failure seems to be a infrastructure problem:
https://discourse.llvm.org/t/clang-format-github-action-cannot-find-merge-base/73894
https://github.com/llvm/llvm-project/pull/68476
___
cfe-commits
https://github.com/hubert-reinterpretcast edited
https://github.com/llvm/llvm-project/pull/66316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -660,14 +671,16 @@ void PPCAsmPrinter::EmitTlsCall(const MachineInstr *MI,
"GETtls[ld]ADDR[32] must read GPR3");
if (Subtarget->isAIXABI()) {
-// On AIX, the variable offset should already be in R4 and the region
handle
-// should already be in R3.
-
https://github.com/hubert-reinterpretcast edited
https://github.com/llvm/llvm-project/pull/66316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Zheng Qian
Date: 2023-07-15T16:13:48-04:00
New Revision: bb6ab91b1dcd2fadfddffcd020439978af184862
URL:
https://github.com/llvm/llvm-project/commit/bb6ab91b1dcd2fadfddffcd020439978af184862
DIFF:
https://github.com/llvm/llvm-project/commit/bb6ab91b1dcd2fadfddffcd020439978af184862.diff
LO
I have not found which of the few commits on Friday having to do with
template-ids is responsible, but this now produces a crash (trace is below):
struct A;
struct B : A {};
Richard, would you take a look?
Thanks,
Hubert Tong
:2:12: error: unknown template name 'A'
struct B : A {};
Following this commit, the error recovery for invalid cases that explicitly
define (out-of-line) a member function template as deleted and attempts to
instantiate said function appears broken.
:4:35: error: deleted definition must be first declaration
template void A::f() = delete;
Author: Hubert Tong
Date: 2020-03-09T14:51:11-04:00
New Revision: f4076ad6407594c0abedb4ff61f73abecce394f7
URL:
https://github.com/llvm/llvm-project/commit/f4076ad6407594c0abedb4ff61f73abecce394f7
DIFF:
https://github.com/llvm/llvm-project/commit/f4076ad6407594c0abedb4ff61f73abecce394f7.diff
L
Author: Hubert Tong
Date: 2020-03-09T14:51:11-04:00
New Revision: dfaafbab4687676f8ad616a79d3d924267831cbd
URL:
https://github.com/llvm/llvm-project/commit/dfaafbab4687676f8ad616a79d3d924267831cbd
DIFF:
https://github.com/llvm/llvm-project/commit/dfaafbab4687676f8ad616a79d3d924267831cbd.diff
L
nction is here
virtual void f() = delete;
^
1 error generated.
>
> On Sat, 7 Mar 2020 at 08:05, Hubert Tong via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Following this commit, the error recovery for invalid cases that
>> explicitly d
Author: Hubert Tong
Date: 2020-03-10T21:31:10-04:00
New Revision: 48121a5743b684def33d158391c5424626de28e2
URL:
https://github.com/llvm/llvm-project/commit/48121a5743b684def33d158391c5424626de28e2
DIFF:
https://github.com/llvm/llvm-project/commit/48121a5743b684def33d158391c5424626de28e2.diff
L
I think this looks okay. I think Richard or Aaron might be able to provide
a more informed opinion.
-- HT
On Fri, Feb 7, 2020 at 10:06 AM John Marshall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Ping. I am a newcomer to Clang so don't know who might be appropriate
> reviewers to CC,
Author: hubert.reinterpretcast
Date: Fri Jun 30 15:43:54 2017
New Revision: 306905
URL: http://llvm.org/viewvc/llvm-project?rev=306905&view=rev
Log:
Fix PR 33189: Clang assertion on template destructor declaration
Summary:
This patch aims to fix the bug reported at
https://bugs.llvm.org/show_bug.
Author: hubert.reinterpretcast
Date: Thu Feb 9 20:46:19 2017
New Revision: 294697
URL: http://llvm.org/viewvc/llvm-project?rev=294697&view=rev
Log:
[Concepts] Class template associated constraints
Summary:
This adds associated constraints as a property of class templates.
An error is produced if
hubert.reinterpretcast added inline comments.
Comment at: include/clang/AST/Decl.h:1915
+IsConstexprSpecified = IC;
+IsConstexpr = IC;
+ }
How is the `inline` property transmitted here? Why does the
`setImplicitlyConstexpr` function need to call `setImp
Author: hubert.reinterpretcast
Date: Fri May 19 19:21:55 2017
New Revision: 303472
URL: http://llvm.org/viewvc/llvm-project?rev=303472&view=rev
Log:
Fix valid-for-expr ellipses eaten as invalid decl
Summary:
The trial parse for declarative syntax accepts an invalid pack
declaration syntax, which
hubert.reinterpretcast added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/class-template-decl.cpp:12
+
+} // end namespace nodiag
+
I should probably add some template-dependent cases.
https://reviews.llvm.org/D25674
_
hubert.reinterpretcast added a comment.
Friendly ping...
https://reviews.llvm.org/D25674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12613
@@ +12612,3 @@
+FieldTy->isBooleanType() &&
+Value.getZExtValue() > 1) {
+ if (FieldName)
rsmith wrote:
> This will assert if the specified bitfield width do
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12586
@@ -12585,3 +12585,3 @@
if (!FieldTy->isDependentType()) {
uint64_t TypeSize = Context.getTypeSize(FieldTy);
if (Value.getZExtValue() > TypeSize) {
rsmith wrote:
> I
1 - 100 of 406 matches
Mail list logo
