Author: hubert.reinterpretcast Date: Mon Jun 10 15:30:57 2019 New Revision: 362992
URL: http://llvm.org/viewvc/llvm-project?rev=362992&view=rev Log: [PlistSupport] Produce a newline to end plist output files Summary: As suggested in the review of D62949, this patch updates the plist output to have a newline at the end of the file. This makes it so that the plist output file qualifies as a POSIX text file, which increases the consumability of the generated plist file in relation to various tools. Reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty Reviewed By: NoQ, xingxue Subscribers: jsji, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D63041 Modified: cfe/trunk/lib/ARCMigrate/PlistReporter.cpp cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp Modified: cfe/trunk/lib/ARCMigrate/PlistReporter.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ARCMigrate/PlistReporter.cpp?rev=362992&r1=362991&r2=362992&view=diff ============================================================================== --- cfe/trunk/lib/ARCMigrate/PlistReporter.cpp (original) +++ cfe/trunk/lib/ARCMigrate/PlistReporter.cpp Mon Jun 10 15:30:57 2019 @@ -120,5 +120,5 @@ void arcmt::writeARCDiagsToPlist(const s o << " </array>\n"; // Finish. - o << "</dict>\n</plist>"; + o << "</dict>\n</plist>\n"; } Modified: cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp?rev=362992&r1=362991&r2=362992&view=diff ============================================================================== --- cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp (original) +++ cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp Mon Jun 10 15:30:57 2019 @@ -748,7 +748,7 @@ void PlistDiagnostics::FlushDiagnosticsI } // Finish. - o << "</dict>\n</plist>"; + o << "</dict>\n</plist>\n"; } //===----------------------------------------------------------------------===// _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
