[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson added inline comments. Comment at: clang/test/Driver/freebsd.c:217 + +// Check that the driver passes include paths to cc1 on FreeBSD. +// RUN: %clang -### %s --target=x86_64-unknown-freebsd13.1 -r 2>&1 \ MaskRay wrote: > Is this sufficient? For Linux

[PATCH] D137826: [clang] Allow comparing pointers to string literals

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12951-12954 + // ObjC's @encode() + if (isa(E->getLHS()->IgnoreParenImpCasts()) || + isa(E->getRHS()->IgnoreParenImpCasts())) return Error(E); tahonermann wrote:

[PATCH] D88994: Fix the default alignment of i1 vectors.

csstormq added inline comments. Comment at: llvm/lib/IR/DataLayout.cpp:807 // count should be enough here. -Alignment *= cast(Ty)->getElementCount().getKnownMinValue(); -Alignment = PowerOf2Ceil(Alignment); -return Align(Alignment); +return Align(PowerOf2Ceil

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476031. mhjacobson added a comment. Test for more paths; test C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 476033. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integr

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 476039. wzssyqa added a comment. Add llvm/test/CodeGen/Mips/abiflags-2008-fp64.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476042. mhjacobson added a comment. Fix a couple warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

steakhal added a comment. Herald added a project: All. I did some extensive measurements of this option. According to my results, we could confidently enable this option by default; but still, keep the flag for backward compatibility and enable the users to opt-out. The benefit of enabling this

[clang] df6f4b8 - [clang-format] Defer formatting of operator< to honor paren spacing

Author: Emilia Dreamer Date: 2022-11-17T11:38:21+02:00 New Revision: df6f4b85138f86be73d58ff3f511df5306cc4b4d URL: https://github.com/llvm/llvm-project/commit/df6f4b85138f86be73d58ff3f511df5306cc4b4d DIFF: https://github.com/llvm/llvm-project/commit/df6f4b85138f86be73d58ff3f511df5306cc4b4d.diff

[clang] 48a932e - [clang-format] Remove special case for kw_operator when aligning decls

Author: Emilia Dreamer Date: 2022-11-17T11:38:28+02:00 New Revision: 48a932e13e04a21f4422d962bf1bb4667a670e41 URL: https://github.com/llvm/llvm-project/commit/48a932e13e04a21f4422d962bf1bb4667a670e41 DIFF: https://github.com/llvm/llvm-project/commit/48a932e13e04a21f4422d962bf1bb4667a670e41.diff

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48a932e13e04: [clang-format] Remove special case for kw_operator when aligning decls (authored by rymiel). Repository: rG LLVM Github Monorepo CH

[PATCH] D137474: [clang-format] Defer formatting of operator< to honor paren spacing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf6f4b85138f: [clang-format] Defer formatting of operator< to honor paren spacing (authored by rymiel). Repository: rG LLVM Github Monorepo CHANG

[clang] ec78295 - [clang] Short-circuit evaluation in ::EvaluateAsConstantExpr

Author: Timm Bäder Date: 2022-11-17T12:01:37+01:00 New Revision: ec782951d7bd34f9c32d08bb6ec6b43d2a805832 URL: https://github.com/llvm/llvm-project/commit/ec782951d7bd34f9c32d08bb6ec6b43d2a805832 DIFF: https://github.com/llvm/llvm-project/commit/ec782951d7bd34f9c32d08bb6ec6b43d2a805832.diff LO

[PATCH] D138115: [clang] Short-circuit evaluation in ::EvaluateAsConstantExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGec782951d7bd: [clang] Short-circuit evaluation in ::EvaluateAsConstantExpr (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138115/new/

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. One remaining issue is multiple lenses for template code like template int i = 0; template int i<0>; template int i<1>; template int i<2>; template struct Foo { int foo(); // I see 3 codelenses here }; template struct Foo<0>; template

[PATCH] D138193: [Serialization] Fix crash writing non-module PCH in non-module mode including modular headers

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Ran into this when trying to turn off modules mode in clangd. Took

[PATCH] D138194: [clang][Parser][NFC] Simplify ParseParenExprOrCondition

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138194 Files: clang/inc

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:39 FileID FID = SM.getFileID(Loc.physical()); -const auto *FE = SM.getFileEntryForID(FID); +const auto *FE = getResponsibleHeader(

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Depens on D135953 Repository

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet updated this revision to Diff 476091. kadircet added a comment. - Rebase - Move to new file - Handle macros - Change from boolean output to enum for signalling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135953/new/ https://reviews.llvm.

[PATCH] D138137: [CodeGen][ARM] Fix ARMABIInfo::EmitVAAarg crash with empty record type variadic arg

yronglin updated this revision to Diff 476093. yronglin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138137/new/ https://reviews.llvm.org/D138137 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/arm-vaarg.c

[PATCH] D131295: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D131295#3933381 , @Trass3r wrote: > One remaining issue is multiple lenses for template code like > > template > int i = 0; > > template int i<0>; > template int i<1>; > template int i<2>; > > template

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3932688 , @kawashima-fj wrote: > In D138117#3931109 , @zahiraam > wrote: > >> It would probably be better to make these changes with the appropriate code >> changes you are

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

zahiraam added a comment. In D138109#3932691 , @kawashima-fj wrote: > Update a test to include the `ffast-math -ffp-model=fast` pattern. Thanks. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/ https://reviews.llvm.

Re: How can Autoconf help with the transition to stricter compilation defaults?

Hello, On Wed, 16 Nov 2022, Paul Eggert wrote: > On 2022-11-16 06:26, Michael Matz wrote: > > char foobar(void); > > int main(void) { > >return &foobar != 0; > > } > > That still has undefined behavior according to draft C23, This is correct (and also holds for the actually working variant

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

v1nh1shungry created this revision. v1nh1shungry added reviewers: njames93, ymandel. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C

[PATCH] D138194: [clang][Parser][NFC] Simplify ParseParenExprOrCondition

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor improvement. Comment at: clang/lib/Parse/ParseStmt.cpp:1275-1282 bool Parser::ParseParenExprOrCondition(StmtResult *InitStmt,

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp added a comment. @njames93 Ping again. Alternatively, could someone else review? @aaron.ballman maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 __

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM from my understanding of SARIF, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135987/new/ https://reviews.llvm.org

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Sat, Nov 12, 2022 at 7:44 PM Paul Eggert wrote: > On 2022-11-11 07:11, Aaron Ballman wrote: > > Clang doesn't require such a linker (we work with various system > linkers). > > As long as the system linkers continue to work as they have > traditionally worked, we're fine. > > > the frontend pe

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

sammccall added a comment. Thanks! sorry about continuing to drift this patch, but this looks like a great improvement. Critical comments below are: - dropping `Optional` and just use StringRef - using one consistent way to to include payloads across the API. I think `pair` is actually best ov

[PATCH] D136082: [clangd] Extend --check to time clang-tidy checks, so we can block slow ones

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Herald added a reviewer: njames93. thanks, lgtm! Comment at: clang-tools-extra/clangd/tool/Check.cpp:66 +llvm::cl::desc("Print the overhead of checks matching this gl

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749-751 + const Descriptor::MetadataSize MDSize{sizeof(InlineDescriptor)}; + Descriptor *D = + P.createDescriptor(Src, Ty, MDSize, IsConst, Src.is()); Double checking

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

foad added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3520-3521 +LexStart: + assert(!Result.needsCleaning() && "Result doesn't need cleaning"); + assert(!Result.hasPtrData() && "Result has been reset"); Messages are backwards. They should be like "R

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

erichkeane added a comment. I don't have enough knowledge about how this works to do a better review, but I have a couple of suggestions. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749 bool IsExtended) { - D

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added a comment. Looks good to me after the additional RUN line mentioned in my comment for Driver/fp-model.c is added. Thanks. Comment at: clang/test/Driver/fp-model.c:77 +// WARN12-NOT: warning: overriding '-ffp-model=strict' option with '-ffp-model=strict' [-Wove

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138204/new/ https://reviews.llvm.org/D138204 ___

[PATCH] D138207: [clang][Parse][NFC] Remove unused CommaLocs parameters

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The vectors holding the comma locs are unused (except for an assertion in two places). R

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

v1nh1shungry added a comment. @ymandel Thank you for reviewing! If this patch is okay to land, could you please help me commit it? Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138204/new/ https://reviews.llvm.org/D138204 __

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. In D138117#3933644 , @zahiraam wrote: > What I meant was that the changes about the semantic mode approx-func that > you made here https://reviews.llvm.org/D138109 , should have included the > changes that you are making in

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. Is there any update to this? Or maybe someone I should add as a reviewer? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 __

[PATCH] D137980: [ARM] Pretend atomics are always lock-free for small widths.

john.brawn added a comment. Looking at GCC it looks like there (for cortex-m0 at least) the behaviour is that loads and stores are generated inline, but more complex operations go to the atomic library calls (not the sync library calls). e.g. for int x, y; int fn() { return __atomic_loa

[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes GH48182. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138210 Files: clang/lib/Sema/

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https://reviews.llvm.org/D137043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:1241 + !HeaderInfo.hasFileBeenImported(FE) && + (FID != SM.getMainFileID() || !fileContainsImports(FID, SM))) return false; can you put a comment here saying `any h

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

doru1004 updated this revision to Diff 476130. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://reviews.llvm.org/D138159 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/AST/

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

doru1004 marked 2 inline comments as done. doru1004 added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1811 + // clause. + if (getLangOpts().OpenMP >= 52 && ClauseName.str() == "to") { +Diag(Tok, diag::err_omp_declare_target_unexpected_to_clause)

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://reviews.llvm.org/D138159 ___

[PATCH] D138207: [clang][Parse][NFC] Remove unused CommaLocs parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- it's a bit sad that we're losing some assertion coverage, but it seems like reasonable coverage to lose. Comment at: clang/include/clang/Parse/Parser.h

[clang] 0dff945 - Fix debug-info test

Author: Alex Brachet Date: 2022-11-17T16:02:54Z New Revision: 0dff945bbca9e1c00ac76eafd1af61235272b7dd URL: https://github.com/llvm/llvm-project/commit/0dff945bbca9e1c00ac76eafd1af61235272b7dd DIFF: https://github.com/llvm/llvm-project/commit/0dff945bbca9e1c00ac76eafd1af61235272b7dd.diff LOG:

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay created this revision. mdfazlay added reviewers: ABataev, mikerice, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. mdfazlay requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch gi

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. in the description, link to the change that makes this necessary and describe why (need to use an analysis in the pass) Comment at: llvm/include/llvm/IRPrinter/IRPrintin

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

doru1004 updated this revision to Diff 476143. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://reviews.llvm.org/D138159 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/AST/

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:87 +/// FIXME: Expose in public API for decision making (ranking, ignoring, etc.). +enum class Hint : uint8_t { + /// Declaration for the symbol, which is provided by all locati

[clang-tools-extra] 2675773 - [include-cleaner] add macro symbols and implicit refs to HTML report

Author: Sam McCall Date: 2022-11-17T17:29:41+01:00 New Revision: 267577325876d7e3e2b96c0a577b1b8ce076dfbb URL: https://github.com/llvm/llvm-project/commit/267577325876d7e3e2b96c0a577b1b8ce076dfbb DIFF: https://github.com/llvm/llvm-project/commit/267577325876d7e3e2b96c0a577b1b8ce076dfbb.diff LO

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG267577325876: [include-cleaner] add macro symbols and implicit refs to HTML report (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/

[clang] 858f347 - [Clang, SystemZ] Add support for option -mno-pic-data-is-text-relative.

Author: Jonas Paulsson Date: 2022-11-17T11:32:32-05:00 New Revision: 858f347c1758e2f1da5a94e3de0baae7cae2a590 URL: https://github.com/llvm/llvm-project/commit/858f347c1758e2f1da5a94e3de0baae7cae2a590 DIFF: https://github.com/llvm/llvm-project/commit/858f347c1758e2f1da5a94e3de0baae7cae2a590.diff

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

This revision was automatically updated to reflect the committed changes. Closed by commit rG858f347c1758: [Clang, SystemZ] Add support for option -mno-pic-data-is-text-relative. (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gith

[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

sgraenitz updated this revision to Diff 476150. sgraenitz marked an inline comment as done. sgraenitz added a comment. Run test with -fobjc-arc-exceptions and check cleanup pads as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137939/new/ http

[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

sgraenitz added inline comments. Comment at: clang/test/CodeGenObjCXX/arc-exceptions-seh.mm:36 +// CHECK: call +// CHECK: do_something +// CHECK: [ "funclet"(token [[CATCHPAD]]) ] rnk wrote: > Don't we need an exceptional cleanup her

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

MaskRay added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:234 + if (!ShouldAddDefaultIncludePaths(triple)) { llvm_unreachable("Include management is handled in the driver."); } drop braces around simple single statements ===

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

MaskRay added inline comments. Comment at: clang/test/Driver/freebsd.cpp:48 +// DRIVER-PASS-INCLUDES: "-cc1" {{.*}}"-resource-dir" "[[RESOURCE:[^"]+]]" +// DRIVER-PASS-INCLUDES: "-internal-isystem" "/usr/include/c++/v1" +// DRIVER-PASS-INCLUDES: "-internal-isystem" "[[RESOURCE]]/

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added inline comments. Comment at: llvm/include/llvm/IRPrinter/IRPrintingPasses.h:33 +/// +/// Note: This pass is for use with the new pass manager. Use the create...Pass +/// functions above to create passes for use with the legacy pass manager. aeuban

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

aeubanks added inline comments. Comment at: llvm/include/llvm/IRPrinter/IRPrintingPasses.h:33 +/// +/// Note: This pass is for use with the new pass manager. Use the create...Pass +/// functions above to create passes for use with the legacy pass manager. tejohns

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

mgorny resigned from this revision. mgorny added a reviewer: MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. I'm afraid this is above my skills. Maybe @MaskRay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added subscribers: kosarev, StephenFan, arichardson, tpr, emaste. Herald added a project: All. yaxunl requested review of this revision. When -fgpu-rdc is used for linking relocatable objects, device relocatable objects ar

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

yaxunl updated this revision to Diff 476157. yaxunl added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138221/new/ https://reviews.llvm.org/D138221 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp clang/test/Driver/hip-toolchain-device-only.hip clang/test/Driver

[clang-tools-extra] 6faf5d7 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2022-11-17T17:19:41Z New Revision: 6faf5d72459aee4f388dbd13eb2ddd097d2be067 URL: https://github.com/llvm/llvm-project/commit/6faf5d72459aee4f388dbd13eb2ddd097d2be067 DIFF: https://github.com/llvm/llvm-project/commit/6faf5d72459aee4f388dbd13eb2ddd097d2be067.diff LOG:

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:300 +FPP_Fast, +FPP_None + }; zahiraam wrote: > andrew.w.kaylor wrote: > > Is FPP_None somehow the same as fexcess-precision=16? If not, what does it > > mean? > Yes, ma

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 476161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/LangOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeG

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:128 InterpState State(Parent, *P, Stk, *this); - State.Current = new InterpFrame(State, Func, nullptr, {}, {}); + State.Current = new InterpFrame(State, Func, nullptr, {}); if (Interpret(State, Res

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added a comment. In D138081#3931419 , @alexander-shaposhnikov wrote: > @tejohnson - the legacy pass manager depends on the interface defined in > IRPrintingPasses.h > (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LegacyPassManag

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 476163. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseHLSL.cpp clang/lib/Parse/ParseObjc.cpp clang

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

MaskRay added a comment. > This diff splits out (from LLVMCore) IR printing passes into IRPrinter. I haven't spent too much time reading this patch. Is this to fix layering check for `-module-summary/-flto=thin with -S/-emit-llvm`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

vaibhav.y added a comment. Great! Please use the following for patch attribution: - Name: Vaibhav Yenamandra - email address: vyenaman...@bloomberg.net Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135987/new/ https://reviews.llvm.org/D135987 ___

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added a comment. In D138081#3934386 , @MaskRay wrote: >> This diff splits out (from LLVMCore) IR printing passes into IRPrinter. > > I haven't spent too much time reading this patch. Is this to fix layering > check for `-module-summary/-flto=th

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

asbirlea added a comment. Green light perf-wise. I cannot comment on whether the position is "the right" one though. I'm deferring to the other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136806/new/ https://reviews.llvm.org/D136806

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

dblaikie added a comment. @ben.boeckel >> Plus the other compilers offer controls over it; why does Clang have to be >> different? > > Which compilers/flags are you referring to? Arguments from compatibility with > GCC are relatively easy to make (though I still have more hesitance for these >

[PATCH] D138224: WIP: AST{Reader,Writer} alternative

jansvoboda11 created this revision. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138224 File

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3934445 , @asbirlea wrote: > Green light perf-wise. > I cannot comment on whether the position is "the right" one though. I'm > deferring to the other reviewers. Thank you! Repository: rG LLVM Github Monorepo

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, this LGTM. You might want to get another reviewers approval as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 __

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Also not using this at Meta, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-commit

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added projects: Flang, All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Rubber stamp. I try to find some mips folks who can verify, so maybe wait a day or so. > When we use llc or lld to compiler IR files, the features +nan2008 and > +fpxx/+fp64 are not used. T

[clang] 8adfa29 - [Pipelines] Introduce SROA after (final, run-time) loop unrolling

Author: Roman Lebedev Date: 2022-11-17T21:31:30+03:00 New Revision: 8adfa29706e5407b62a4726e2172894e0dfdc1e8 URL: https://github.com/llvm/llvm-project/commit/8adfa29706e5407b62a4726e2172894e0dfdc1e8 DIFF: https://github.com/llvm/llvm-project/commit/8adfa29706e5407b62a4726e2172894e0dfdc1e8.diff

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8adfa29706e5: [Pipelines] Introduce SROA after (final, run-time) loop unrolling (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHA

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

ABataev added a comment. 1. Add full diff context 2. Add unsuccessful tests for the modifier (parsing and sema) Comment at: clang/lib/Parse/ParseOpenMP.cpp:3811 +// Parse optional ':' +auto Modifier = getOpenMPSimpleClauseType( +Kind, Tok.isAnnotation() ? "" :

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

aaron.ballman added a comment. In D135987#3934387 , @vaibhav.y wrote: > Great! Please use the following for patch attribution: > > - Name: Vaibhav Yenamandra > - email address: vyenaman...@bloomberg.net Happy to, can you rebase the patch on the top of tr

[PATCH] D138227: [OPENMP]Initial support for severity clause

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:538-539 let allowedClauses = [ -VersionedClause +VersionedClause, +VersionedClause ]; Add a version where these clauses were introduced Repository: rG LLVM G

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476183. brettw marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-16 10:40, Jeffrey Walton wrote: This line of arguments is not persuasive. It is full of logical fallacies. ... none of which you stated. No matter how we solve the problem, it will be a hack that exploits "logical fallacies" (whatever that means). However, a reaction "You violated

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

vaibhav.y updated this revision to Diff 476186. vaibhav.y added a comment. Rebase on upstream/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135987/new/ https://reviews.llvm.org/D135987 Files: clang/include/clang/Basic/SourceLocation.h cla

[PATCH] D137980: [ARM] Pretend atomics are always lock-free for small widths.

efriedma added a comment. So gcc has two different behaviors on ARM: - On linux, prefers `__sync` calls, and generates inline code for load/store. - On baremetal, gcc chooses what sort of atomic call to generate based on how the source code is written: if the user writes `__sync`, you get `__syn

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay updated this revision to Diff 476191. mdfazlay marked 2 inline comments as done. mdfazlay added a comment. > 1. Add full diff context > 2. Add unsuccessful tests for the modifier (parsing and sema) 1. Done 2. I am not quite sure about it it. We have two new tests for ast and message. We

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5007 return false; } const FormatToken *Previous = Right.MatchingParen->Previous; owenpan wrote: > Can we simply add the above and leave the original `return` statement

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-16 10:59, Zack Weinberg wrote: I'm generally in agreement with Rich Felker's argument (inhttps://ewontfix.com/13/) that AC_CHECK_FUNC*should not* just probe for linkability of a symbol So am I. I'm not saying Autoconf should never change here, only that the change would not be tr

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 updated this revision to Diff 476194. jyu2 added a comment. Thanks Alexey for code review! Address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138227/new/ https://reviews.llvm.org/D138227 Files: clang/include/clang/AST/OpenM

  1   2   3   >