ABataev added a comment.

1. Add full diff context
2. Add unsuccessful tests for the modifier (parsing and sema)



================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:3811
+    // Parse optional <grainsize modifier> ':'
+    auto Modifier = getOpenMPSimpleClauseType(
+        Kind, Tok.isAnnotation() ? "" : PP.getSpelling(Tok), getLangOpts());
----------------
Use actual type instead of auto here


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:16812
+  case OMPC_grainsize:
+    assert(Argument.size() == 1 && ArgumentLoc.size() == 1);
+    Res = ActOnOpenMPGrainsizeClause(
----------------
Add a message here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138217/new/

https://reviews.llvm.org/D138217

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to