tejohnson added a comment. In D138081#3931419 <https://reviews.llvm.org/D138081#3931419>, @alexander-shaposhnikov wrote:
> @tejohnson - the legacy pass manager depends on the interface defined in > IRPrintingPasses.h > (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LegacyPassManager.cpp#L266) > so without splitting this would face the same issue - circular dependency > between LLVMCore (LegacyPassManager.cpp is in LLVMCore) and IRPrinter. Ah, that's unfortunate. I guess we will have to live with the file duplication for a little while then. ================ Comment at: llvm/include/llvm/IRPrinter/IRPrintingPasses.h:33 +/// +/// Note: This pass is for use with the new pass manager. Use the create...Pass +/// functions above to create passes for use with the legacy pass manager. ---------------- aeubanks wrote: > tejohnson wrote: > > aeubanks wrote: > > > obsolete (and ditto below) > > @aeubanks is the legacy pass manager support needed at all anymore? I'm not > > sure of the status there. > we still need legacy PM passes in the codegen pipeline, which for sure > includes the IR printer passes Ok that's what I though. So I guess what is obsolete is needing a comment about it being for the new PM. ================ Comment at: llvm/lib/IR/IRPrintingPasses.cpp:9 // // PrintModulePass and PrintFunctionPass implementations. // ---------------- Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138081/new/ https://reviews.llvm.org/D138081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
