[PATCH] D119319: [AArch64] Emit TBAA metadata for SVE load/store intrinsics

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:888 if (isAllActivePredicate(Pred)) { -Builder.CreateStore(VecOp, VecPtr); +auto *Store = Builder.CreateStore(VecOp, VecPtr); +Store->copyMetadata(II); -

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire created this revision. junaire added a reviewer: aaron.ballman. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a missing test, covering the different kinds of floating-point literals, like hexadecimal floats

[PATCH] D119319: [AArch64] Emit TBAA metadata for SVE load/store intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b41238ae7f9: [AArch64] Emit TBAA metadata for SVE load/store intrinsics (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D119319?vs=407060&id=407804#toc Repository: rG LLVM

[clang] 0b41238 - [AArch64] Emit TBAA metadata for SVE load/store intrinsics

Author: Sander de Smalen Date: 2022-02-11T09:00:29Z New Revision: 0b41238ae7f91bcc907a577377caa70721ffc400 URL: https://github.com/llvm/llvm-project/commit/0b41238ae7f91bcc907a577377caa70721ffc400 DIFF: https://github.com/llvm/llvm-project/commit/0b41238ae7f91bcc907a577377caa70721ffc400.diff L

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

MaskRay added a comment. Needs a test in llvm/test/Transforms/LowerTypeTests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list cfe-co

[clang] abc8736 - [analyzer] Restrict CallDescription fuzzy builtin matching

Author: Balazs Benics Date: 2022-02-11T10:45:18+01:00 New Revision: abc873694ff7cde3def6860564521e059cb542f8 URL: https://github.com/llvm/llvm-project/commit/abc873694ff7cde3def6860564521e059cb542f8 DIFF: https://github.com/llvm/llvm-project/commit/abc873694ff7cde3def6860564521e059cb542f8.diff

[PATCH] D118388: [analyzer] Restrict CallDescription fuzzy builtin matching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabc873694ff7: [analyzer] Restrict CallDescription fuzzy builtin matching (authored by steakhal). Herald added a project: clang. Herald added a subscr

[clang] a218706 - [clang-format] Add tests for spacing between ref-qualifier and `noexcept`. NFC.

Author: Marek Kurdej Date: 2022-02-11T10:50:05+01:00 New Revision: a218706cba90248be0c60bd6a8f10dbcf0270955 URL: https://github.com/llvm/llvm-project/commit/a218706cba90248be0c60bd6a8f10dbcf0270955 DIFF: https://github.com/llvm/llvm-project/commit/a218706cba90248be0c60bd6a8f10dbcf0270955.diff

[PATCH] D118388: [analyzer] Restrict CallDescription fuzzy builtin matching

steakhal added a comment. I decided to land it as-is. I tried to refactor the rest of the `isCLibraryFunction()` to reuse the new detection logic, but I run into issues by doing that. BTW I'm not sure if we should support anything besides the builtins defined in `clang/include/clang/Basic/Builti

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

steakhal added a comment. In D116155#3303622 , @balazske wrote: > @martong Ping > We do not have possibility currently to check all LLDB tests. I think we can > commit this and observe the buildbots for failure. I agree. Let's see if it works out. I don

[clang] 50f8abb - [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

Author: Sven van Haastregt Date: 2022-02-11T10:14:14Z New Revision: 50f8abb9f40a6c4974ec71e760773a711732648f URL: https://github.com/llvm/llvm-project/commit/50f8abb9f40a6c4974ec71e760773a711732648f DIFF: https://github.com/llvm/llvm-project/commit/50f8abb9f40a6c4974ec71e760773a711732648f.diff

[PATCH] D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f8abb9f40a: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D119420?vs=407432&id=407813#toc Repository: rG LLVM

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

steakhal added a comment. Well, I've just recognized that the "Build Status" of this latest diff shows that it crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 ___

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked 14 inline comments as done and an inline comment as not done. futogergely added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ObsolescentFunctionsCheck.cpp:41-42 + + // Matching the `gets` deprecated function without replacement. + auto Depr

[clang] 9ece72c - [clang] VisitCastExpr - use cast<> instead of dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-02-11T10:51:34Z New Revision: 9ece72c159720d1c771249f5a565f6ca39a31ae3 URL: https://github.com/llvm/llvm-project/commit/9ece72c159720d1c771249f5a565f6ca39a31ae3 DIFF: https://github.com/llvm/llvm-project/commit/9ece72c159720d1c771249f5a565f6ca39a31ae3.diff LOG:

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske updated this revision to Diff 407822. balazske added a comment. Fix of test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/

[clang] 326cb51 - [clang-format] Simplify conditions in spaceRequiredBetween. NFC.

Author: Marek Kurdej Date: 2022-02-11T12:01:24+01:00 New Revision: 326cb51b147a1de17ba0157c41c37243d3cbc0ff URL: https://github.com/llvm/llvm-project/commit/326cb51b147a1de17ba0157c41c37243d3cbc0ff DIFF: https://github.com/llvm/llvm-project/commit/326cb51b147a1de17ba0157c41c37243d3cbc0ff.diff

[clang] fd16eee - [clang-format] Assert default style instead of commenting. NFC.

Author: Marek Kurdej Date: 2022-02-11T12:01:25+01:00 New Revision: fd16eeea9d16150e35cadae1d77cee831b8cf510 URL: https://github.com/llvm/llvm-project/commit/fd16eeea9d16150e35cadae1d77cee831b8cf510 DIFF: https://github.com/llvm/llvm-project/commit/fd16eeea9d16150e35cadae1d77cee831b8cf510.diff

[PATCH] D91000: [clang-tidy] Add cert-msc24-msc33-c checker.

futogergely updated this revision to Diff 407819. futogergely marked an inline comment as done. futogergely retitled this revision from "[clang-tidy] Add cert-msc24-c checker." to "[clang-tidy] Add cert-msc24-msc33-c checker.". futogergely edited the summary of this revision. futogergely added a c

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov updated this revision to Diff 407823. azabaznov added a comment. Rename language mode for device side enqueue builtins; add the comment that device side enqueue builtins are not supported until OpenCL 2.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This makes hover/go-t

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

azabaznov added a comment. > There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so we > need this check to preserve the existing behavior indeed. Thanks. The other test is `SemaOpenCL/clang-builtin-version.cl`. > But it might be worth asking someone outside of the OpenCL co

[clang] 87c32be - [clang][dataflow] Include terminator statements in buildStmtToBasicBlockMap

Author: Stanislav Gatev Date: 2022-02-11T11:15:29Z New Revision: 87c32be023d293e159e699bf46c821fe931cc223 URL: https://github.com/llvm/llvm-project/commit/87c32be023d293e159e699bf46c821fe931cc223 DIFF: https://github.com/llvm/llvm-project/commit/87c32be023d293e159e699bf46c821fe931cc223.diff LO

[PATCH] D119447: [clang][dataflow] Include terminator statements in buildStmtToBasicBlockMap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87c32be023d2: [clang][dataflow] Include terminator statements in buildStmtToBasicBlockMap (authored by sgatev). Repository: rG LLVM Github Monorep

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. LGTM. For the record the implication in this patch correspond to the note under v-spec

[PATCH] D91000: [clang-tidy] Add cert-msc24-msc33-c checker.

balazske added a comment. Now it would be better to have a checker called `UnsafeFunctionsCheck` (probably in bugprone) and add the cert checkers "msc24-c" and "msc33-c" as aliases. This makes the check extendable if more (CERT rule related or not) cases for unsafe functions are added. CHANGE

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

junparser added a comment. Herald added a subscriber: pcwang-thead. @eopXD, hi, this patch make us lost +relax and -save-restore by default, would you please fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD added a comment. In D113336#3313909 , @junparser wrote: > @eopXD, hi, this patch make us lost +relax and -save-restore by default, > would you please fix it? Sure, let me look into it. Do you have an existing test case for your situation? (Or I

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

simon_tatham added a comment. Hi. This commit seems to have broken the following cmake command, on Windows (with HEAD pointing at 76cad51ba700233d6e3492eddcbb466b6adbc2eb ): cmake -DLLVM_ENABLE_PROJECTS=clang -DLLVM_EXPORT_S

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-isa features back after implication

eopXD created this revision. eopXD added reviewers: junparser, craig.topper, asb, frasercrmck. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMo

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added a comment. In D118605#3313859 , @azabaznov wrote: >> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >> we need this check to preserve the existing behavior indeed. > > Thanks. The other test is `SemaOpenCL/clan

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/ https://reviews.llvm.org/D118605 _

[clang] bee4bd7 - [OpenCL] Add support of language builtins for OpenCL C 3.0

Author: Anton Zabaznov Date: 2022-02-11T15:53:44+03:00 New Revision: bee4bd70f76952b2c6296feb46a087b497322376 URL: https://github.com/llvm/llvm-project/commit/bee4bd70f76952b2c6296feb46a087b497322376 DIFF: https://github.com/llvm/llvm-project/commit/bee4bd70f76952b2c6296feb46a087b497322376.diff

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

This revision was automatically updated to reflect the committed changes. Closed by commit rGbee4bd70f769: [OpenCL] Add support of language builtins for OpenCL C 3.0 (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118605/new/

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd224be3b999a: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics. (authored by khchen). Changed prior to commit: https://rev

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

Arfrever added inline comments. Comment at: llvm/docs/GettingStarted.rst:1225 +* -DLLVM_ENABLE_RUNTIMES + Set this equal to the runtimes you wish to compile (e.g. libcxx, libcxxabi, etc.) One space is missing before `*`, so currently this part of this page i

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

eopXD updated this revision to Diff 407852. eopXD added a comment. Add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119541/new/ https://reviews.llvm.org/D119541 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-defaul

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:557 + +let RegInfos = RegInfoByHwMode<[RV64], [RegInfo<64, 64, 64>]> in +def GPRPF64 : RegisterClass<"RISCV"

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

azabaznov updated this revision to Diff 407856. azabaznov added a comment. Use existing diagnostics; add the comment that device can support extension but not the feature. Will follow up if we need explicit mention in the language spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added a comment. In D119525#3313554 , @tbaeder wrote: > This is a pretty big gotcha at best and I feel like `getArraySize()` should > return `None` in that case instead... thoughts? I think it is a gotcha -- some places protect against a n

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

svenvh added a comment. In D118605#3313990 , @Anastasia wrote: > In D118605#3313859 , @azabaznov > wrote: > >>> There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so >>> we need this check t

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-literal-range.c:25 + +double d5 = 0x0.42p+4200; // expected-warning {{magnitude of floating-point constant too large for type 'double'; maximum is 1.7976931348623157E+308}} I think we should p

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske updated this revision to Diff 407860. balazske added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTes

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

ldionne marked an inline comment as done. ldionne added inline comments. Comment at: llvm/docs/GettingStarted.rst:1225 +* -DLLVM_ENABLE_RUNTIMES + Set this equal to the runtimes you wish to compile (e.g. libcxx, libcxxabi, etc.) Arfrever wrote: > One space i

[clang] 23f2785 - [clang-format] Avoid multiple calls to FormatToken::getNextNonComment(). NFC.

Author: Marek Kurdej Date: 2022-02-11T15:20:11+01:00 New Revision: 23f27850b1e00e66ba19fc844ad8f2bd70268536 URL: https://github.com/llvm/llvm-project/commit/23f27850b1e00e66ba19fc844ad8f2bd70268536 DIFF: https://github.com/llvm/llvm-project/commit/23f27850b1e00e66ba19fc844ad8f2bd70268536.diff

[clang] 0104f5e - [clang-format] Mark FormatToken::getNextNonComment() nodiscard. NFC.

Author: Marek Kurdej Date: 2022-02-11T15:20:11+01:00 New Revision: 0104f5efede22890c356810f992162a84cd615dd URL: https://github.com/llvm/llvm-project/commit/0104f5efede22890c356810f992162a84cd615dd DIFF: https://github.com/llvm/llvm-project/commit/0104f5efede22890c356810f992162a84cd615dd.diff

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

aaron.ballman added a reviewer: tahonermann. aaron.ballman added a comment. Can you also add a release note for the new feature, and update the `clang/www/c_status.html` page as well? Comment at: clang/test/Lexer/utf8-char-literal.cpp:23 +char f = u8'ab';// expecte

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein updated this revision to Diff 407862. hokein marked 10 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. - rebase, rescope the patch to LRTable - refine the Action class interfaces, and nameing; - use a more compact Index, reduce LRTable from 660KB => 335KB

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRTable.h:84 + +Kind K = Kind::Error; +// Value sammccall wrote: > This action struct can be squeezed to 16 bits. > > Kind only needs 3 bits (I suspect it can be 2: Error

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a reviewer: kadircet. probinson added a subscriber: kadircet. probinson added a comment. Ping; +@kadircet CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.llvm.org/D119040 ___ cfe-commits mailing list

[clang] 8fee667 - [pseudo] NFC, fix some typos.

Author: Haojian Wu Date: 2022-02-11T15:35:11+01:00 New Revision: 8fee667d31f6af9a8a6b44b120164fff4f65d198 URL: https://github.com/llvm/llvm-project/commit/8fee667d31f6af9a8a6b44b120164fff4f65d198 DIFF: https://github.com/llvm/llvm-project/commit/8fee667d31f6af9a8a6b44b120164fff4f65d198.diff LO

[PATCH] D112916: Confusable identifiers detection

aaron.ballman added reviewers: tahonermann, cor3ntin. aaron.ballman added a comment. Personally, I'm uncomfortable with this check because it's not really covering homoglyphs in general, it's covering homoglyphs outside of the usual Latin character set. For example, there's no attempt to catch o

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118999/new/ https://reviews.llvm.org/D118999 _

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

Bhramar.vatsa added a comment. Sorry, but I can only add a bit more confusion: https://godbolt.org/z/dzYhhxbz4 There are two cases, only differing in terms of user-defined constructor. Gcc and clang differs in the two cases. Gcc at least packs the second case (without user defined constructor),

[clang] bfb1a33 - [OpenCL] Adjust diagnostic for subgroup support.

Author: Anton Zabaznov Date: 2022-02-11T17:40:24+03:00 New Revision: bfb1a33bec7c88170b0809b8a7c9cb860e7cc19b URL: https://github.com/llvm/llvm-project/commit/bfb1a33bec7c88170b0809b8a7c9cb860e7cc19b DIFF: https://github.com/llvm/llvm-project/commit/bfb1a33bec7c88170b0809b8a7c9cb860e7cc19b.diff

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb1a33bec7c: [OpenCL] Adjust diagnostic for subgroup support. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118999/new/ https://re

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407868. tianshilei1992 added a comment. fix errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema

[clang] b2936ca - [clang] inheritance fix for nomerge attribute

Author: Dávid Bolvanský Date: 2022-02-11T15:51:08+01:00 New Revision: b2936caf77e00fdb97814960eb1355c2a36c1e70 URL: https://github.com/llvm/llvm-project/commit/b2936caf77e00fdb97814960eb1355c2a36c1e70 DIFF: https://github.com/llvm/llvm-project/commit/b2936caf77e00fdb97814960eb1355c2a36c1e70.dif

[PATCH] D119451: [clang] inheritance fix for nomerge attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2936caf77e0: [clang] inheritance fix for nomerge attribute (authored by xbolva00). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11790-11797 +if (IsCompareCapture) { + // TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore + // code gen. + unsigned DiagID = Diags.getCustomDiagID( + Diagno

[PATCH] D112916: Confusable identifiers detection

cor3ntin added a comment. @aaron.ballman Thanks for the ping. One one hand, I agree with you, on the other hand, this tries to stick to TR39, and I think we should stick with that. It might be worth checking with the Unicode consortium what they think of i/l as confusable. I think this is a ra

[clang] f162036 - [clang] RewriteModernObjC::SynthBlockInitExpr - remove block nullptr check

Author: Simon Pilgrim Date: 2022-02-11T15:09:44Z New Revision: f162036fcd065d34a7f0e2c9279bc79bf7db0f14 URL: https://github.com/llvm/llvm-project/commit/f162036fcd065d34a7f0e2c9279bc79bf7db0f14 DIFF: https://github.com/llvm/llvm-project/commit/f162036fcd065d34a7f0e2c9279bc79bf7db0f14.diff LOG:

[clang] 5fb1807 - [clang][sema] ActOnExplicitInstantiation - remove Prev nullptr check

Author: Simon Pilgrim Date: 2022-02-11T15:09:44Z New Revision: 5fb180704c17dc66dfc7f052abe47524fdf8811f URL: https://github.com/llvm/llvm-project/commit/5fb180704c17dc66dfc7f052abe47524fdf8811f DIFF: https://github.com/llvm/llvm-project/commit/5fb180704c17dc66dfc7f052abe47524fdf8811f.diff LOG:

[clang] 1e64590 - [clang][sema] - remove CodeCompleter nullptr checks

Author: Simon Pilgrim Date: 2022-02-11T15:09:44Z New Revision: 1e6459004177c8f5830e1ea5a5a62820fa6a333f URL: https://github.com/llvm/llvm-project/commit/1e6459004177c8f5830e1ea5a5a62820fa6a333f DIFF: https://github.com/llvm/llvm-project/commit/1e6459004177c8f5830e1ea5a5a62820fa6a333f.diff LOG:

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Attributor use looks good. @arsenm will need to look at the rest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119216/new/ https://review

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11790-11797 +if (IsCompareCapture) { + // TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore + // code gen. + un

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. Add ast print with serialization/deserialization tests. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { SmallVecto

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

appcs added a comment. Herald added a subscriber: dang. Hello, Will this feature be committed? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407885. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/Sema/TreeTransform.h clang/te

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2135 std::string TypeS; - if (Optional Size = E->getArraySize()) { + if (E->isArray()) { llvm::raw_string_ostream s(TypeS); I changed this just for clarity, not doing it did not ca

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

avogelsgesang added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:508 +int ParamIndex = paramIndex(*FTD, *Auto.getDecl()); +if (ParamIndex < 0) + return true; out of curiosity: when would this happen? Repository: rG LLVM Github Mo

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added a comment. In D117929#3299751 , @dberris wrote: > In D117929#3276843 , @ashwin98 > wrote: > >> Fixed another lint issue, they should all be done for now hopefully. >> >> @dberris Sorry, I'm a littl

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:508 +int ParamIndex = paramIndex(*FTD, *Auto.getDecl()); +if (ParamIndex < 0) + return true; avogelsgesang wrote: > out of curiosity: when would this happen? I think it pro

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall updated this revision to Diff 407891. sammccall added a comment. Assert on presumed-impossible case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119537/new/ https://reviews.llvm.org/D119537 Files: clang-tools-extra/clangd/AST.cpp c

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Can you also add a release note for the change? Comment at: clang/include/clang/AST/ExprCXX.h:2271 + +if (auto Result = +

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

avogelsgesang added a comment. code looks good to me, but I don't know the code base well enough for a "LGTM" Thanks for implementing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119537/new/ https://reviews.llvm.org/D119537 ___

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda updated this revision to Diff 407904. jchlanda added a comment. PTX/sm version tidy up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118977/new/ https://reviews.llvm.org/D118977 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clan

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

avogelsgesang added a comment. Should this be added to the Release Notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119537/new/ https://reviews.llvm.org/D119537 ___ cfe-commits mailing list cfe-commi

[clang] d8f99bb - [AMDGPU] replace hostcall module flag with function attribute

Author: Sameer Sahasrabuddhe Date: 2022-02-11T22:51:56+05:30 New Revision: d8f99bb6e0641474b6bc1728295b40a8fa279f9a URL: https://github.com/llvm/llvm-project/commit/d8f99bb6e0641474b6bc1728295b40a8fa279f9a DIFF: https://github.com/llvm/llvm-project/commit/d8f99bb6e0641474b6bc1728295b40a8fa279f9

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8f99bb6e064: [AMDGPU] replace hostcall module flag with function attribute (authored by sameerds). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407912. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/Sema/TreeTransform.h clang/te

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2135 std::string TypeS; - if (Optional Size = E->getArraySize()) { + if (E->isArray()) { llvm::raw_string_ostream s(TypeS); aaron.ballman

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

simon_tatham added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:53 # Support plugins. if(CLANG_PLUGIN_SUPPORT) export_executable_symbols_for_plugins(clang) I think we've managed to fix our build by changing this line so that it tests ```if(

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

sammccall added a comment. This is really nice, mostly nits. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:177 }; +void initTerminals(std::vector &Terminals); why is this exposed/required rather than being initialized by the GrammarTable c

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall added a comment. In D119537#3314509 , @avogelsgesang wrote: > Should this be added to the Release Notes? We usually go back over the git log around the time of a release cut. It started as laziness but I think it's a good system: less work wri

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

sammccall added a comment. And thanks for taking a look, and filing bugs - sorry we can't get to everything :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119537/new/ https://reviews.llvm.org/D119537 ___

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog created this revision. Herald added a subscriber: carlosgalvezp. kesyog requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. D90110 modified the behavior of `run-clang-tidy` to always pass th

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3313443 , @void wrote: > In D110869#3312360 , @RKSimon wrote: > >> @void This buildbot appears to be still broken due to this change: >> https://lab.llvm.org/buildbot/#/builders/1

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

eugenis added a comment. You might want to update Bitcode writer/reader as well, otherwise nosanitize will be lost after a trip through .bc/.ii. Comment at: compiler-rt/test/hwasan/TestCases/global-with-reduction.c:50 + f()[atoi(argv[1])] = 1; + f()[atoi(argv[1])] = 1; + re

[PATCH] D119562: Provide fine control of color in run-clang-tidy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') Shouldn't it be just `else:`? Repository: rG LLVM G

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') Eugene.Zelenko wrote: > Shouldn't it be just `else:`? There are

[PATCH] D119562: Provide fine control of color in run-clang-tidy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') kesyog wrote: > Eugene.Zelenko wrote: > > Shouldn't it

[clang] 87dd3d3 - [clang][OpaquePtr] Remove call to getPointerElementType() in CodeGenModule::GetAddrOfGlobalTemporary()

Author: Arthur Eubanks Date: 2022-02-11T10:39:49-08:00 New Revision: 87dd3d350c4ce0115b2cdf91d85ddd05ae2661aa URL: https://github.com/llvm/llvm-project/commit/87dd3d350c4ce0115b2cdf91d85ddd05ae2661aa DIFF: https://github.com/llvm/llvm-project/commit/87dd3d350c4ce0115b2cdf91d85ddd05ae2661aa.diff

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog updated this revision to Diff 407950. kesyog added a comment. Refactor tri-state logic for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/ https://reviews.llvm.org/D119562 Files: clang-tools-extra/clang-tidy/tool/run

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tonic added a comment. Unfortunately our legal counsel has advised that this patch should not be included into LLVM because the exact patent burden is not disclosed. Therefore, we can not accept this patch into LLVM. I am very sorry to have to report this disappointing news. CHANGES SINCE LAS

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog marked an inline comment as done. kesyog added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:96 +start.append('--use-color') + elif use_color is not None: +start.append('--use-color=false') Eugene.Zelenko wrote:

[clang] b3b2538 - [lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:

Author: Peter Kasting Date: 2022-02-11T13:55:18-05:00 New Revision: b3b2538df100ec7f6587b0ee70819a3c8ee2c27e URL: https://github.com/llvm/llvm-project/commit/b3b2538df100ec7f6587b0ee70819a3c8ee2c27e DIFF: https://github.com/llvm/llvm-project/commit/b3b2538df100ec7f6587b0ee70819a3c8ee2c27e.diff

[PATCH] D118070: Make lld-link work in a non-MSVC shell

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3b2538df100: [lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot: (authored by pkasting, committed by thakis). Changed prior to comm

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. I went ahead and landed this for now. It's easy to move the 3 new files to their own library later on if we decide it's something we want to do. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

ivanmurashko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:416 + auto CallMoveMatcherLambda = lambdaExpr( + forEachLambdaCapture(lambdaCapture(capturesVar(varDecl( sammccall wrote: > sammccall wrote: > > do

  1   2   >