steakhal added a comment. I decided to land it as-is. I tried to refactor the rest of the `isCLibraryFunction()` to reuse the new detection logic, but I run into issues by doing that. BTW I'm not sure if we should support anything besides the builtins defined in `clang/include/clang/Basic/Builtins*.def` files. Given that the parser should recognize these and use the appropriate Builtin for the FunctionDecl, `getBuiltinID()` should return the given `ID`. Anyway. I decided to take it slowly and fix only the issue causing the crashes.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118388/new/ https://reviews.llvm.org/D118388 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits