[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 303345. LuoYuanke added a comment. Fix lit test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e312e004197: [X86] use macros to split GFNI intrinsics into different kinds (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES

[clang] 5e312e0 - [X86] use macros to split GFNI intrinsics into different kinds

Author: Freddy Ye Date: 2020-11-06T16:03:38+08:00 New Revision: 5e312e0041972668f1bd67ff9ed0f16a594795a3 URL: https://github.com/llvm/llvm-project/commit/5e312e0041972668f1bd67ff9ed0f16a594795a3 DIFF: https://github.com/llvm/llvm-project/commit/5e312e0041972668f1bd67ff9ed0f16a594795a3.diff LOG

[PATCH] D90908: [clang-format] do not break before { in JS comments

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir requested review of this revision. In JavaScript some @tags can be followed by `{`, and machinery that parses these comments will fail to understand the comment if followed by a line bre

[PATCH] D90908: [clang-format] do not break before { in JS comments

krasimir updated this revision to Diff 303354. krasimir added a comment. update test case range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90908/new/ https://reviews.llvm.org/D90908 Files: clang/unittests/Format/FormatTestJS.cpp Index: clan

[PATCH] D90908: [clang-format] do not break before { in JS comments

krasimir updated this revision to Diff 303355. krasimir added a comment. collect commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90908/new/ https://reviews.llvm.org/D90908 Files: clang/lib/Format/BreakableToken.cpp clang/unittests/Format

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 303356. balazske added a comment. Small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

foad added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1580 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrCold, IntrNoMem, IntrHasSideEffects] The intrinsic def needs a comment.

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

sammccall accepted this revision. sammccall added a comment. Still LG Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812 +EmptyDefaults.User = llvm::sys::Process::GetEnv("USER"); +if (!EmptyDefaults.User) + EmptyDefaults.User = llvm::sys::Process::GetEnv(

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added a comment. > I guess targets like SPIR will be supporting all features by default? It sounds confusing for me: can you please elaborate about why does SPIR-V target should support all features/extension by default? If we are compiling OpenCL C 3.0 with optional functionality we

[PATCH] D90908: [clang-format] do not break before { in JS comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbcbd357d1d: [clang-format] do not break before { in JS comments (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2dbcbd3 - [clang-format] do not break before { in JS comments

Author: Krasimir Georgiev Date: 2020-11-06T10:34:10+01:00 New Revision: 2dbcbd357d1da1adf9c512d150e68424faa46d75 URL: https://github.com/llvm/llvm-project/commit/2dbcbd357d1da1adf9c512d150e68424faa46d75 DIFF: https://github.com/llvm/llvm-project/commit/2dbcbd357d1da1adf9c512d150e68424faa46d75.d

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just some simplifications and doc nits left, then please go ahead and land Comment at: clang-tools-extra/clangd/Config.h:74 + + // Configures what clang-tidy

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. This test was added in 7f38812d5b7e0fd5145e44d5ae831a67d782dca6

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

DavidSpickett added a reviewer: kpn. DavidSpickett added a comment. In case this looks like a spammy change, this is for http://llvm.1065342.n5.nabble.com/llvm-dev-RFC-FileCheck-dis-allowing-unused-prefixes-td142255.html AFAICT there is no common IR to check for in this test, unlike the others.

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 303397. kbobyrev added a comment. Continue implementation, integrate more tests from clang-rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/UncheckedReturnValueChecker.cpp:41 +BugReporter &BR) const { +auto FoundCall = callExpr().bind("call"); +auto CallInCompound = compoundStmt(forEach(FoundCall));

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

erik2020 created this revision. erik2020 added a reviewer: ldrumm. erik2020 added a project: clang. Herald added subscribers: cfe-commits, dexonsmith, Anastasia, yaxunl. erik2020 requested review of this revision. Calling any of the `OpenCLOptions::is*()` functions (except `isKnown()`) with an un

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen added a comment. Hi @david-arm I just found that two uses of `llvm.loop.vectorize.width` are not yet updated. - WarnMissedTransforms.cpp in `warnAboutLeftoverTransformations`. - LoopUtils.cpp in `llvm::hasVectorizeTransformation`. The cases seem quite trivial to fix up, can you includ

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2376710 , @dblaikie wrote: > How's this compare to the similar checks for variable templates? Is there > some code/checking we could share here? The code of checks for variable templates is just before the additional c

[PATCH] D90891: [clang] ns_error_domain attribute also supports CFString typed variables

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90891/new/ https://reviews.llvm.org/D90891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D90763: Traverse-ignore explicit template instantiations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a tiny commenting request. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:506 +if (const auto *CTSD = Node.get()) { + auto SK = C

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} steveire wrote: > aaron.ballman wrot

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just style nits. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:266 + switch (DC->getDeclKind()) { + // The enclosing DeclContext may not be the enc

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

sammccall added a comment. Thanks! This makes sense to me, I assumed at first that the expr could be something complicated that we'd have to const-evaluate, thought clearly this already happens (and we do assume it's a ConstantExpr). Comment at: clang-tools-extra/clangd/refac

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:276 // extern "C" int atexit(void (*f)(void)); - assert(cast(dtorStub)->getFunctionType() == - llvm::FunctionType::get(CGM.VoidTy, false) && + llvm::PointerType *Expected = + ll

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

kpn accepted this revision. kpn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90921/new/ https://reviews.llvm.org/D90921 ___ cfe-com

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88913/new/ https://reviews.llvm.org/D88913 ___ cfe-commits mailing list cfe-comm

[clang] aecd52b - [Clang][AArch64] Remove unused prefix in constrained rounding test

Author: David Spickett Date: 2020-11-06T14:13:46Z New Revision: aecd52b97bb457aaecb0bcb658e6ea684e869de9 URL: https://github.com/llvm/llvm-project/commit/aecd52b97bb457aaecb0bcb658e6ea684e869de9 DIFF: https://github.com/llvm/llvm-project/commit/aecd52b97bb457aaecb0bcb658e6ea684e869de9.diff LOG

[PATCH] D90921: [Clang][AArch64] Remove unused prefix in constrained rounding test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaecd52b97bb4: [Clang][AArch64] Remove unused prefix in constrained rounding test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet updated this revision to Diff 303442. kadircet added a comment. The index has the following query semantics: - Lookup: it only queries the associated index. This is to not regress latency for operations like Hover and Go-To. - FuzzyFind only queries the associated index when RestrictF

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon created this revision. segoon added a reviewer: alexfh. Herald added subscribers: cfe-commits, lxfind, modocache, xazax.hun, mgorny. Herald added a project: clang. segoon requested review of this revision. Checks for some thread-unsafe functions against a black list of known-to-be-unsafe f

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske updated this revision to Diff 303444. balazske added a comment. Small fixes in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90691/new/ https://reviews.llvm.org/D90691 Files: clang/docs/analyzer/checkers.rst clang/include/clang/

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/UncheckedReturnValueChecker.cpp:41 +BugReporter &BR) const { +auto FoundCall = callExpr().bind("call"); +auto CallInCompound =

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-mt-unsafe.cpp:3-4 + +#include +#include + Tests should be hermetic, they can not use headers from system Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

sammccall added a comment. LG (comment nits) thanks! (Meta-point: not sure how useful splitting this patch out from the compile step is...) Comment at: clang-tools-extra/clangd/ConfigFragment.h:165 llvm::Optional> Background; +/// Configuration information for an exte

[PATCH] D90763: Traverse-ignore explicit template instantiations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7efe07a12b69: Traverse-ignore explicit template instantiations (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D9076

[clang] 7efe07a - Traverse-ignore explicit template instantiations

Author: Stephen Kelly Date: 2020-11-06T15:25:59Z New Revision: 7efe07a12b6967bc358678adf75dffd238a00250 URL: https://github.com/llvm/llvm-project/commit/7efe07a12b6967bc358678adf75dffd238a00250 DIFF: https://github.com/llvm/llvm-project/commit/7efe07a12b6967bc358678adf75dffd238a00250.diff LOG:

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. In D68997#2377641 , @stella.stamenova wrote: > This change broke the windows lldb bot: > > http://lab.llvm.org:8011/#/builders/83/builds/570 > > Can you please fix this or revert? Looking at this now. Repository: rG LLVM Githu

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

vhscampos added a comment. @Tyker This is causing another build failure in another example: [2858/4034] Building CXX object tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o FAILED: tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o CCACHE_CPP2=

[clang] aa0dc1c - [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

Author: Balazs Benics Date: 2020-11-06T16:51:34+01:00 New Revision: aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe URL: https://github.com/llvm/llvm-project/commit/aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe DIFF: https://github.com/llvm/llvm-project/commit/aa0dc1c3b8628bed8c8b91a75258d13eefa88dfe.diff

[PATCH] D90754: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa0dc1c3b862: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup (authored by steakhal). Repository: rG LLVM Github Monorepo CH

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 303462. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

steakhal added a comment. In D52957#2377914 , @NoQ wrote: > Everything looks good to me here. The new-expression `new int;` has 1 > implicit argument (allocation size passed to the implementation of operator > new, the value is probably 4) and 0 placemen

[PATCH] D90886: [AMDGPU] Simplify amdgpu-macros.cl test. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fcdfc4398bd: [AMDGPU] Simplify amdgpu-macros.cl test. NFC. (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D90949: [clang-format] avoid introducing multiline comments

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir requested review of this revision. In C++ with -Werror=comment, multiline comments are not allowed. clang-format could accidentally introduce multiline comments when reflowing. This adap

[PATCH] D90767: Add new matchers for dependent names in templates

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} aaron.ballman wrote: > steveire wrote: >

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:254 +// native path. +if (!External.File && !External.Server) { + diag(Error, "At least one of File or Server must be specified.", My math friends would call this

[PATCH] D87981: [X86] AMX programming model prototype.

akashk4 requested changes to this revision. akashk4 added a comment. This revision now requires changes to proceed. It would be great if TILE_RELEASE is supported in the backend, so the scope of transaction is known and the configurations are at least stored to memory properly. ==

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90434/new/ https://reviews.llvm.org/D90434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. In D89869#2378235 , @azabaznov wrote: >> I guess targets like SPIR will be supporting all features by default? > > It sounds confusing for me: can you please elaborate about why does SPIR-V > target should support all features/e

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:110 +OPENCLFEAT_INTERNAL(__opencl_c_generic_address_space, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_work_group_collective_functions, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_atomic_order

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

NoQ added a comment. You cannot have an argument expression because there's no argument expression anywhere in the AST. There's an argument, but it's not computed as a value of any syntactic expression. If there was no argument, `getArgExpr(0)` would have crashed; but it returns a `nullptr` whi

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

Anastasia added a comment. Ok, it would still segfault but perhaps it is acceptable as this is an internal frontend only option for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928

[PATCH] D90949: [clang-format] avoid introducing multiline comments

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. One concern about looping, otherwise just style nits. Comment at: clang/lib/Format/BreakableToken.cpp:104 static const auto kNumberedListRegexp = llvm::Regex("^[1-9]

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc updated this revision to Diff 303477. mibintc added a comment. Fixed test case according to @dblaikie 's suggestion and input, thanks a lot David, the test case is certainly a lot easier to read and understand now. Anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D90747: [clangd] Mark AsyncTaskRunner::runAsync as const

sammccall added a comment. AsyncTaskRunner is definitely threadsafe, but const doesn't exactly mean threadsafe... This might be OK or maybe we should put `mutable` at the callsite - can you show the real example? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

fpetrogalli created this revision. fpetrogalli added reviewers: peterwaller-arm, paulwalker-arm, efriedma, c-rhodes. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli requested review of this revisi

[PATCH] D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set

sammccall added a comment. I'm not sure we should do this - it complicates the model substantially (I don't think I could explain it to a user), and it still leaves surprising cases. I'm not sure config is the place for a lot of magic do-what-I-mean behavior - it's the place where the user over

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. Testing this out: `--target=arm64-apple-macos` now does the right thing, but `-march arm64` sets the target triple to iOS (and hence doesn't pass the a12 cpu either). That's different from what Xcode clang does. Could you upstream whatever causes that difference too? R

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. (If `-mmacosx-version-min` is passed too, open-source clang does the right thing, but for quick command-line testing it'd be nice if both clangs behaved consistently.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303486. pratlucas added a comment. Updating default extensions in target parser to match tablegen features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files: c

[PATCH] D90957: Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Qualify definitions with `clang::` rather than opening/closing a namespace. https://reviews.llvm.org/D90957 File

[PATCH] D90956: [clang][SVE] Additional macros implied by `-msve-vector-bits=`.

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Simple and straightforward, with documentation! :) LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90956/new/ https://reviews.l

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM Comment at: llvm/unittests/Support/TargetParserTest.cpp:10-11 #include "llvm/Support/TargetParser.h" #include "llvm/ADT/STLExtras.h" +#include "llvm/Support/

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 303495. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/Diagnost

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 303499. segoon added a comment. don't include any system headers in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-ti

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon marked an inline comment as done. segoon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-mt-unsafe.cpp:3-4 + +#include +#include + lebedev.ri wrote: > Tests should be hermetic, they can not use headers from system fixed

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie accepted this revision. dblaikie added a comment. Generally looks good, thanks! The inline comment trying to understand the `4095 - 4088 == 7` math I think should be answered (possibly in the form of the test/CHECK rephrasing I mentioned to clarify what the extra 7 characters are, and

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 updated this revision to Diff 303502. njames93 added a comment. Addressed comments. Now using a MapVector to collect all uncovered cases in prepare, then just loop over that in apply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90555/new

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:117 - // We trigger if there are fewer cases than enum values (and no case covers - // multiple values). This guarantees we'll ha

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Config.h:78 +std::string Checks; +std::vector> CheckOptions; + } ClangTidy; sammccall wrote: > I think this should be a StringMap > > It makes sense to use a vector-of-pairs in ConfigF

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

njames93 added a comment. It appears to not check for signs that the code is running in a multi threaded manner, This will result in many false positives in code that is known to be single threaded. Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:19 + +namespa

[PATCH] D90963: Allow searching for prebuilt implicit modules.

arames created this revision. arames added a reviewer: stella.stamenova. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. arames requested review of this revision. This reverts commit c67656b994c87224e0b33e2c4b09093986a5cfa6

[clang-tools-extra] 062b5c5 - [clangd] Set the User option for clang-tidy to mimick its behaviour

Author: Nathan James Date: 2020-11-06T19:58:21Z New Revision: 062b5c598f21c1591b10362219e3c89e934367b0 URL: https://github.com/llvm/llvm-project/commit/062b5c598f21c1591b10362219e3c89e934367b0 DIFF: https://github.com/llvm/llvm-project/commit/062b5c598f21c1591b10362219e3c89e934367b0.diff LOG:

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rG062b5c598f21: [clangd] Set the User option for clang-tidy to mimick its behaviour (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D90552?vs=302871&id=303519#toc Repository:

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon marked an inline comment as done. segoon added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:33 `abseil-upgrade-duration-conversions `_, "Yes" - `altera-struct-pack-align `_, + `altera-struct-pack-align `_, "Yes" `android-cloex

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:33 `abseil-upgrade-duration-conversions `_, "Yes" - `altera-struct-pack-align `_, + `altera-struct-pack-align `_, "Yes" `android-cloexec-accept `_, "Yes" se

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc added a comment. you're right about the regex syntax. i think the 4088 is over the max repetition count and there's also a problem with balanced. not sure what i did wrong here. if you have a chance to look at this otherwise i'll toil over the weekend, i'm off for the day--cheers. here

[PATCH] D90221: Include more attribute details when dumping AST in JSON

aaron.ballman added a comment. In D90221#2374344 , @aronsky wrote: >> It seems surprising to me that you'd have to add those declarations; I think >> that's a layering violation. There's something somewhat strange going on >> here that I think is related

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

nickdesaulniers added a comment. In D90180#2375878 , @aaron.ballman wrote: > In D90180#2374839 , @nickdesaulniers > wrote: > >> In D90180#2357247 , @aaron.ballman >> wrote

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added a comment. In D90944#2379688 , @njames93 wrote: > It appears to not check for signs that the code is running in a multi > threaded manner, This will result in many false positives in code that is > known to be single threaded. I'm not sure

[PATCH] D90767: Add new matchers for dependent names in templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d6e1251d79d: Add new matchers for dependent names in templates (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D907

[clang] 0d6e125 - Add new matchers for dependent names in templates

Author: Stephen Kelly Date: 2020-11-06T21:03:20Z New Revision: 0d6e1251d79d07a03d8cf528e3537d41d4285680 URL: https://github.com/llvm/llvm-project/commit/0d6e1251d79d07a03d8cf528e3537d41d4285680 DIFF: https://github.com/llvm/llvm-project/commit/0d6e1251d79d07a03d8cf528e3537d41d4285680.diff LOG:

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 303532. segoon added a comment. - use static instead of namespace {} - don't use SourceRange() - revert unrelated changes to .rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/cla

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

Hi Rchard, Some of our code started triggering the warning you added in this code, but I'm not sure if the warning is actually valid or not in this case: https://godbolt.org/z/9fxs3K namespace geo { template class optional { optional() { } ~optional(); }; } template geo::optional::~optiona

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

thakis added a comment. Very belated update: We've been running with this on our clang/tot bots for a few weeks now and turned this on (or, more accurately stopped turning it off) for "normal" builds today. All tests pass and so far everything's happy. Repository: rG LLVM Github Monorepo CH

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

bsaleil updated this revision to Diff 303540. bsaleil added a comment. Fix unaligned load/store select Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 Files: clang/include/clang/Basic/BuiltinsPPC.def cl

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2379892 , @thakis wrote: > Very belated update: We've been running with this on our clang/tot bots for a > few weeks now and turned this on (or, more accurately stopped turning it off) > for "normal" builds today. All tes

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ not in share/clang/

Flow created this revision. Flow added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Flow requested review of this revision. The run-clang-tidy.py helper script is supposed to be used by the user, hence it should be placed in

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Config.h:78 +std::string Checks; +std::vector> CheckOptions; + } ClangTidy; njames93 wrote: > sammccall wrote: > > I think this should be a StringMap > > > > It makes sense to use a v

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

This revision was automatically updated to reflect the committed changes. Closed by commit rG93b99728b167: [AArch64] Add pipeline model for HiSilicon's TSV110 (authored by Elvina). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89972/new/ https://rev

[libunwind] c1887e3 - Revert "Allow running back-deployment testing against libc++abi"

Author: Louis Dionne Date: 2020-11-06T17:26:42-05:00 New Revision: c1887e3f15aeac7037b88b066b33d142c6bb1321 URL: https://github.com/llvm/llvm-project/commit/c1887e3f15aeac7037b88b066b33d142c6bb1321 DIFF: https://github.com/llvm/llvm-project/commit/c1887e3f15aeac7037b88b066b33d142c6bb1321.diff

[PATCH] D90975: [clangd] Don't run clang-tidy AST traversal if there are no checks.

sammccall created this revision. sammccall added a reviewer: njames93. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. While here, clean up ParsedAST:

[clang] c9ca3a3 - [AArch64] Add driver tests for HiSilicon's TSV110

Author: Elvina Yakubova Date: 2020-11-07T01:51:37+03:00 New Revision: c9ca3a3c66a493d72cf7afc7ee975e2de399f2e5 URL: https://github.com/llvm/llvm-project/commit/c9ca3a3c66a493d72cf7afc7ee975e2de399f2e5 DIFF: https://github.com/llvm/llvm-project/commit/c9ca3a3c66a493d72cf7afc7ee975e2de399f2e5.dif

[PATCH] D90976: Fixed an issue where diagnostics printed expressions in a roundabout way

wchilders created this revision. wchilders added reviewers: yaxunl, hans, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. wchilders requested review of this revision. Previously expressions were being printed in diagnostics via an implicit conversion to an expressio

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:68 + // Maps the Enum values to the EnumConstantDecl and a bool signifying if its + // cov

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) + set_property(GLO

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek updated this revision to Diff 303567. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/include/clang/Lex/PreprocessorOptions.h clang/lib/Co

  1   2   >