dexonsmith created this revision. dexonsmith added reviewers: arphaman, jansvoboda11, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision.
Qualify definitions with `clang::` rather than opening/closing a namespace. https://reviews.llvm.org/D90957 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang/lib/Frontend/CompilerInvocation.cpp =================================================================== --- clang/lib/Frontend/CompilerInvocation.cpp +++ clang/lib/Frontend/CompilerInvocation.cpp @@ -4072,16 +4072,15 @@ #undef OPTION_WITH_MARSHALLING_FLAG } -namespace clang { - IntrusiveRefCntPtr<llvm::vfs::FileSystem> -createVFSFromCompilerInvocation(const CompilerInvocation &CI, - DiagnosticsEngine &Diags) { +clang::createVFSFromCompilerInvocation(const CompilerInvocation &CI, + DiagnosticsEngine &Diags) { return createVFSFromCompilerInvocation(CI, Diags, llvm::vfs::getRealFileSystem()); } -IntrusiveRefCntPtr<llvm::vfs::FileSystem> createVFSFromCompilerInvocation( +IntrusiveRefCntPtr<llvm::vfs::FileSystem> +clang::createVFSFromCompilerInvocation( const CompilerInvocation &CI, DiagnosticsEngine &Diags, IntrusiveRefCntPtr<llvm::vfs::FileSystem> BaseFS) { if (CI.getHeaderSearchOpts().VFSOverlayFiles.empty()) @@ -4109,5 +4108,3 @@ } return Result; } - -} // namespace clang
Index: clang/lib/Frontend/CompilerInvocation.cpp =================================================================== --- clang/lib/Frontend/CompilerInvocation.cpp +++ clang/lib/Frontend/CompilerInvocation.cpp @@ -4072,16 +4072,15 @@ #undef OPTION_WITH_MARSHALLING_FLAG } -namespace clang { - IntrusiveRefCntPtr<llvm::vfs::FileSystem> -createVFSFromCompilerInvocation(const CompilerInvocation &CI, - DiagnosticsEngine &Diags) { +clang::createVFSFromCompilerInvocation(const CompilerInvocation &CI, + DiagnosticsEngine &Diags) { return createVFSFromCompilerInvocation(CI, Diags, llvm::vfs::getRealFileSystem()); } -IntrusiveRefCntPtr<llvm::vfs::FileSystem> createVFSFromCompilerInvocation( +IntrusiveRefCntPtr<llvm::vfs::FileSystem> +clang::createVFSFromCompilerInvocation( const CompilerInvocation &CI, DiagnosticsEngine &Diags, IntrusiveRefCntPtr<llvm::vfs::FileSystem> BaseFS) { if (CI.getHeaderSearchOpts().VFSOverlayFiles.empty()) @@ -4109,5 +4108,3 @@ } return Result; } - -} // namespace clang
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits