[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/cla

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___ cfe-commits mailing list cfe-com

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:256 + SourceLocation getBeginningOfIdentifier(const Position &Pos, const SourceManager &SM, the fu

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. That makes lots of sense now :) Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67670/new/ https://reviews.llvm.org/D67670 ___

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

ilya-biryukov added a comment. Do we have unit tests for clang-tidy? If yes, could we also add unit-tests for this function? The modified function only needs a source manager and lang options, these are easy to mock. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. The fix itself LGTM, getting rid of an infinite loop is important. All my comment can be addressed later... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL372201: [Support] Replace function with function_ref in writeFileAtomically. NFC (authored by ibiryukov, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llv

[PATCH] D61717: Fix arm_neon.h to be clean under -fno-lax-vector-conversions.

SjoerdMeijer added a comment. Many thanks! I've passed on the message, hopefully we can do something about this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61717/new/ https://reviews.llvm.org/D61717 ___ cfe-commi

[PATCH] D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC

ilya-biryukov reopened this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Ah, the tests fail to compile because we now have an overload where the only difference is `function_ref` vs `StringRef`. This works fine with `std::function`, STL probably ensure

r372203 - [lldb] Print better diagnostics for user expressions and modules

Author: teemperor Date: Wed Sep 18 01:53:35 2019 New Revision: 372203 URL: http://llvm.org/viewvc/llvm-project?rev=372203&view=rev Log: [lldb] Print better diagnostics for user expressions and modules Summary: Currently our expression evaluators only prints very basic errors that are not very us

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske updated this revision to Diff 220625. balazske added a comment. Rebase and update according to comments. C++17 related changes not implemented yet (possible check for the called allocation function). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

hokein updated this revision to Diff 220627. hokein marked 2 inline comments as done. hokein added a comment. Handle the eof corner case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67654/new/ https://reviews.llvm.org/D67654 Files: clang-tools

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

hokein added a comment. > Do we have unit tests for clang-tidy? If yes, could we also add unit-tests > for this function? > The modified function only needs a source manager and lang options, these > are easy to mock. Unfortunately, we don't have any unit tests for all these utility functions.

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske updated this revision to Diff 220628. balazske added a comment. Fixed the test, fixed problems in list.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D67545 Files: clang-tools-extra/clang-tidy/cer

[clang-tools-extra] r372206 - [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

Author: hokein Date: Wed Sep 18 02:21:35 2019 New Revision: 372206 URL: http://llvm.org/viewvc/llvm-project?rev=372206&view=rev Log: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check. Reviewers: ilya-biryukov Subscribers: xazax.hun, cfe-commits Tags: #clang D

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372206: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration… (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker.

balazske abandoned this revision. balazske added a comment. I try to improve `StreamChecker` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67480/new/ https://reviews.llvm.org/D67480 ___ cfe-co

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton added a comment. I agree inline asm is a far from optimal solution but it seems like the lesser of two evils for now. This sounds like a good idea, but we need to be able to guarantee that the backend will be able to match to the correct instruction for all optimisation levels before

[PATCH] D65433: [clangd] DefineInline action availability checks

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:65 +const FunctionDecl *getSelectedFunction(const SelectionTree::Node *SelNode) { + const ast_type_traits::DynTypedNode &AstNode = SelNode->ASTNode; + if (const FunctionDecl *FD

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 220645. peterwaller-arm marked 6 inline comments as done. peterwaller-arm retitled this revision from "[clang][driver] Add basic --driver-mode=fortran support for flang" to "[clang][driver] Add basic --driver-mode=flang support for fortran". peterwall

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4788 +bool Driver::ShouldUseFlangCompiler(const JobAction &JA) const { + // Say "no" if there is not exactly one input of a type flang understands. + if (JA.size() != 1 || richard.ba

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 220646. peterwaller-arm added a comment. Updated comment for IsFlangMode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Too

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/google-objc-require-category-method-prefixes.rst:41 + +.. option:: ExpectedPrefixes + stephanemoore wrote: > aaron.ballman wrote: > > stephanemoore wrote: > > > This option

r372217 - [AST] CommentLexer - Remove (optional) Invalid parameter from getSpelling.

Author: rksimon Date: Wed Sep 18 05:11:16 2019 New Revision: 372217 URL: http://llvm.org/viewvc/llvm-project?rev=372217&view=rev Log: [AST] CommentLexer - Remove (optional) Invalid parameter from getSpelling. The static analyzer noticed that we were dereferencing it even when the default null va

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:38 +return; + + ASTContext &Context = D->getASTContext(); Would it make sense to early return here if the language dialect is >= C++17 ? =

r372220 - [mips] Pass "xgot" flag as a subtarget feature

Author: atanasyan Date: Wed Sep 18 05:24:57 2019 New Revision: 372220 URL: http://llvm.org/viewvc/llvm-project?rev=372220&view=rev Log: [mips] Pass "xgot" flag as a subtarget feature We need "xgot" flag in the MipsAsmParser to implement correct expansion of some pseudo instructions in case of usi

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + martong wrote:

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + martong wrot

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + lebedev.r

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lebedev.ri added a comment. In D67661#1673712 , @s.egerton wrote: > I agree inline asm is a far from optimal solution but it seems like the > lesser of two evils for now. Hm, i thought some previous patch already adds llvm ir riscv-specific intrinsics

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

aaron.ballman added a comment. The review says you abandoned it -- was that accidental? Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:72 + +const Expr *Obj = BinOp->getLHS(); +const std::string ObjName = boga95 wrote: > I found an

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + aaron.ballman w

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + martong wrote:

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + martong w

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + aaron.ballman w

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + martong w

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

kiranchandramohan added a comment. Some minor comments about Filetypes and file extensions. Can be ignored or considered for a separate commit. Comment at: clang/include/clang/Driver/Driver.h:69 +CLMode, +FlangMode, } Mode; Is the comma by choice?

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + aaron.bal

RE: r372185 - Revert "Create UsersManual section entitled 'Controlling Floating Point"

Ah, sorry- It broke the sphinx build bot, and the author was home for the evening and is going to get to it during the day today. From: Richard Smith Sent: Tuesday, September 17, 2019 8:10 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r372185 - Revert "Create UsersManual section entitled 'C

r372225 - Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Author: hans Date: Wed Sep 18 06:41:51 2019 New Revision: 372225 URL: http://llvm.org/viewvc/llvm-project?rev=372225&view=rev Log: Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)" This broke the Chromium build. Consider the following code: float ScaleSumSamples_C(con

Re: r372082 - [Clang] Pragma vectorize_width() implies vectorize(enable)

I've reverted this in r372225 as it broke the Chromium build. It seems it doesn't actually manage to enable vectorization of a simple loop at -Oz, and at -Os it asserts. See details in my commit message. On Tue, Sep 17, 2019 at 10:41 AM Sjoerd Meijer via cfe-commits wrote: > > Author: sjoerdmeije

[PATCH] D67706: [clang][checkers] Using CallDescription in StreamChecker.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. Recognization of function names is done now with the CallDescription class instead of using IdentifierInfo. This means function name and argument count is compared to

Re: r372082 - [Clang] Pragma vectorize_width() implies vectorize(enable)

Oopsy daisy! Sorry, and thanks for the revert. I will look into this. From: Hans Wennborg Sent: 18 September 2019 14:41 To: Sjoerd Meijer Cc: cfe-commits Subject: Re: r372082 - [Clang] Pragma vectorize_width() implies vectorize(enable) I've reverted this in r37

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton added a comment. Sorry I misread your original comment. These functions exist so that we can guarantee that these particular instructions will be emitted; the other option was LLVM IR intrinsics and Clang builtins, this was the other patch (https://reviews.llvm.org/D66479). We are pl

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNe

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen updated this revision to Diff 220668. khchen added a comment. Thanks @lenary, I fixed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

r372229 - Recommit -r372180

Author: erichkeane Date: Wed Sep 18 08:09:49 2019 New Revision: 372229 URL: http://llvm.org/viewvc/llvm-project?rev=372229&view=rev Log: Recommit -r372180 Commit message below, original caused the sphinx build bot to fail, this one should fix it. Create UsersManual section entitled 'Controlling

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Meinersbur any feedback on this update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 ___ cfe-commits mailing list cfe-com

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lebedev.ri added a comment. In D67661#1673993 , @lebedev.ri wrote: > In D67661#1673918 , @s.egerton wrote: > > > Sorry I misread your original comment. > > > (which one?) > > > These functions exist so that we can g

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 220677. lewis-revill added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace internal -mllvm option with target feature enabled through the clang frontend using -msave-restore. Repository: rG LLVM Github Monore

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().getNewAlign(); + balazske

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lebedev.ri added a comment. In D67661#1673918 , @s.egerton wrote: > Sorry I misread your original comment. (which one?) > These functions exist so that we can guarantee that these particular > instructions will be emitted; Sure, that makes sense. > t

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/DefaultOperatorNewCheck.cpp:51 + // The alignment used by default 'operator new' (in bits). + const unsigned DefaultAlignment = Context.getTargetInfo().g

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220675. mbrkusanin added a comment. Herald added subscribers: lldb-commits, cfe-commits, seiya, lenary, rupprecht, jrtc27, hiraditya. Herald added projects: clang, LLDB. - MCTargetOptions is now always passed to MCAsmInfo (or rather createMCAsmInfo). In p

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. In D66795#1650305 , @atanasyan wrote: > But take a look at `LLVMCreateDisasmCPUFeatures` function from > `Disassembler.cpp`. If we cannot retrieve `MCTargetOptions` right in this > function, we will have to change "LLVM-C" int

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 220681. peterwaller-arm marked 6 inline comments as done. peterwaller-arm added a comment. - Fixed spurious comma - Fixed incorrect comment and changed comment wrapping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://review

[PATCH] D67713: [OpenCL] Add image query builtin functions

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Add the image query builtin functions from the OpenCL C specification. Patch by Pierre Gondois and Sven van

[PATCH] D67654: [clang-tidy] Fix a potential infinite loop in readability-isolate-declaration check.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:38 template SourceLocation findPreviousAnyTokenKind(SourceLocation Start, const SourceManag

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Add the -Wconversion -Werror options to check no unexpected conversion is done. Patch by Pierre Gondois and

[PATCH] D62394: [ARM][CMSE] Add CMSE header & builtins

pbarrio added a comment. Hi, CMSE upstreaming is indeed one of our priorities. So yes, we are very interested in your feedback. And no, CMSE upstreaming is not abandoned, just going a bit slow ATM :( but any help reviewing is much appreciated! :) @chill would it make sense to start upstream oth

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 220686. khchen marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp clang/test/Drive

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 220687. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp clang/test/Driver/Inputs/multilib_riscv_elf_sdk/lib/gcc/r

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 3 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1548 +{M.gccSuffix(), + "/../../../../riscv64-unknown-elf/lib" + M.gccSuffix()}); + }); kito-cheng wrot

[libunwind] r372233 - unwind: remove a could of extraneous `else` (NFC)

Author: compnerd Date: Wed Sep 18 09:15:56 2019 New Revision: 372233 URL: http://llvm.org/viewvc/llvm-project?rev=372233&view=rev Log: unwind: remove a could of extraneous `else` (NFC) Simplify `if return else return` by removing the unnecessary `else`. Modified: libunwind/trunk/src/libunwin

r372235 - [OPENMP5.0]Allow multiple context selectors in the context selector

Author: abataev Date: Wed Sep 18 09:24:31 2019 New Revision: 372235 URL: http://llvm.org/viewvc/llvm-project?rev=372235&view=rev Log: [OPENMP5.0]Allow multiple context selectors in the context selector sets. According to OpenMP 5.0, context selector set might include several context selectors, se

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, krasimir, timwoj. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=41899 auto lambda = [&a = a]() { a = 2; }; is formatted as auto la

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

mgorny created this revision. mgorny added reviewers: krytarowski, eugenis, leonardchan, vitalybuka, phosek. Add a 'leak_sanitizer' feature akin to existing '*_sanitizer' features to let programmers switch code paths accounting for leak sanitizers being enabled. https://reviews.llvm.org/D67719

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67718/new/ https://reviews.llvm.org/D67718 ___ cfe-commits mail

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

richard.barton.arm added a comment. Thanks for the updates. I think this is now looking good and matches the RFC already posted. One thought that occurs to me when reviewing this. I think we will assume that F18 /flang when it lands in the LLVM project will be an

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This adds semantic selection to the LSP Server. Adds support for serialization of input request and the o

r372237 - [c++20] P1331R2: Allow transient use of uninitialized objects in

Author: rsmith Date: Wed Sep 18 10:37:44 2019 New Revision: 372237 URL: http://llvm.org/viewvc/llvm-project?rev=372237&view=rev Log: [c++20] P1331R2: Allow transient use of uninitialized objects in constant evaluation. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/include/clan

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. FWIW, I like this approach better than the one in Static Analyzer because it warns on the variable declaration -- that's where the root of the issue is, not at the call to `dispatch_once

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

ilya-biryukov added a comment. A drive-by comment... Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135 + Params.positions.size()); +Reply(llvm::make_error("failed to decode request", + ErrorCode::InvalidRequest));

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220703. usaxena95 added a comment. Fixed error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This adds a clang option to disable inline line tables. When it is used, the inliner uses the call site as the location of the inlined f

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me but I guess someone else should give the final approval. Comment at: llvm/lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp:25 if (TheTriple.isMI

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

hfinkel added a comment. > One thought that occurs to me when reviewing this. I think we will assume > that F18 /flang when it lands in the LLVM > project will be an optional thing to build and will be an opt-in project at > the start that is off by default. What h

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220710. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135 + Params.positions.size()); +Reply(llvm::make_error("failed to decode request", + ErrorCode::InvalidRequest)); ilya-biry

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

rnk added a comment. + other debug info people Comment at: llvm/docs/LangRef.rst:1436 function. This can have very system-specific consequences. +``no-inline-line-tables`` +When this attribute is set to true, inline line tables are not generated This i

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 ___ cfe

r372246 - [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

Author: paulhoad Date: Wed Sep 18 11:57:09 2019 New Revision: 372246 URL: http://llvm.org/viewvc/llvm-project?rev=372246&view=rev Log: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab Summary: clang-format 8.0 crashes with SIGFPE (floating point ex

[PATCH] D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab

This revision was automatically updated to reflect the committed changes. Closed by commit rL372246: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

r372247 - [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

Author: epilk Date: Wed Sep 18 12:05:14 2019 New Revision: 372247 URL: http://llvm.org/viewvc/llvm-project?rev=372247&view=rev Log: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd Also, add a diagnostic under -Wformat for printing a boolean value as a character. rdar:

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

This revision was automatically updated to reflect the committed changes. Closed by commit rL372248: make -frewrite-includes also rewrite conditions in #if/#elif (authored by llunak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

This revision was automatically updated to reflect the committed changes. Closed by commit rL372247: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r372248 - make -frewrite-includes also rewrite conditions in #if/#elif

Author: llunak Date: Wed Sep 18 12:09:41 2019 New Revision: 372248 URL: http://llvm.org/viewvc/llvm-project?rev=372248&view=rev Log: make -frewrite-includes also rewrite conditions in #if/#elif Those conditions may use __has_include, which needs to be rewritten. The existing code has already trie

r372249 - [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

Author: paulhoad Date: Wed Sep 18 12:11:40 2019 New Revision: 372249 URL: http://llvm.org/viewvc/llvm-project?rev=372249&view=rev Log: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression Summary: https://bugs.llvm.org/show_bug.cgi?id=41899 ```au

r372250 - actually also compile output in tests for -frewrite-includes

Author: llunak Date: Wed Sep 18 12:12:14 2019 New Revision: 372250 URL: http://llvm.org/viewvc/llvm-project?rev=372250&view=rev Log: actually also compile output in tests for -frewrite-includes Checking that the created output matches something is nice, but this should also check whether the outp

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. As per the bug - I'm not super inclined towards a function attribute here (& even if it's going to be an inliner rather than debug info generation/backend thing (which I'm more on the fence about - think I'm happy with

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added a comment. In D67647#1673363 , @comex wrote: > Ugh, it looks like `getArgs()` is a massive strict aliasing violation. And > it's used in enough different places in Clang that fixing the violation may > require extensive refactoring... I'v

[PATCH] D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL372249: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D63979: actually also compile output in tests for -frewrite-includes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372250: actually also compile output in tests for -frewrite-includes (authored by llunak, committed by ). Herald added a p

r372252 - [OPENMP]Fix for PR43349: Crash for privatized loop bound.

Author: abataev Date: Wed Sep 18 12:24:07 2019 New Revision: 372252 URL: http://llvm.org/viewvc/llvm-project?rev=372252&view=rev Log: [OPENMP]Fix for PR43349: Crash for privatized loop bound. If the variable, used in the loop boundaries, is not captured in the construct, this variable must be con

[PATCH] D67730: [CUDA][HIP] Fix typo in `BestViableFunction`

hliao created this revision. hliao added a reviewer: tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Should consider viable ones only when checking SameSide candidates. - Replace erasing with clearing viable flag to reduce data moving/copying. - Add one and revise ano

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

boga95 marked an inline comment as done. boga95 added a comment. Resolving the problems properly seemed quite difficult. I just finished university and started to work, therefore I don't have enough free time to finish the checker. Sorry about that. CHANGES SINCE LAST ACTION https://reviews.

r372261 - On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

Author: dim Date: Wed Sep 18 13:58:03 2019 New Revision: 372261 URL: http://llvm.org/viewvc/llvm-project?rev=372261&view=rev Log: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher Summary: In https://svnweb.freebsd.org/changeset/base/349351, FreeBSD 13 and higher transitioned to Secure-

[PATCH] D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher

This revision was automatically updated to reflect the committed changes. Closed by commit rL372261: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

  1   2   >