ilya-biryukov reopened this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

Ah, the tests fail to compile because we now have an overload where the only 
difference is `function_ref` vs `StringRef`.
This works fine with `std::function`, STL probably ensures the conversions from 
`StringRef` to `std::functtion` fail and `function_ref` will only fail at 
constructor instantiation time.

I'll keep this open for now, will see if it's feasible to make `function_ref` 
similar to `std::function` in that case.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67584/new/

https://reviews.llvm.org/D67584



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to