EricWF added a comment.
I should have asked, have we actually seen a midcompile caused by this? Is
there a reproducer? Or is this purerly speculative?
Repository:
rCXX libc++
https://reviews.llvm.org/D47607
___
cfe-commits mailing list
cfe-commi
ebevhan added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:45
+ AccumWidth = AccumAlign = 32;
+ LongAccumWidth = LongAccumAlign = 64;
SuitableAlign = 64;
rsmith wrote:
> leonardchan wrote:
> > leonardchan wrote:
> > > ebevhan wrote:
> > > > leonardc
ebevhan added inline comments.
Comment at: include/clang/AST/ASTContext.h:2882
+
+ QualType getCorrespondingSaturatedType(const QualType &Ty) const;
};
This probably belongs up near the other predicates.
Also I think it's more common to simply pass `QualType`
aheejin created this revision.
aheejin added a reviewer: sbc100.
Herald added a subscriber: cfe-commits.
Because `llvm::Triple` can be derived from `TargetInfo`, it is simpler
to take only `TargetInfo` argument.
Repository:
rC Clang
https://reviews.llvm.org/D47620
Files:
lib/CodeGen/CGExce
aheejin marked an inline comment as done.
aheejin added inline comments.
Comment at: lib/CodeGen/CGException.cpp:322
const EHPersonality &CXX =
- getCXXPersonality(getTarget().getTriple(), LangOpts);
+ getCXXPersonality(getTarget().getTriple(), LangOpts, getTarget())
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm with just a few more nits.
Comment at: clang-doc/BitcodeWriter.cpp:484
#undef EMITINFO
Nit: `EMITINFO` is a bit confusing with `writeInfo`. Are the
tkrupa added a comment.
Mask scalar case is closed and doesn't have any effects on this revision.
Besides, I resolved issues connected to lowering scalar sqrt intrinsics without
rounding (that is, if https://reviews.llvm.org/D47621 is accepted). Should I
add them here to have everything sqrt in
baloghadamsoftware added a comment.
Did the tests execute? I am not sure. First problem is the the container may
become dead before the iterator, so its `Begin` and `End` symbols may be
inaccessible. This is easy to solve by marking the container of the iterator as
live. However, there is a sec
balazske updated this revision to Diff 149412.
balazske added a comment.
- Added comment, renamed beginSourceFile, removed check for PP.
Check for PP is removed because it is allowed to be nullptr.
Repository:
rC Clang
https://reviews.llvm.org/D47445
Files:
include/clang/Frontend/ASTUnit.
balazske added a comment.
From API point of view if there is a `enableSourceFileDiagnostics` there should
be a `disableSourceFileDiagnostics` too (that calls the `EndSourceFile`). But I
am not sure how and if to use it at all. In the unit tests it is not needed,
the ASTUnit contains a single en
ioeric added inline comments.
Comment at: clang-tools-extra/docs/index.rst:27
pp-trace
- clang-rename
clangd
It seems that the clang-rename tool is still in the extra repository. I think
we should probably "advertise" `clang-rename` as part of clang-re
SjoerdMeijer added inline comments.
Comment at: test/Sema/aarch64-neon-fp16-ranges.c:1
+// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon
-fallow-half-arguments-and-returns -target-feature +fullfp16 -ffreestanding
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -tri
SjoerdMeijer added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1409
- switch (BuiltinID) {
-#define GET_NEON_OVERLOAD_CHECK
-#include "clang/Basic/arm_neon.inc"
Why do we need to remove this?
Comment at: lib/Sema/SemaChecking.cpp:14
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/index/Index.h:158
unsigned References = 0;
-
+ /// Whether or not this is symbol is meant to be used for the global
+ /// completion.
---
ebevhan updated this revision to Diff 149415.
ebevhan edited the summary of this revision.
ebevhan added a comment.
Changed ArrayIndexTy back to LongLongTy and reverted the test change.
https://reviews.llvm.org/D46944
Files:
lib/StaticAnalyzer/Core/ProgramState.cpp
lib/StaticAnalyzer/Core/R
RKSimon requested changes to this revision.
RKSimon added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D41168#1118624, @tkrupa wrote:
> Mask scalar case is closed and doesn't have any effects on this revision.
> Besides, I resolved issues connected to low
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Is it plausible to add a unit-test for this?
https://reviews.llvm.org/D47460
___
cfe-commits mailing list
cfe-commits@lists.l
Author: mstorsjo
Date: Fri Jun 1 02:40:50 2018
New Revision: 333734
URL: http://llvm.org/viewvc/llvm-project?rev=333734&view=rev
Log:
[X86] Remove leftover semicolons at end of macros
This was missed in a few places in SVN r333613, causing compilation
errors if these macros are used e.g. as para
tkrupa updated this revision to Diff 149417.
tkrupa added a comment.
Added missing scalar intrinsics without rounding.
Repository:
rC Clang
https://reviews.llvm.org/D46892
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
test/CodeGen/avx512f-builtins.c
test/CodeGen/avx512
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek.
These decls are sometime used as the canonical declarations (e.g. for
go-to-def),
which seems to be bad.
Repository:
rCTE Clang Tools Extra
https:
tkrupa updated this revision to Diff 149419.
tkrupa added a comment.
Added missing scalar intrinsics without rounding.
Repository:
rC Clang
https://reviews.llvm.org/D41168
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
test/CodeGen/avx512f-builtins.c
test/CodeGen/avx512
Author: ibiryukov
Date: Fri Jun 1 02:49:53 2018
New Revision: 333735
URL: http://llvm.org/viewvc/llvm-project?rev=333735&view=rev
Log:
[CodeComplete] Add a few extra tests for r333538. NFC
From a follow-up discussion in D44480.
New tests check that function bodies are not skipped:
- In presence
tkrupa added a comment.
Whoops, that's a wrong revision. I'll revert it shortly.
Repository:
rC Clang
https://reviews.llvm.org/D46892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
tkrupa updated this revision to Diff 149420.
Repository:
rC Clang
https://reviews.llvm.org/D46892
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx2-builtins.c
test/CodeGen/avx512bw-builtins.c
test/CodeGen/avx512vlbw-builtins.c
test/CodeGen/sse2-builtins.c
Index: test/CodeGen/sse2-b
ilya-biryukov added a comment.
In https://reviews.llvm.org/D44480#1117230, @nik wrote:
> In https://reviews.llvm.org/D44480#1117147, @cpplearner wrote:
>
> > Does `getAs()` work correctly with function returning `auto&`?
>
>
> the "getAs()" version will skip the function body and generate an
> e
Author: ibiryukov
Date: Fri Jun 1 03:08:43 2018
New Revision: 333737
URL: http://llvm.org/viewvc/llvm-project?rev=333737&view=rev
Log:
[clangd] Keep only a limited number of idle ASTs in memory
Summary:
After this commit, clangd will only keep the last 3 accessed ASTs in
memory. Preambles for ea
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.h:66
+ std::chrono::steady_clock::duration UpdateDebounce,
+ ASTRetentionPolicy RetentionPolicy = {});
~TUScheduler();
sammccall wrote:
> ilya-biryukov wrote:
> > sam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333737: [clangd] Keep only a limited number of idle ASTs in
memory (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47063
yvvan added a comment.
In https://reviews.llvm.org/D47460#1118694, @ilya-biryukov wrote:
> Is it plausible to add a unit-test for this?
i think I can add a unit-test for it since we have the 'getBufferKind' method
in MemoryBuffer.
https://reviews.llvm.org/D47460
__
CarlosAlbertoEnciso added inline comments.
Comment at: docs/ReleaseNotes.rst:139
+ used in conjunction with ``-Werror`` and as a result, the new warnings
+ are turned into new errors.
+
thakis wrote:
> nit: I'd omit this paragraph -- this is true for all warnin
CarlosAlbertoEnciso updated this revision to Diff 149425.
CarlosAlbertoEnciso marked 3 inline comments as done.
CarlosAlbertoEnciso added a comment.
Address feedback from @thakis in relation to the Release Notes.
https://reviews.llvm.org/D44826
Files:
docs/ReleaseNotes.rst
include/clang/Bas
CarlosAlbertoEnciso added a comment.
Thanks to all reviewers for your comments and suggestions.
https://reviews.llvm.org/D44826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:282-290
+def warn_unused_using_declaration : Warning<
+ "unused using declaration %0">,
+ InGroup, DefaultIgnore;
+def warn_unused_using_directive : Warning<
+ "unused using directive %0">
Hi,
> Just a bit of context and to have some expectation management regarding
> this patch. The main purpose of this implementation was to back a thesis.
> It was made under a very serious time pressure and the main goal was to be
> able to measure on real world projects as soon as possible and i
Author: ibiryukov
Date: Fri Jun 1 05:03:16 2018
New Revision: 333742
URL: http://llvm.org/viewvc/llvm-project?rev=333742&view=rev
Log:
[clangd] Attempt the fix the buildbots after r333737
Modified:
clang-tools-extra/trunk/clangd/TUScheduler.cpp
Modified: clang-tools-extra/trunk/clangd/TUSch
This broke buildbots. Sorry about that.
r333742 should fix them.
On Fri, Jun 1, 2018 at 12:12 PM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Fri Jun 1 03:08:43 2018
> New Revision: 333737
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333737&
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47460#1118782, @yvvan wrote:
> i think I can add a unit-test for it since we have the 'getBufferKind' method
> in MemoryBuffer.
That sounds good. Having a regression test that fails with descriptive messages
in case anyone changes th
sammccall accepted this revision.
sammccall added a comment.
Thanks, LG!
Comment at: clangd/CodeComplete.h:86
+// For index-based completion, we only want:
+// * symbols in namespaces or translation unit scopes (e.g. no class
nit: want -> consider?
==
ilya-biryukov added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:293
assert(CompletionAllocator && CompletionTUInfo);
+ // A declaration created for a friend declaration should not be used as the
+ // canonical declaration in the index.
Mayb
sammccall added a comment.
Do I understand the intent of this change correctly?
- friend decls that are not definitions should be ignored for indexing purposes
- this means they should never be selected as canonical decl
- if the friend decl is the only decl, then the symbol should not be indexed
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:293
assert(CompletionAllocator && CompletionTUInfo);
+ // A declaration created for a friend declaration should not be used as the
+ // canonical declaration in the index.
ilya-biryuk
ebevhan created this revision.
ebevhan added reviewers: rjmccall, arichardson.
Herald added a subscriber: cfe-commits.
The documentation for getAddrSpaceQualType says: "If T already
has an address space specifier, it is silently replaced."
The function did not do this; it asserted instead. Fix it
jmorse created this revision.
jmorse added reviewers: eli.friedman, majnemer.
Herald added a subscriber: cfe-commits.
For pointer assignments of VLA types, Clang currently detects when array
dimensions _lower_ than a variable dimension differ, and reports a warning.
However it does not do the same
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333746: [OpenCL, OpenMP] Fix crash when OpenMP used in
OpenCL file (authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46667?vs=147538&id=149441#toc
Repository:
Author: erichkeane
Date: Fri Jun 1 06:04:26 2018
New Revision: 333746
URL: http://llvm.org/viewvc/llvm-project?rev=333746&view=rev
Log:
[OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file
Compiler crashes when omp simd is used in an OpenCL file:
clang -c -fopenmp omp_simd.cl
__kernel vo
ioeric updated this revision to Diff 149446.
ioeric marked an inline comment as done.
ioeric edited the summary of this revision.
ioeric added a comment.
- Addressed review comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47623
Files:
clangd/index/SymbolCollector.cpp
ebevhan created this revision.
ebevhan added a reviewer: Anastasia.
Herald added a subscriber: cfe-commits.
The comment with the OpenCL clause about this clearly
says: "No type shall be qualified by qualifiers for
two or more different address spaces."
This must mean that two or more qualifiers f
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:297
+// If OrigD is an object of a friend declaration, skip it.
+if (ASTNode.OrigD->getFriendObjectKind() !=
+Decl::FriendObjectKind::FOK_None)
sammccall wrote:
> this seem
erik.pilkington updated this revision to Diff 149449.
erik.pilkington marked 10 inline comments as done.
erik.pilkington added a comment.
Address review comments. Thanks!
https://reviews.llvm.org/D47607
Files:
libcxx/include/__hash_table
libcxx/include/__tree
libcxx/include/map
libcxx/i
erik.pilkington added a comment.
In https://reviews.llvm.org/D47607#1118547, @EricWF wrote:
> I should have asked, have we actually seen a midcompile caused by this? Is
> there a reproducer? Or is this purerly speculative?
Nope, pure speculation. I still think we should still fix this though.
martong created this revision.
martong added reviewers: a.sidorin, balazske, xazax.hun, r.stahl.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Generalize the creation of Decl nodes during Import. With this patch we do the
same things after and before a new AST node is created (::Create
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47623#1118810, @sammccall wrote:
> - friend decls that are not definitions should be ignored for indexing
> purposes
This is not generally true IIUC. A friend declaration can be a reference, a
declaration or a definition.
int foo(
sammccall added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:297
+// If OrigD is an object of a friend declaration, skip it.
+if (ASTNode.OrigD->getFriendObjectKind() !=
+Decl::FriendObjectKind::FOK_None)
ioeric wrote:
> sammccall
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:293
assert(CompletionAllocator && CompletionTUInfo);
+ // A declaration created for a friend declaration should not be used as the
+ // canonical declaration in the index.
ilya-biryuk
gtbercea added a comment.
> I disagree in this context because this patch currently means that static
> archives will only work with NVPTX and there is no clear path how to "fix"
> things for other offloading targets. I'll try to work on my proposal over the
> next few days (sorry, very busy
takuto.ikuta accepted this revision.
takuto.ikuta added a comment.
I confirmed this CL and https://reviews.llvm.org/D47578 remove absolute path
from /showIncludes when include paths are given in relative.
https://reviews.llvm.org/D47480
___
cfe-com
erik.pilkington added inline comments.
Comment at: libcxx/include/__hash_table:2261
+_NodeHandle
+__hash_table<_Tp, _Hash, _Equal, _Alloc>::__node_handle_extract_unique(
+key_type const& __key)
EricWF wrote:
> If I'm not mistaken, `__node_handle_extract_uniqu
Hahnfeld added a comment.
In https://reviews.llvm.org/D47394#1118957, @gtbercea wrote:
> I'm surprised you now disagree with this technique, when I first introduced
> you to this in an e-mail off list you agreed with it.
My words were `I agree this is the best solution for NVPTX.` In the sam
CarlosAlbertoEnciso added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:282-290
+def warn_unused_using_declaration : Warning<
+ "unused using declaration %0">,
+ InGroup, DefaultIgnore;
+def warn_unused_using_directive : Warning<
+ "unused using direc
Author: erichkeane
Date: Fri Jun 1 07:16:18 2018
New Revision: 333752
URL: http://llvm.org/viewvc/llvm-project?rev=333752&view=rev
Log:
Fix unused variable warning from r333718
Modified:
cfe/trunk/lib/Lex/ModuleMap.cpp
Modified: cfe/trunk/lib/Lex/ModuleMap.cpp
URL:
http://llvm.org/viewvc/
bader added inline comments.
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
I think it might be valuable to give a warning or remark to user.
Using the sa
ioeric updated this revision to Diff 149465.
ioeric added a comment.
- Clarify.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47623
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: unittests/clangd/SymbolCollectorTests.cpp
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:297
+// If OrigD is an object of a friend declaration, skip it.
+if (ASTNode.OrigD->getFriendObjectKind() !=
+Decl::FriendObjectKind::FOK_None)
sammccall wrote:
> ioeric wr
Author: hahnfeld
Date: Fri Jun 1 07:43:48 2018
New Revision: 333757
URL: http://llvm.org/viewvc/llvm-project?rev=333757&view=rev
Log:
[OpenMP] Fix typo in NVPTX linker, NFC.
Clang calls "nvlink" for linking multiple object files with OpenMP
target functions, so correct this information when prin
Author: ibiryukov
Date: Fri Jun 1 07:44:57 2018
New Revision: 333758
URL: http://llvm.org/viewvc/llvm-project?rev=333758&view=rev
Log:
[clangd] Compute better estimates for memory usage of the AST
Also fix the return value of IdleASTs::getUsedBytes().
It was 'bool' instead of 'size_t' *facepalm*
Author: nico
Date: Fri Jun 1 07:59:57 2018
New Revision: 333761
URL: http://llvm.org/viewvc/llvm-project?rev=333761&view=rev
Log:
clang-cl: Expose -no-canonical-prefixes
-no-canonical-prefixes is a weird flag: In gcc, it controls whether realpath()
is called on the path of the driver binary. It'
Hahnfeld added a comment.
Hmm, maybe the scope is much larger: I just tried linking an executable that
references a `declare target` function in a shared library. My assumption was
that this already works, given that `libomptarget`'s registration functions can
be called multiple times. Am I doi
thakis closed this revision.
thakis added a comment.
r333761, thanks!
https://reviews.llvm.org/D47480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Fri Jun 1 08:02:43 2018
New Revision: 333762
URL: http://llvm.org/viewvc/llvm-project?rev=333762&view=rev
Log:
Remove redundant -fno-coverage-mapping added in r333761 (already added in
r333423)
Modified:
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/test/Driver/
thakis marked 2 inline comments as done.
thakis added inline comments.
Comment at: test/Driver/cl-options.c:595
+// RUN: -no-canonical-prefixes \
+// RUN: -fno-coverage-mapping \
// RUN: --version \
rnk wrote:
> takuto.ikuta wrote:
> > Is this relate
ebevhan added inline comments.
Comment at: test/Sema/address_spaces.c:17
int *_AS1 _AS2 *Z; // expected-error {{multiple address spaces specified
for type}}
+ int *_AS1 _AS1 *M;
bader wrote:
> I think it might be valuable to give a warning or remark to us
xazax.hun added a comment.
Sorry for the limited activity. Unfortunately, I have very little time
reviewing patches lately.
I think we need to answer the following questions:
- Does this change affect the analysis of the constructors of global objects?
If so, how?
- Do we want to import non-con
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:223-225
+ ExplodedNode *Node = Context.generateNonFatalErrorNode(Context.getState());
+ if (!Node)
+return;
Szelethus wrote:
> NoQ wrote:
> > Szelethus w
efriedma added inline comments.
Comment at: lib/AST/ASTContext.cpp:8588
+ Expr *E = VAT->getSizeExpr();
+ if (E && VAT->getSizeExpr()->isIntegerConstantExpr(TheInt, *this))
+return std::make_pair(true, TheInt);
`E && E->isIntegerCons
mike.dvoretsky updated this revision to Diff 149484.
mike.dvoretsky added a comment.
Changed the scalar intrinsic lowering to work via extract-insert.
https://reviews.llvm.org/D45203 contains tests for folding the resulting IR
patterns.
https://reviews.llvm.org/D45202
Files:
clang/lib/CodeG
sammccall created this revision.
sammccall added reviewers: malaperle, ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, ioeric, klimek.
The EINTR loop around getline was added to fix an issue with mac gdb, but seems
to loop infinitely in rare cases on linux where the parent editor ex
sammccall added a comment.
@malaperle: would you mind patching this in and checking whether attaching a
debugger still works on Mac (this was the reason for the EINTR loop, right?)
I want to preserve this but now people other than me are complaining about old
clangds hanging around and eating a
juliehockett updated this revision to Diff 149500.
juliehockett marked 8 inline comments as done.
https://reviews.llvm.org/D43341
Files:
clang-doc/BitcodeReader.cpp
clang-doc/BitcodeReader.h
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.txt
clang-doc/Repre
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This looks OK, the asymmetry still seems a little odd to me and could be
reduced a little.
(Please also resolve Ilya's question about references with him, I don't have a
strong opinion)
Meinersbur added a comment.
The RFC: https://lists.llvm.org/pipermail/cfe-dev/2018-May/058141.html
https://reviews.llvm.org/D47267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vedantk
Date: Fri Jun 1 10:11:18 2018
New Revision: 333775
URL: http://llvm.org/viewvc/llvm-project?rev=333775&view=rev
Log:
[Coverage] Remove a test dependency on the itanium ABI
This should address a bot failure:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/
ruiu added a comment.
It seems like you are trying a bit too hard to keep the original code which is
not always a good idea to keep the clarity of the code.
So, IIUC, you this function:
- returns a full filename of the current executable. That can be written using
GetModuleFileName and GetLong
tra added a comment.
IIUIC, nv_weak is a synonym for weak (why, oh why did they need
it?)
You may need to hunt down and change few other places that deal with the weak
attribute.
E.g.:
https://github.com/llvm-project/llvm-project-20170507/blob/master/clang/lib/AST/Decl.cpp#L4267
https://github.
tra added a comment.
IMO overriding TargetTransformInfo::areInlineCompatible to always return true
on NVPTX is what we want to do instead of upgrading everything else.
AFAICT, on NVPTX there's no reason to prevent inlining due to those attributes
-- we'll never generate code, nor will we ever ex
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
LGTM with a nit on a test name.
Comment at: test/Analysis/pr37646.c:1
+// REQUIRES: z3
+// RUN: %clang_analyze_cc1 -triple x86_64-apple-darwin9
george.karpenkov added a comment.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D47201#1119249, @tra wrote:
> IIUIC, nv_weak is a synonym for weak (why, oh why did they need
> it?)
> You may need to hunt down and change few other places that deal with the
> weak attribute.
> E.g.:
> https://github.com/llvm-proje
NoQ added a comment.
We might as well make a directory for z3-specific tests. Eg.,
`z3/bool-bit-width.c`.
Also does this test need to be z3-specific? We would also not like to crash
here without z3.
Repository:
rC Clang
https://reviews.llvm.org/D47617
___
ahatanak added a comment.
In https://reviews.llvm.org/D45015#1105388, @rsmith wrote:
> In https://reviews.llvm.org/D45015#1105372, @vsapsai wrote:
>
> > What when compiler has `__builtin_operator_new`,
> > `__builtin_operator_delete`? If I build libc++ tests with recent Clang
> > which has thes
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
There's quite a lot of code duplication here, I think we could do better with
that. Great job modeling semantics though!
Comment at: lib/Analys
george.karpenkov added a comment.
@mikhail.ramalho I assume you know it, but just in case, you can mark
dependencies in phabricator by adding "parent" revisions.
https://reviews.llvm.org/D45517
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
akyrtzi added a comment.
We could leave `disableSourceFileDiagnostics` off until someone finds a use
case for it.
Repository:
rC Clang
https://reviews.llvm.org/D47445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: jfb
Date: Fri Jun 1 11:02:53 2018
New Revision: 333776
URL: http://llvm.org/viewvc/llvm-project?rev=333776&view=rev
Log:
Mark __c11_atomic_load as const
Summary:
C++11 onwards specs the non-member functions atomic_load and
atomic_load_explicit as taking the atomic by const (potentially
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333776: Mark __c11_atomic_load as const (authored by jfb,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47613
Files:
libcxx/trunk/include/ato
Author: ctopper
Date: Fri Jun 1 11:26:35 2018
New Revision: 333778
URL: http://llvm.org/viewvc/llvm-project?rev=333778&view=rev
Log:
[X86] Rewrite avx512vbmi unmasked and maskz macro intrinsics to be wrappers
around their __builtin function with appropriate arguments rather than just
passing ar
ioeric updated this revision to Diff 149526.
ioeric added a comment.
- Make canonical decls determinstic.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47623
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
leonardchan added a comment.
Hi all, I'll be attempting to commit this patch around 6pm PT today unless
anyone has any more comments on this specific patch. Any other suggestions
regarding potential design changes can be discussed in future patches since
this is only the first of many.
Reposi
ioeric updated this revision to Diff 149528.
ioeric added a comment.
- Remove debug message.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47623
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
Index: unit
mikhail.ramalho updated this revision to Diff 149524.
mikhail.ramalho added a comment.
- Simplified the API even further by constructing a Z3ConstraintManager object
directly.
- Update isModelFeasible to return a isModelFeasible
- Update code with the fix for 1-bit long integer
https://reviews.
ioeric added a comment.
In https://reviews.llvm.org/D47623#1118951, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D47623#1118810, @sammccall wrote:
>
> > - friend decls that are not definitions should be ignored for indexing
> > purposes
>
>
> This is not generally true IIUC. A friend decl
1 - 100 of 153 matches
Mail list logo
