erik.pilkington added inline comments.

================
Comment at: libcxx/include/__hash_table:2261
+_NodeHandle
+__hash_table<_Tp, _Hash, _Equal, _Alloc>::__node_handle_extract_unique(
+    key_type const& __key)
----------------
EricWF wrote:
> If I'm not mistaken, `__node_handle_extract_unique` and 
> `__node_handle_extract_multi` have the exact same implementation. This is 
> intentional, no? If so can't we just use one implementation? 
Yep, good point. The new patch just has `__node_handle_extract`.


https://reviews.llvm.org/D46845



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D46845: [... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D468... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D468... Erik Pilkington via Phabricator via cfe-commits
    • [PATCH] D468... Erik Pilkington via Phabricator via cfe-commits
    • [PATCH] D468... Erik Pilkington via Phabricator via cfe-commits

Reply via email to