nik added inline comments.
Comment at: include/clang-c/Index.h:2840
+/**
+ * \brief Describe the "TLS kind" of the declaration referred to by a cursor.
+ */
I was wondering what "TLS" is and had to look it up. If not adapting the
function and enum name, then may
uriel.k added a comment.
If I remove the builtins from the .def file this will not work, as I didn't
replace the builtin call in the Header files but implemented the lowering by
adding cases to the CGBuiltin.cpp and adding the IR by hand.
https://reviews.llvm.org/D37694
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
Oops you are correct. Sorry.
LGTM
https://reviews.llvm.org/D37694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:981
-TARGET_BUILTIN(__builtin_ia32_pbroadcastd512_gpr_mask, "V16iiV16iUs", "",
"avx512f")
TARGET_BUILTIN(__builtin_ia32_pbroadcastq512_mem_mask, "V8LLiLLiV8LLiUc", "",
"avx512f")
TARGET_BUILTI
nik added a comment.
Fixes the reported issue, thanks!
I still run into another case that is not yet properly covered. The reported
issue was extracted from the following case. If you prefer, I'll create a
separate report for the remaining issues.
The follow code outlines the problems in the c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313011: [X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16]
intrinsics to native llvm IR (authored by ytsafrir).
Changed prior to commit:
https://reviews.llvm.org/D37562?vs=114523&id=114772#toc
Repository
Author: ytsafrir
Date: Tue Sep 12 00:46:32 2017
New Revision: 313011
URL: http://llvm.org/viewvc/llvm-project?rev=313011&view=rev
Log:
[X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16] intrinsics to native llvm IR
Differential Revision: https://reviews.llvm.org/D37562
Modified:
cfe/trunk/incl
klimek accepted this revision.
klimek added a comment.
LG. Nice, thanks!
Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:42
+
+class LocalRename : public RefactoringAction {
+public:
I have to admit, the implementation here is pretty neat! :)
Re
erikjv added a comment.
I'd put/fix Nik's issue in a separate patch.
https://reviews.llvm.org/D37700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added a comment.
I'm not sure I like this direction. In my setups, a build-time default isn't
right since I'm using the same clang builds for both native-on-linux building
(with the default `ld` as linker) and cross-building targeting windows (using
`ldd`), and keeping the code that re
Author: ibiryukov
Date: Tue Sep 12 01:35:57 2017
New Revision: 313014
URL: http://llvm.org/viewvc/llvm-project?rev=313014&view=rev
Log:
Fix recording preamble's conditional stack in skipped PP branches.
Summary:
This fixes PR34547.
`Lexer::LexEndOfFile` handles recording of ConditionalStack for
p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313014: Fix recording preamble's conditional stack in
skipped PP branches. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D37700
Files:
cfe/trunk/lib/Lex/PPDirectives.cpp
cf
ilya-biryukov added a comment.
In https://reviews.llvm.org/D37700#867625, @erikjv wrote:
> I'd put/fix Nik's issue in a separate patch.
Totally agree. It seems like a separate issue, though maybe related.
@nik, could you file a separate bug so that we won't forget about it?
Repository:
rL
djasper added a comment.
I am very strongly against a flag that just leaves the line break as is. What's
the motivation?
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Typz updated this revision to Diff 114783.
Typz added a comment.
Rebase to master to fix merge issue
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
lib/
PriMee added a comment.
A new style, e.g. **BraceWrapping.AfterExternC** option is what we are
considering right now. It would probably handle the problem. Leaving the line
break as is might be indeed a bad idea :)
https://reviews.llvm.org/D37260
djasper added a comment.
I have a slightly hard time grasping what this patch now actually does? Doesn't
it simply try to decide whether or not to make a split locally be comparing the
PenaltyBreakComment against the penalty for the access characters? If so,
couldn't we simply do that as an imp
djasper added a comment.
BraceWrapping.AfterExternC makes sense to me.
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
In https://reviews.llvm.org/D37700#867646, @ilya-biryukov wrote:
> @nik, could you file a separate bug so that we won't forget about it?
Done, it's https://bugs.llvm.org/show_bug.cgi?id=34570 .
Repository:
rL LLVM
https://reviews.llvm.org/D37700
PriMee added a comment.
Great! I will work on it :)
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hamzasood updated this revision to Diff 114784.
hamzasood added a comment.
Changed a CMake macro to a function.
https://reviews.llvm.org/D37376
Files:
CMakeLists.txt
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
===
--- lib/CMa
hokein accepted this revision.
hokein added a comment.
LGTM, a few nits.
Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:42
+
+class LocalRename : public RefactoringAction {
+public:
klimek wrote:
> I have to admit, the implementation here is pret
djasper added a comment.
I'd still prefer individual patches for each of these changes. If the code
review system or VCS make it hard for you to deal with two adjacent changes
this way, do them in sequence.
Adding Manuel as a reviewer who has a longer term idea on how to handle macros.
https:
Author: szepet
Date: Tue Sep 12 02:40:13 2017
New Revision: 313016
URL: http://llvm.org/viewvc/llvm-project?rev=313016&view=rev
Log:
[clang-tidy] SuspiciousEnumUsageCheck bugfix
iThere is a reported bug on the checker not handling the some APSInt values
correctly: https://bugs.llvm.org/show_bug.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313016: [clang-tidy] SuspiciousEnumUsageCheck bugfix
(authored by szepet).
Changed prior to commit:
https://reviews.llvm.org/D37572?vs=114567&id=114788#toc
Repository:
rL LLVM
https://reviews.llvm.o
teemperor updated this revision to Diff 114790.
teemperor added a comment.
- Rebased diff before merging.
https://reviews.llvm.org/D37416
Files:
lib/Frontend/CompilerInstance.cpp
unittests/Frontend/CMakeLists.txt
unittests/Frontend/CompilerInstanceTest.cpp
Index: unittests/Frontend/Compi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313018: [ARM] Option for reading thread pointer from
coprocessor register (authored by spetrovic).
Changed prior to commit:
https://reviews.llvm.org/D34878?vs=114618&id=114792#toc
Repository:
rL LLVM
Author: spetrovic
Date: Tue Sep 12 03:40:58 2017
New Revision: 313018
URL: http://llvm.org/viewvc/llvm-project?rev=313018&view=rev
Log:
[ARM] Option for reading thread pointer from coprocessor register
This patch enables option for reading thread pointer directly
from coprocessor register (-mtp=s
mstorsjo added a comment.
Actually, after testing this a bit more and looking at it, I withdraw my
earlier complaints - this does indeed seem to work fine with my test setup. The
generic `TC.GetLinkerPath()` picks up `-fuse-ld=lld` correctly and converts it
into `ld.lld` which should be equival
mstorsjo added a comment.
Does this break things for current users of clang as a drop-in replacement for
gcc in mingw setups, while using e.g. a gcc provided `libstdc++-6.dll`? OTOH,
removing dllimport usually isn't too much of an issue - the calls go via thunks
which is non-ideal and theoretic
martell added a comment.
In https://reviews.llvm.org/D37727#867627, @mstorsjo wrote:
> I'm not sure I like this direction. In my setups, a build-time default isn't
> right since I'm using the same clang builds for both native-on-linux building
> (with the default `ld` as linker) and cross-build
Author: rksimon
Date: Tue Sep 12 04:05:42 2017
New Revision: 313019
URL: http://llvm.org/viewvc/llvm-project?rev=313019&view=rev
Log:
[MS-InlineAsm] Fix cast assertion with vector spills (PR34021)
Differential Revision: https://reviews.llvm.org/D37448
Added:
cfe/trunk/test/CodeGen/pr34021.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313019: [MS-InlineAsm] Fix cast assertion with vector spills
(PR34021) (authored by RKSimon).
Changed prior to commit:
https://reviews.llvm.org/D37448?vs=114569&id=114794#toc
Repository:
rL LLVM
htt
mstorsjo added a comment.
In https://reviews.llvm.org/D37727#867753, @martell wrote:
> In https://reviews.llvm.org/D37727#867627, @mstorsjo wrote:
>
> > I'm not sure I like this direction. In my setups, a build-time default
> > isn't right since I'm using the same clang builds for both native-on
martell updated this revision to Diff 114801.
martell added a comment.
update tests
Repository:
rL LLVM
https://reviews.llvm.org/D37727
Files:
lib/Driver/ToolChains/MinGW.cpp
test/Driver/mingw-useld.c
Index: test/Driver/mingw-useld.c
Author: rksimon
Date: Tue Sep 12 05:16:35 2017
New Revision: 313024
URL: http://llvm.org/viewvc/llvm-project?rev=313024&view=rev
Log:
Limit test to x86 targets
Modified:
cfe/trunk/test/CodeGen/pr34021.c
Modified: cfe/trunk/test/CodeGen/pr34021.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/
mstorsjo added a comment.
Looks good to me (but maybe someone else should approve it as well)
Repository:
rL LLVM
https://reviews.llvm.org/D37727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
martell added a comment.
In https://reviews.llvm.org/D37727#867751, @mstorsjo wrote:
> I do the same by adding -rtlib=compiler-rt -stdlib=libc++ -fuse-ld=lld
> -Qunused-arguments in the frontend script wrapper (a wrapper named
> -w64-mingw32-clang that just calls clang -target -w64-mingw32
> -
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313025: [refactor] add a refactoring action rule that
returns symbol occurrences (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D36574?vs=114309&id=114806#toc
Repository:
r
Author: arphaman
Date: Tue Sep 12 05:48:37 2017
New Revision: 313025
URL: http://llvm.org/viewvc/llvm-project?rev=313025&view=rev
Log:
[refactor] add a refactoring action rule that returns symbol occurrences
Differential Revision: https://reviews.llvm.org/D36574
Modified:
cfe/trunk/include/c
arphaman reopened this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Oops, I've put in the wrong diff link for r313025. This patch is still not
committed.
Repository:
rL LLVM
https://reviews.llvm.org/D36574
___
arphaman closed this revision.
arphaman added a comment.
Committed in r313025
Repository:
rL LLVM
https://reviews.llvm.org/D37210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Tue Sep 12 06:03:42 2017
New Revision: 313027
URL: http://llvm.org/viewvc/llvm-project?rev=313027&view=rev
Log:
Fix GCC build error and warnings from r313025
Modified:
cfe/trunk/unittests/Tooling/RefactoringActionRulesTest.cpp
Modified: cfe/trunk/unittests/Tooling/Refa
frutiger updated this revision to Diff 114818.
frutiger added a comment.
Expand the acronym 'TLS' to 'thread-local storage' in documentation.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tool
mibintc updated this revision to Diff 114820.
mibintc added a comment.
I heard that @jyknight is still interested in this functionality, updating the
patch to latest sources, to do this i needed to make a small change to a couple
of driver tests. Other than that it's the same as previous submiss
teemperor updated this revision to Diff 114823.
teemperor added a comment.
- Rebased with the correct diff...
https://reviews.llvm.org/D37416
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/CompilerInstance.cpp
lib/Frontend/FrontendAction.cpp
unittests/Frontend/CMakeLists.
yaxunl created this revision.
Add tests for different address spaces and insert some blank lines to make them
more readable.
https://reviews.llvm.org/D37742
Files:
test/CodeGenOpenCL/atomic-ops-libcall.cl
test/CodeGenOpenCL/atomic-ops.cl
Index: test/CodeGenOpenCL/atomic-ops.cl
===
bjope added a comment.
This patch looks good to me now.
But I'm currently working in the same out-of-tree project as the author, so it
would be nice if someone else could have a look as well and accept this.
https://reviews.llvm.org/D37254
___
cfe-
Author: ibiryukov
Date: Tue Sep 12 06:57:14 2017
New Revision: 313029
URL: http://llvm.org/viewvc/llvm-project?rev=313029&view=rev
Log:
[clangd] Add support for snippet completions
Enhances CompletionItemsCollector in such a way that snippet
completions can be presented to the client. Enable snip
ilya-biryukov added a comment.
Done. It's now in. Thanks for the contribution!
Had to make a few changes before committing.
- Fix compilation of tests.
- Update VSCode "engine" dependency in vscode toy client.
https://reviews.llvm.org/D37101
___
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
Overall looks good, but still needs at least a few tests.
https://reviews.llvm.org/D36150
___
cfe-commits mailing list
cf
aaron.ballman added a comment.
In https://reviews.llvm.org/D37436#867287, @rsmith wrote:
> If this is just supposed to be an experiment to get feedback on the feature,
> then I don't think we should be treating it as a different attribute syntax
> at all. Rather, I think we
> just want to per
aaron.ballman updated this revision to Diff 114827.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
Updates based on review feedback.
https://reviews.llvm.org/D37436
Files:
include/clang/Basic/Attr.td
include/clang/Basic/Attributes.h
include/clang/Basic/Lang
ilya-biryukov closed this revision.
ilya-biryukov added a comment.
Marking as closed, had to commit by hand without `arc patch` as it couldn't
find base revision to apply the patch on.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cf
jina.nahias updated this revision to Diff 114836.
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
te
ilya-biryukov added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:75
+ if (CachedIt != CompilationDatabases.end())
+return (CachedIt->second.get());
+ auto CDB = tooling::CompilationDatabase::loadFromDirectory(File, Error);
Parentheses s
Author: marshall
Date: Tue Sep 12 08:00:43 2017
New Revision: 313031
URL: http://llvm.org/viewvc/llvm-project?rev=313031&view=rev
Log:
Make pbump (internally) handle sizes bigger than MAX_INT. Fixes PR#33725 -
thanks to Jonathan Wakely for the report
Added:
libcxx/trunk/test/std/input.outpu
Author: rksimon
Date: Tue Sep 12 08:04:04 2017
New Revision: 313034
URL: http://llvm.org/viewvc/llvm-project?rev=313034&view=rev
Log:
Fix PR34021 test on non-x86 build targets
Modified:
cfe/trunk/test/CodeGen/pr34021.c
Modified: cfe/trunk/test/CodeGen/pr34021.c
URL:
http://llvm.org/viewvc/l
compnerd added a comment.
Do you have commit rights or would you like me to commit this on your behalf?
https://reviews.llvm.org/D37577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
frutiger added a comment.
I do not have commit rights - please commit this yourself, thanks!
https://reviews.llvm.org/D37577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:141
+ assert(CheckExecuted &&
+ "Non of the subroutines executed, logic error in matcher!");
+}
Non -> None
Comment at: clang-tidy/cppc
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8602
- if (op == BO_LT && isNonBooleanUnsignedValue(LHS) && IsZero(S, RHS)) {
-S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
- << "< 0" << "false" << HasEnumType(LHS)
aaron.ballman added a comment.
In https://reviews.llvm.org/D33826#866170, @lebedev.ri wrote:
> In https://reviews.llvm.org/D33826#866161, @JonasToth wrote:
>
> > There is an exception to the general rule (EXP36-C-EX2), stating that the
> > result of `malloc` and friends is allowed to be casted t
aaron.ballman added a comment.
In https://reviews.llvm.org/D33826#867155, @rjmccall wrote:
> In https://reviews.llvm.org/D33826#866170, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D33826#866161, @JonasToth wrote:
> >
> > > There is an exception to the general rule (EXP36-C-EX2), stating
rogfer01 added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
My understanding is that, given that we support TS18661-2 by default, this
macro should be predefined by
scanon added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
rogfer01 wrote:
> My understanding is that, given that we support TS18661-2 by default, this
> macro shoul
JonasToth updated this revision to Diff 114848.
JonasToth added a comment.
- address review comments, especially improve diagnostic for return types, that
should be owner but arent
https://reviews.llvm.org/D36354
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelin
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:2376
+/// \brief Tests if the __interface base is public.
+static bool IsDeclPublicInterface(const CXXRecordDecl *RD,
The comment does not match the behavior of the function.
==
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with a few last typos.
Comment at: test/clang-tidy/cppcoreguidelines-owning-memory.cpp:354
+
+// FIXME: Same typededcution problems
+template
---
JonasToth updated this revision to Diff 114849.
JonasToth added a comment.
- fix typos
https://reviews.llvm.org/D36354
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp
clang
rogfer01 added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
scanon wrote:
> rogfer01 wrote:
> > My understanding is that, given that we support TS18661-2 by default,
scanon added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
rogfer01 wrote:
> scanon wrote:
> > rogfer01 wrote:
> > > My understanding is that, given that we support T
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM generally, apart from I am not sure why address spaces are only tested for
atomic stores...
https://reviews.llvm.org/D37742
___
cfe-c
SjoerdMeijer added inline comments.
Comment at: lib/Headers/float.h:137
+#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__
+# define FLT16_MANT_DIG __FLT16_MANT_DIG__
scanon wrote:
> rogfer01 wrote:
> > scanon wrote:
> > > rogfer01 wrote:
> > > > My understanding is t
JonasToth updated this revision to Diff 114851.
JonasToth added a comment.
- fix, that deleted destructors are caught as problem as well
- clarify one comment, duplicated avoid was misleading
https://reviews.llvm.org/D36354
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppco
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Good catch on the deleted constructor -- LGTM still!
https://reviews.llvm.org/D36354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: jonastoth
Date: Tue Sep 12 09:20:51 2017
New Revision: 313043
URL: http://llvm.org/viewvc/llvm-project?rev=313043&view=rev
Log:
[clang-tidy] Implement type-based check for `gsl::owner`
This check implements the typebased semantic of `gsl::owner`.
Meaning, that
- only `gsl::owner` is allo
lebedev.ri added a comment.
In https://reviews.llvm.org/D33826#868085, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33826#866170, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D33826#866161, @JonasToth wrote:
> >
> > > There is an exception to the general rule (EXP36-C-EX2), statin
JonasToth added a comment.
commited in https://reviews.llvm.org/rL313043
https://reviews.llvm.org/D36354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D33826#868167, @lebedev.ri wrote:
> In https://reviews.llvm.org/D33826#868085, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D33826#866170, @lebedev.ri wrote:
> >
> > > In https://reviews.llvm.org/D33826#866161, @JonasToth wrote
RKSimon added a comment.
some very minor whitespace/indentation issues
please can you confirm @craig.topper's query about
__builtin_ia32_pbroadcastq512_mem_mask
Comment at: lib/Headers/avx512vlintrin.h:5727
+static __inline__ __m128i __DEFAULT_FN_ATTRS
+ _mm_mask_set1_epi32(
rwols added a comment.
Thanks! Thinking ahead now so we're on the same page, you will be implementing
the client's initialize request, and I'll start work on
textDocument/signatureHelp.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
Author: teemperor
Date: Tue Sep 12 09:54:53 2017
New Revision: 313049
URL: http://llvm.org/viewvc/llvm-project?rev=313049&view=rev
Log:
Use the VFS from the CompilerInvocation by default
Summary:
The CompilerInstance should create its default VFS from its CompilerInvocation.
Right now the
user h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313049: Use the VFS from the CompilerInvocation by default
(authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D37416?vs=114823&id=114857#toc
Repository:
rL LLVM
https://revie
lebedev.ri added a comment.
In https://reviews.llvm.org/D33826#868185, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33826#868167, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D33826#868085, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D33826#866170, @lebedev.ri wrot
On Tue, Sep 12, 2017 at 1:02 PM, Roman Lebedev via Phabricator
wrote:
> lebedev.ri added a comment.
>
> In https://reviews.llvm.org/D33826#868185, @aaron.ballman wrote:
>
>> In https://reviews.llvm.org/D33826#868167, @lebedev.ri wrote:
>>
>> > In https://reviews.llvm.org/D33826#868085, @aaron.ball
lebedev.ri updated this revision to Diff 114861.
lebedev.ri added a comment.
Aaaand revert back to dump approach with code duplication as requested :)
(For the second part of the fix in another differential, if the reverted
approach with struct turns out to be better, i guess i will use it)
Re
Author: marshall
Date: Tue Sep 12 10:56:59 2017
New Revision: 313056
URL: http://llvm.org/viewvc/llvm-project?rev=313056&view=rev
Log:
Apply D28224: 'Throw exception after too many steps' Fixes PR#20291. Thanks to
Tim Shen for the patch
Added:
libcxx/trunk/test/std/re/re.alg/re.alg.match/exp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Nice! IIUC, now that the gnu ld driver works on Windows we can remove this
logic. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D37727
___
c
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Applied as revision 313056 (with minor editing)
https://reviews.llvm.org/D28224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:617
+return;
+ } else if (Res->isRValue()) {
+bool Enum = isa(T) && Res->EvaluateAsRValue(Eval,
Context);
RKSimon wrote:
> (style) Split these instead of an if-elseif chain
LLVM suggests ea
lebedev.ri added a comment.
In https://reviews.llvm.org/D33826#868185, @aaron.ballman wrote:
> Ah, I think I'm catching on to the point you're raising (thank you for
> the patience). If the return type is void *, we don't have enough
> information to sensibly diagnose (not without data flow ana
hfinkel added a comment.
In https://reviews.llvm.org/D37436#867965, @aaron.ballman wrote:
> In https://reviews.llvm.org/D37436#867287, @rsmith wrote:
>
> > If this is just supposed to be an experiment to get feedback on the
> > feature, then I don't think we should be treating it as a different
Hello Yael,
It looks like this commit broke one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/17121
. . .
Failing Tests (1):
Clang :: Modules/builtins.m
Please have a look?
Thanks
Galina
On Tue, Sep 12, 2017 at 12:46 AM, Yael Tsafrir
JonasToth reopened this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
This Patch broke the buildbot for vs-2015.
I will revert, when i figured out how to do this in svn :/
It does not emit a warning for line 311:
here the log
> C:\b\slave\clang-x86-windows
vivekvpandya added a comment.
Why? That was inside BackendConsumer.
I was getting incomplete type error.
You can just save the old DiagHandler object instead.
I don't think now we need to do that as per my understanding CodeGen i.e
emitting LLVM IR is last phase in clang which will pass control
vivekvpandya updated this revision to Diff 114869.
vivekvpandya marked 3 inline comments as done.
vivekvpandya added a comment.
Update.
https://reviews.llvm.org/D33514
Files:
include/llvm/Analysis/OptimizationDiagnosticInfo.h
include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h
include
aaron.ballman added a comment.
In https://reviews.llvm.org/D37436#868295, @hfinkel wrote:
> In https://reviews.llvm.org/D37436#867965, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D37436#867287, @rsmith wrote:
> >
> > > If this is just supposed to be an experiment to get feedback on th
Author: jonastoth
Date: Tue Sep 12 11:35:54 2017
New Revision: 313059
URL: http://llvm.org/viewvc/llvm-project?rev=313059&view=rev
Log:
[clang-tidy] Revert Implement type-based check for gsl::owner
This should unbreak the buildbot for visual studio 2015 for now.
Removed:
clang-tools-extra/tr
Author: hans
Date: Tue Sep 12 11:38:34 2017
New Revision: 313060
URL: http://llvm.org/viewvc/llvm-project?rev=313060&view=rev
Log:
clang-format-vs: Update the VSIX ID.
We're moving the extension to a new account on the VS Marketplace, and
apparently it's not possible to re-upload an extension wit
1 - 100 of 189 matches
Mail list logo
