Author: rsmith
Date: Mon Oct 10 01:55:42 2016
New Revision: 283724
URL: http://llvm.org/viewvc/llvm-project?rev=283724&view=rev
Log:
Mark aligned allocation as done.
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor.cpp
cfe/trunk/test/Lexer/cxx-features.cpp
cfe/trunk/www/cxx_status.ht
coby closed this revision.
coby added a comment.
Commitd to revision 283716
https://reviews.llvm.org/D25004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek added a comment.
I have submitted the same change https://reviews.llvm.org/D25256 a few days ago
but this one seems to be getting more traction so I'm going to abandon mine in
favor of this one.
Comment at: lib/Driver/Driver.cpp:1000
+case ToolChain::RLT_CompilerRT
phosek abandoned this revision.
phosek added a comment.
Michał Górny has submitted the same change as https://reviews.llvm.org/D25338
and his change seems to be getting more traction.
Repository:
rL LLVM
https://reviews.llvm.org/D25256
___
cfe-c
danielmarjamaki added inline comments.
Comment at: test/Analysis/unreachable-code-path.c:201
+static int inlineFunction(const int i) {
+ if (table[i] != 0)
+return 1;
NoQ wrote:
> a.sidorin wrote:
> > I have a small question. Is it possible to simplify this
Author: danielmarjamaki
Date: Mon Oct 10 02:39:39 2016
New Revision: 283725
URL: http://llvm.org/viewvc/llvm-project?rev=283725&view=rev
Log:
Fix style issue. Spaces in argument list.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
Modified: cfe/trunk/include
danielmarjamaki added a comment.
In https://reviews.llvm.org/D25326#564584, @zaks.anna wrote:
> Please, fix the style issues before committing.
Sorry I missed that.
Ideally it would be possible to run clang-format on the files before
committing. but currently I get lots of unrelated changes t
EricWF added a comment.
Is this *all* that's needed to get libc++ working?
Repository:
rL LLVM
https://reviews.llvm.org/D25414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
In https://reviews.llvm.org/D25326#565919, @danielmarjamaki wrote:
> Ideally it would be possible to run clang-format on the files before
> committing. but currently I get lots of unrelated changes then.
>
> Would it be ok to run clang-format on some files to clean up the fo
ABataev added a comment.
I think the fix is not quite correct. I believe it's better to replace a call
of getVariableArrayDecayedType() in CGStmtOpenMP.cpp by a call to
getCanonicalParamType(). Try to replace it and check the result.
Repository:
rL LLVM
https://reviews.llvm.org/D25373
__
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin, alexfh.
NoQ added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
ASTMatchers are sometimes handy in the Analyzer, and there are more patches to
make use of them.
However, it turns out
xazax.hun added a comment.
I might be confused, but as far as I remember, when you do static linking,
symbols tend to be linked in lazily. So as long as you do not use the matchers,
those numbers might be misleading.
https://reviews.llvm.org/D25429
__
NoQ added a comment.
In https://reviews.llvm.org/D25429#565939, @xazax.hun wrote:
> I might be confused, but as far as I remember, when you do static linking,
> symbols tend to be linked in lazily. So as long as you do not use the
> matchers, those numbers might be misleading.
Yep, i did actu
xazax.hun added a comment.
In https://reviews.llvm.org/D25429#565940, @NoQ wrote:
> In https://reviews.llvm.org/D25429#565939, @xazax.hun wrote:
>
> > I might be confused, but as far as I remember, when you do static linking,
> > symbols tend to be linked in lazily. So as long as you do not use
phosek added a comment.
Currently yes, we've been using libc++ (and libc++abi which doesn't need any
changes) for a few months now without any problems. Our C library is a fork of
musl so we rely on all the changes that have already been done to support it.
However, we're building libc++ with `
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Cool! This patch LGTM then.
> we're slowly diverging from the upstream version so it might be better to
> stop relying on that option. I'd have to copy include/support/musl/xlocale.h
> to inc
EricWF added a comment.
PS. If your not already locked into an ABI you'll want to look into enabling
the most recent ABI breaking changes. See the `_LIBCPP_ABI_VERSION`
configuration at the top of `__config` for more info.
Repository:
rL LLVM
https://reviews.llvm.org/D25414
_
phosek added a comment.
> That sounds fine.
Shall I send it as a separate patch or update this one?
> PS. If your not already locked into an ABI you'll want to look into enabling
> the most recent ABI breaking changes. See the `_LIBCPP_ABI_VERSION`
> configuration at the top of `__config` for
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with some nits
Comment at: lib/CodeGen/CGBuiltin.cpp:7592
Value *LHS = EmitScalarExpr(E->getArg(0));
Value *RHS = EmitScalarExpr(E->getArg(1));
llvm::Type *Re
timshen added inline comments.
Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106
for (auto &CDSConstant : CDSConstants)
delete CDSConstant.second;
CDSConstants.clear();
Do you want to change this one as well?
https://reviews.llvm.org/D25419
Author: asiri
Date: Mon Oct 10 03:38:51 2016
New Revision: 283726
URL: http://llvm.org/viewvc/llvm-project?rev=283726&view=rev
Log:
[libcxx] Add the missing limits.h header
The implementation of [depr.c.headers] in D12747 introduced the necessary
C headers into libc++. This patch adds one more mi
rmaprath closed this revision.
rmaprath added a comment.
Thanks.
Committed as r283726.
https://reviews.llvm.org/D25361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen accepted this revision.
timshen added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Sema/Sema.h:879
/// do not have lambda expressions or block literals.
-IntrusiveRefCntPtr MangleNumbering;
+std::unique_ptr
timshen added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:514
+ MutableArrayRef> Callbacks)
+ : Overloads(std::make_move_iterator(Callbacks.begin()),
+ std::make_move_iterator(Callbacks.end())) {}
Notice tha
timshen added inline comments.
Comment at: clang/include/clang/Analysis/CallGraph.h:204
+ static clang::CallGraphNode *
+ CGGetValue(decltype(*std::declval()) &P) {
+return P.second.get();
Does clang::CallGraph::const_iterator::value_type work?
https://re
EricWF created this revision.
EricWF added reviewers: rsmith, majnemer, aaron.ballman.
EricWF added a subscriber: cfe-commits.
Once a base class has been made invalid (by a static_assert for example) all
using-member declarations in the derived classes will result in a "not a base
class" diagnos
EricWF added a comment.
In https://reviews.llvm.org/D25414#565956, @phosek wrote:
> > That sounds fine.
>
> Shall I send it as a separate patch or update this one?
I would send a separate patch. This one is already good to go so you might as
well commit it.
>
>
>> PS. If your not already lo
EricWF updated this revision to Diff 74112.
EricWF added a comment.
Simplify test case.
https://reviews.llvm.org/D25430
Files:
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/using-decl-templates.cpp
Index: test/SemaCXX/using-decl-templates.cpp
==
mgorny updated this revision to Diff 74111.
mgorny added a comment.
Updated to use TC.getCompilerRT().
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/montavista-gcc-toolchain.c
test/Driver/print-libg
mgorny added inline comments.
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform
default")
Is there a reason not to allow using the absolute path here, like for
mgorny added a comment.
In https://reviews.llvm.org/D25402#565557, @joerg wrote:
> No, they are not desirable, in fact, they pretty much break clang. That's why
> I wanted to see the test diff...
Thank you for your feedback. However, I would really appreciate if you kindly
said what you meant
On 9 October 2016 at 22:45, Eric Fiselier wrote:
> Hi Renato, Hal,
>
> I've hopefully fixed this in r283700. I'll be watching the bots to ensure
> everything works.
All green, thanks! :)
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: klimek
Date: Mon Oct 10 05:22:40 2016
New Revision: 283736
URL: http://llvm.org/viewvc/llvm-project?rev=283736&view=rev
Log:
Use `let' instead of `let*' in one place where `let*' isn't necessary
Differential Revision: https://reviews.llvm.org/D25395
Patch by Philipp Stephani.
Modified:
mgorny retitled this revision from "[Driver] Pass -lunwind when using libc++ +
compiler-rt" to "[Driver] Pass -lunwind when using libc++ + compiler-rt on
Linux".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74115.
https://reviews.llvm.org/D25402
Files:
li
mgorny added a comment.
I've updated the patch to apply to Linux toolchain only.
https://reviews.llvm.org/D25402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons updated this revision to Diff 74117.
malcolm.parsons added a comment.
Ensure SourceRange is initialized
https://reviews.llvm.org/D25363
Files:
include/clang/AST/TypeLoc.h
include/clang/Sema/DeclSpec.h
lib/Sema/DeclSpec.cpp
lib/Sema/SemaType.cpp
Index: lib/Sema/SemaType.
dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.
Sorry, I forgot to update the status. I made a few more comments to make this
part a little more readable.
https://reviews.llvm.org/D24799
_
joerg added a comment.
It's difficult to say whether if one change to certain driver functions affect
some target or not. That's one reason why the test change is so important.
Looking at the latest version, I still don't understand why the change for
Linux is needed. libc++ should provide a li
Hi,
On Mon, Oct 10, 2016 at 8:45 AM, Michael Zuckerman via cfe-commits
wrote:
> Author: mzuckerm
> Date: Mon Oct 10 00:45:54 2016
> New Revision: 283716
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283716&view=rev
> Log:
> [x86][inline-asm][clang] accept 'v' constraint
>
> Commit in the name
Author: djasper
Date: Mon Oct 10 06:40:28 2016
New Revision: 283743
URL: http://llvm.org/viewvc/llvm-project?rev=283743&view=rev
Log:
Revert "[x86][inline-asm][clang] accept 'v' constraint"
This reverts commit r283716.
Breaks buildbot:
http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rl
I have reverted this in r283743 for now.
On Mon, Oct 10, 2016 at 1:43 PM, Ismail Donmez via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> On Mon, Oct 10, 2016 at 8:45 AM, Michael Zuckerman via cfe-commits
> wrote:
> > Author: mzuckerm
> > Date: Mon Oct 10 00:45:54 2016
> > New Revis
mgorny added a comment.
In https://reviews.llvm.org/D25402#566070, @joerg wrote:
> It's difficult to say whether if one change to certain driver functions
> affect some target or not. That's one reason why the test change is so
> important.
>
> Looking at the latest version, I still don't under
ggreif accepted this revision.
ggreif added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: mgorny
Date: Mon Oct 10 07:23:40 2016
New Revision: 283746
URL: http://llvm.org/viewvc/llvm-project?rev=283746&view=rev
Log:
[Driver] Make -print-libgcc-file-name print compiler-rt lib when used
Make the -print-libgcc-file-name option print an appropriate compiler
runtime library, that is
mgorny added a comment.
Thanks for the review.
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks ,
We will check it.
From: Daniel Jasper [mailto:djas...@google.com]
Sent: Monday, October 10, 2016 14:50
To: Ismail Donmez
Cc: Zuckerman, Michael ; cfe-commits
Subject: Re: r283716 - [x86][inline-asm][clang] accept 'v' constraint
I have reverted this in r283743 for now.
On Mon, Oct 10,
mgorny created this revision.
mgorny added reviewers: EricWF, theraven.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: beanz.
Build the Solaris compatibility code (C) as a separate static library
rather than appending it to libc++ sources, in order to prevent
the -std=c++11 fla
theraven added a comment.
It sounds as if the bug here is either that the .c files are being treated as
c++, or that we're sticking -std=c++{whatever} in CFLAGS as well as CXXFLAGS.
This is probably the bug that should be fixed.
https://reviews.llvm.org/D25431
_
mgorny added a comment.
In https://reviews.llvm.org/D25431#566096, @theraven wrote:
> It sounds as if the bug here is either that the .c files are being treated as
> c++, or that we're sticking -std=c++{whatever} in CFLAGS as well as CXXFLAGS.
> This is probably the bug that should be fixed.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with one small commenting nit.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:320
+// copied from clang/lib/Sema/SemaDeclCXX.cpp
+s
vbyakovlcl updated this revision to Diff 74123.
https://reviews.llvm.org/D24669
Files:
llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/CodeGen/vecshift.c
llvm/tools/clang/test/Sema/vecshift.c
Index: llvm/tools/clang
vbyakovlcl added inline comments.
Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td:2306
+ "vector operands do not have the same elements sizes (%0 and %1)">,
+ InGroup>, DefaultError;
def err_ext_vector_component_exceeds_length : Error<
malcolm.parsons updated this revision to Diff 74124.
malcolm.parsons added a comment.
Add unit tests
https://reviews.llvm.org/D25363
Files:
include/clang/AST/TypeLoc.h
include/clang/Sema/DeclSpec.h
lib/Sema/DeclSpec.cpp
lib/Sema/SemaType.cpp
unittests/AST/SourceLocationTest.cpp
Index
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: include/clang/Sema/Sema.h:9747
+ AvailabilityResult ShouldDiagnoseAvailabilityOfDecl(NamedDecl *&D,
+ std::string *Message);
---
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Sema/SemaDeclAttr.cpp:3011
const AttributeList &Attr) {
+ if (S.getLangOpts().CPlusPlus)
malcolm.parsons updated this revision to Diff 74125.
malcolm.parsons added a comment.
Mark comment as FIXME.
https://reviews.llvm.org/D25238
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp
Index: test/clang-tidy/cpp
aaron.ballman added a comment.
In https://reviews.llvm.org/D20428#564511, @sbarzowski wrote:
> What's happening here? It's accepted, but not merged and the last activity is
> 3 months old while my change is waiting for it. Can I help somehow?
It was accepted, but then caused build failures. I
sebpop added a comment.
In https://reviews.llvm.org/D24991#565861, @EricWF wrote:
> Please provide benchmark tests which demonstrate that these benefits are
> concrete and not just "potential". Moving methods out of the dylib is no
> easy task so I would like hard evidence that it's worth whil
EricWF added a comment.
In https://reviews.llvm.org/D24991#566140, @sebpop wrote:
> In https://reviews.llvm.org/D24991#565861, @EricWF wrote:
>
> > Please provide benchmark tests which demonstrate that these benefits are
> > concrete and not just "potential". Moving methods out of the dylib is
Author: nico
Date: Mon Oct 10 09:10:00 2016
New Revision: 283747
URL: http://llvm.org/viewvc/llvm-project?rev=283747&view=rev
Log:
Revert r283680.
Breaks bootstrap builds on (at least) Windows:
In file included from
D:\buildslave\clang-x64-ninja-win7\llvm\lib\Support\Allocator.cpp:14:
In file in
This broke bootstrap builds, I reverted it for now in r283747.
On Sat, Oct 8, 2016 at 6:16 PM, Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jlebar
> Date: Sat Oct 8 17:16:12 2016
> New Revision: 283680
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283680&view=re
Author: marshall
Date: Mon Oct 10 09:10:45 2016
New Revision: 283749
URL: http://llvm.org/viewvc/llvm-project?rev=283749&view=rev
Log:
Add tests for LWG2544. We already implement this; just adding tests to make
sure that we keep doing it.
Modified:
libcxx/trunk/test/std/iterators/stream.ite
Author: marshall
Date: Mon Oct 10 09:15:56 2016
New Revision: 283752
URL: http://llvm.org/viewvc/llvm-project?rev=283752&view=rev
Log:
Mark issues 2544, 2567, 2569, 2686 and 2694 as ready/done.
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:346
-const auto *NewExpr =
cast(V->getInit()->IgnoreParenImpCasts());
-// Ensure that every VarDecl has a CXXNewExpr initializer.
-if (!NewExpr)
+const auto *Expr = cast(V->g
Author: nico
Date: Mon Oct 10 09:20:35 2016
New Revision: 283753
URL: http://llvm.org/viewvc/llvm-project?rev=283753&view=rev
Log:
Revert r283683 because r283680 got reverted.
Modified:
cfe/trunk/lib/Headers/CMakeLists.txt
Modified: cfe/trunk/lib/Headers/CMakeLists.txt
URL:
http://llvm.org/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
On 10 October 2016 at 15:20, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Mon Oct 10 09:20:35 2016
> New Revision: 283753
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283753&view=rev
> Log:
> Revert r283683 because r283680 got reverted.
Great commit message! :D
___
Author: ericwf
Date: Mon Oct 10 09:26:40 2016
New Revision: 283755
URL: http://llvm.org/viewvc/llvm-project?rev=283755&view=rev
Log:
[Sema] Prevent using member declaration diagnostic if the base class is invalid.
Summary:
Once a base class has been made invalid (by a static_assert for example) a
EricWF added a comment.
Thanks @aaron.ballman!
https://reviews.llvm.org/D25430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon Oct 10 09:21:55 2016
New Revision: 283754
URL: http://llvm.org/viewvc/llvm-project?rev=283754&view=rev
Log:
[include-fixer] query-mode should be false by default.
Makes it consistent with documentations.
Modified:
clang-tools-extra/trunk/include-fixer/tool/clang-incl
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
Oye, th
Author: marshall
Date: Mon Oct 10 09:37:18 2016
New Revision: 283757
URL: http://llvm.org/viewvc/llvm-project?rev=283757&view=rev
Log:
Add whitespace to make not_fn_impl more clear. NFC.
Modified:
libcxx/trunk/include/functional
Modified: libcxx/trunk/include/functional
URL:
http://llvm.org
Author: ericwf
Date: Mon Oct 10 09:45:06 2016
New Revision: 283759
URL: http://llvm.org/viewvc/llvm-project?rev=283759&view=rev
Log:
Fix documentation mis-spelling.
I promise to stop misspelling things when the English language gains a program
that does strict semantic checking.
Modified:
li
arphaman updated this revision to Diff 74127.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch uses a proper way to mark the attribute as C only.
Repository:
rL LLVM
https://reviews.llvm.org/D25308
Files:
include/clang/Basic/Attr.td
test/SemaCXX/attr
arphaman added a comment.
The updated patch now makes clang warn every time it encounters this attribute
in C++ mode. Would that be the desired behaviour?
Repository:
rL LLVM
https://reviews.llvm.org/D25308
___
cfe-commits mailing list
cfe-commi
v.g.vassilev updated this revision to Diff 74129.
v.g.vassilev marked 3 inline comments as done.
v.g.vassilev added a comment.
Address comments.
https://reviews.llvm.org/D24508
Files:
include/clang/AST/Decl.h
lib/AST/Decl.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaTemplate.cpp
lib/Sema/Se
mclow.lists added a comment.
@EricWF > Cool! This patch LGTM then.
This looks fine to me, too.
Repository:
rL LLVM
https://reviews.llvm.org/D25414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:346
-const auto *NewExpr =
cast(V->getInit()->IgnoreParenImpCasts());
-// Ensure that every VarDecl has a CXXNewExpr initializer.
-if (!NewExpr)
+const auto *Expr = cast(V-
dcoughlin added inline comments.
Comment at: test/Analysis/unreachable-code-path.c:201
+static int inlineFunction(const int i) {
+ if (table[i] != 0)
+return 1;
danielmarjamaki wrote:
> NoQ wrote:
> > a.sidorin wrote:
> > > I have a small question. Is it pos
Thanks. I should have done that a while ago.
On Mon, Oct 10, 2016 at 8:37 AM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Oct 10 09:37:18 2016
> New Revision: 283757
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283757&view=rev
> Log:
> Add
mclow.lists added a comment.
I think we've got most of this now. Do we still need this patch?
https://reviews.llvm.org/D21706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons updated this revision to Diff 74131.
malcolm.parsons added a comment.
Only insert whitespace when removing stars
https://reviews.llvm.org/D25406
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
test/clang-tidy/modernize-use-auto-new-remove-s
dcoughlin added a comment.
In https://reviews.llvm.org/D25326#565919, @danielmarjamaki wrote:
> In https://reviews.llvm.org/D25326#564584, @zaks.anna wrote:
>
> > Please, fix the style issues before committing.
>
>
> Would it be ok to run clang-format on some files to clean up the formatting?
>
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
aaron
malcolm.parsons updated this revision to Diff 74134.
malcolm.parsons added a comment.
Fix ast matcher
Add test
Fix parameter case
Inline lambdas
Doc fixes
https://reviews.llvm.org/D25316
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/clang-tidy/check
As discussed over IM, builds are still failing after reverting this.
The issue seems to be that the stage 1 build in bootstrap compiles is
not a clean build. Therefore the errant and
headers are never removed from the install directory.
I believe I fixed the cmake in r283683 (sent a few hours
jlebar marked 2 inline comments as done.
jlebar added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:514
+ MutableArrayRef> Callbacks)
+ : Overloads(std::make_move_iterator(Callbacks.begin()),
+ std::make_move_iterator(Callback
Author: asiri
Date: Mon Oct 10 10:56:01 2016
New Revision: 283762
URL: http://llvm.org/viewvc/llvm-project?rev=283762&view=rev
Log:
[libcxx] Fix gcc build.
Attempt to fix a horrible gcc include order problem.
Modified:
libcxx/trunk/include/limits.h
Modified: libcxx/trunk/include/limits.h
UR
jlebar marked an inline comment as done.
jlebar added inline comments.
Comment at: clang/include/clang/Analysis/CallGraph.h:204
+ static clang::CallGraphNode *
+ CGGetValue(decltype(*std::declval()) &P) {
+return P.second.get();
timshen wrote:
> Does clang:
erichkeane added a comment.
Andrey-
It seems that getVariableArrayDecayedType and getCanonicalParamType return the
same type in this case (at least in the reproduction). I could definitely
change the call, though the changes to CGDebugInfo.cpp are apparently also
necessary even in that case.
jlebar marked an inline comment as done.
jlebar added inline comments.
Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106
for (auto &CDSConstant : CDSConstants)
delete CDSConstant.second;
CDSConstants.clear();
timshen wrote:
> Do you want to change this o
jlebar added inline comments.
Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106
for (auto &CDSConstant : CDSConstants)
delete CDSConstant.second;
CDSConstants.clear();
jlebar wrote:
> timshen wrote:
> > Do you want to change this one as well?
> Sure, but
bruno accepted this revision.
bruno added a comment.
LGTM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Mon Oct 10 11:26:08 2016
New Revision: 283766
URL: http://llvm.org/viewvc/llvm-project?rev=283766&view=rev
Log:
[Sema] Use unique_ptr instead of raw pointers in the late-parsed templates map.
Summary:
This is possible now that MapVector supports move-only values.
Depends on
Author: jlebar
Date: Mon Oct 10 11:26:19 2016
New Revision: 283768
URL: http://llvm.org/viewvc/llvm-project?rev=283768&view=rev
Log:
[AST] Convert MangleNumberingContext to a unique_ptr.
Summary: It doesn't need to be refcounted anymore, either.
Reviewers: timshen
Subscribers: cfe-commits
Diff
malcolm.parsons marked 15 inline comments as done.
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/modernize-use-auto-cast.cpp:14
+ long l = 1;
+ int i1 = static_cast(l);
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use auto when initializing with
a cast t
Author: jlebar
Date: Mon Oct 10 11:26:33 2016
New Revision: 283771
URL: http://llvm.org/viewvc/llvm-project?rev=283771&view=rev
Log:
Use unique_ptr for VTableBuilder::VFTableLayouts map.
Reviewers: timshen
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25423
Modified
Author: jlebar
Date: Mon Oct 10 11:26:24 2016
New Revision: 283769
URL: http://llvm.org/viewvc/llvm-project?rev=283769&view=rev
Log:
[AST] Use unique_ptr for VTableLayout.
Reviewers: timshen
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25421
Modified:
cfe/trunk
Author: jlebar
Date: Mon Oct 10 11:26:40 2016
New Revision: 283773
URL: http://llvm.org/viewvc/llvm-project?rev=283773&view=rev
Log:
[AST] Convert Marshallers to use unique_ptr.
Reviewers: timshen
Subscribers: cfe-commits, klimek
Differential Revision: https://reviews.llvm.org/D25425
Modified:
1 - 100 of 233 matches
Mail list logo
