EricWF added a comment.

In https://reviews.llvm.org/D25414#565956, @phosek wrote:

> > That sounds fine.
>
> Shall I send it as a separate patch or update this one?


I would send a separate patch. This one is already good to go so you might as 
well commit it.

> 
> 
>> PS. If your not already locked into an ABI you'll want to look into enabling 
>> the most recent ABI breaking changes. See the `_LIBCPP_ABI_VERSION` 
>> configuration at the top of `__config` for more info.
> 
> We're already defaulting to `LIBCXX_ABI_VERSION=2`, I figured that's what we 
> want to be using.

Great! Just be aware that ABI v2 is not yet stable. We're just staging it for 
later.


Repository:
  rL LLVM

https://reviews.llvm.org/D25414



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to