aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, with one small commenting nit.



================
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:320
 
+// copied from clang/lib/Sema/SemaDeclCXX.cpp
+static bool isIncompleteOrZeroLengthArrayType(ASTContext &Context, QualType T) 
{
----------------
Comments should be complete sentences (capitalization, punctuation, etc), 
however, I'm not certain that this comment adds value as is. I would mark it a 
FIXME because copy-paste code is bad.


https://reviews.llvm.org/D25238



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to