D24761: Asign correct column width when importing XLS file

davidllewellynjones created this revision. davidllewellynjones added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. davidllewellynjones requested review of this revision. REVISION SUMMARY When importing an Excel 97-2003 .xls file (using the excel importer) the column

D24761: Asign correct column width when importing XLS file

davidllewellynjones added reviewers: Calligra: 3.0, pvuorela. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24761 To: davidllewellynjones, #calligra:_3.0, pvuorela Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24761: Asign correct column width when importing XLS file

davidllewellynjones edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24761 To: davidllewellynjones, #calligra:_3.0, pvuorela Cc: davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24943: Better charset, unicode and image support for RTF files

davidllewellynjones accepted this revision. davidllewellynjones added a comment. This revision is now accepted and ready to land. I've made some suggestions and have a couple of queries, but they're all very minor. INLINE COMMENTS > DocumentDestination.cpp:125 > + m_charactersToSkip

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

davidllewellynjones created this revision. davidllewellynjones added reviewers: Calligra: 3.0, pvuorela, dcaliste. davidllewellynjones added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. davidllewellynjones requested review of this revision. REVISION SUMMARY Loading l

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

davidllewellynjones updated this revision to Diff 68954. davidllewellynjones added a comment. Thanks @dcaliste, this is an excellent suggestion and much better naming. I've updated the diff to make the changes you suggested. - MSOOXML_IMPORT_READ_ONLY -> MSOOXML_IMPORT_BY_VALUES - MSOOX

D24761: Asign correct column width when importing XLS file

davidllewellynjones updated this revision to Diff 68959. davidllewellynjones added a comment. Thanks here also @dcaliste. This is all a bit confusing I agree and deserves some explanation. I've added in something along the lines you suggested, which I think helps (your insight that the scalin

D24943: Better charset, unicode and image support for RTF files

davidllewellynjones added inline comments. INLINE COMMENTS > PictDestination.cpp:101 > +} > +} > + The logic is confusing me here I'm afraid. If there's no `\picwgoal` control word, then `m_goalWidth` will default to 0 and the code above will be skipped. The image w

D24943: Better charset, unicode and image support for RTF files

davidllewellynjones accepted this revision. davidllewellynjones added a comment. This looks like a nice and useful collection of changes to me. REPOSITORY R8 Calligra BRANCH unicode REVISION DETAIL https://phabricator.kde.org/D24943 To: pvuorela, davidllewellynjones Cc: denexter, davi

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

davidllewellynjones added inline comments. INLINE COMMENTS > anthonyfieroni wrote in CMakeLists.txt:124-129 > Why 2 times? That's a very good question; nicely noticed. I'll update the patch to remove one. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25008 To: david

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

davidllewellynjones updated this revision to Diff 69054. davidllewellynjones added a comment. Remove duplicated cmake definition. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25008?vs=68954&id=69054 REVISION DETAIL https://phabricator.kde.org/D25008 AF

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

davidllewellynjones marked 2 inline comments as done. davidllewellynjones added inline comments. INLINE COMMENTS > anthonyfieroni wrote in CMakeLists.txt:124-129 > Why 2 times? Thanks again, I've removed the duplication now. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.or

D25256: Allow non-conforming LibreOffice PPT files to be imported

davidllewellynjones created this revision. davidllewellynjones added reviewers: pvuorela, dcaliste. davidllewellynjones added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. davidllewellynjones requested review of this revision. REVISION SUMMARY An apparent bug in the L

D25256: Allow non-conforming LibreOffice PPT files to be imported

davidllewellynjones added a comment. Here's the corresponding patch for binschema: https://github.com/KDE/binschema/pull/1 REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25256 To: davidllewellynjones, pvuorela, dcaliste Cc: Calligra-Devel-list, davidllewellynjones,

D25256: Relax TextPFRun validation to allow LibreOffice PPT import

davidllewellynjones updated this revision to Diff 70039. davidllewellynjones retitled this revision from "Allow non-conforming LibreOffice PPT files to be imported" to "Relax TextPFRun validation to allow LibreOffice PPT import". davidllewellynjones edited the summary of this revision. davidllewe

D25256: Relax TextPFRun validation to allow LibreOffice PPT import

davidllewellynjones updated this revision to Diff 70040. davidllewellynjones added a comment. 1. Updating D25256 : Relax TextPFRun validation to allow LibreOffice PPT import # 2. Enter a brief description of the changes included in this update. 3.

D25256: Relax TextPFRun validation to allow LibreOffice PPT import

davidllewellynjones updated this revision to Diff 70041. davidllewellynjones edited the summary of this revision. davidllewellynjones added a comment. 1. Updating D25256 : Relax TextPFRun validation to allow LibreOffice PPT import # 2. Enter a brief

D25715: Use RTF default color as default Qt format

davidllewellynjones added inline comments. INLINE COMMENTS > ColorTableDestination.cpp:44 > + handled = false; > qCDebug(lcRtf) << "unexpected control word in colortbl:" << > controlWord; > } It looks like there may be a distinction to be made between an empty control

D25715: Use RTF default color as default Qt format

davidllewellynjones accepted this revision. davidllewellynjones added a comment. This revision is now accepted and ready to land. This looks good to me, and certainly gave better results for me using files with the 'auto' colour. INLINE COMMENTS > pvuorela wrote in ColorTableDestination.cpp:

D27694: Don't recreate ImageDataItem texture unless needed

davidllewellynjones created this revision. davidllewellynjones added reviewers: Calligra: 3.0, leinir, danders. davidllewellynjones added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. davidllewellynjones requested review of this revision. REVISION SUMMARY Submitting o

T12815: Create Calligra Framework by separating out applications and libraries

davidllewellynjones added a comment. As a newcomer, and only occasional contributor, my experience of getting the build up and running is that it's already a daunting process, made tractable only because the instructions are very good. Anything