Steven wrote:
> You have mixed up core changes like inlining ReadTwoBytes
> with the bestgames feature change. These should be in separate patches, not 
> together. Large patches like this should have 
> documentation about wtf they do. Ditto the Storedline changes.
> You've removed the button bar. Congratulations...
> but this should be totally separate otherwise you're wasting 
> the time of everyone who reviews this patch.
> Sorry for being so blunt, and perhaps i am also out of line.
>   
At some point during the discussion on tree & filter in the mailing 
list  i had the impression that there was some semantic misunderstandings.
So I sent a screenshot and a cvs diff to my current code to avoid any 
language problem.
I know it's difficult to look at a patch that do so many different 
things, but my intention was only to give the ability to try the new 
behavior of the tree window.
Bye,
Fulvio

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Scid-users mailing list
Scid-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scid-users

Reply via email to