@coderabbitai[bot] commented on this pull request.
> +rpmuncompress "${source}" | cmp - "${source}"
+if rpmuncompress --package ${RPMTEST}/data/SPECS/aligntest.spec \
+ > ${RPMTEST}/tmp/aligntest-notpkg.log 2>&1; then
+ exit 1
+fi
+grep -q 'not an rpm package' ${RPMTEST}/tmp/aligntest-notpkg.log
+
+rpmuncompress --package "${source}" > ${RPMTEST}/build/aligntest-converted.rpm
`@daandemeyer`, understood. The direct calls intentionally compare host-tool
output with the host in-process API helper. The `runroot` calls separately
cover the configured-root path. I withdraw the finding.
<!-- <review_comment_withdrawn> -->
---
<details>
<summary>✏️ Learnings added</summary>
```
Learnt from: daandemeyer
Repo: rpm-software-management/rpm PR: 4294
File: tests/rpmuncompress.at:38-45
Timestamp: 2026-08-07T11:57:24.663Z
Learning: In `tests/rpmuncompress.at`, direct `rpmuncompress` calls
intentionally compare host command output with the in-process API helper, which
also runs on the host. `runroot rpmuncompress` calls intentionally cover the
configured-root path. Payload conversion does not depend on the macros that
differ between these environments.
```
> Note: Learnings are effective only in the context of similar code segments.
> To apply general coding guidelines, please configure [review
> instructions](https://docs.coderabbit.ai/guides/review-instructions). You can
> manage existing learnings in the [app](https://app.coderabbit.ai/learnings).
</details>
<sub>You are interacting with an AI system.</sub>
<!-- This is an auto-generated reply by CodeRabbit -->
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4294#discussion_r3735579773
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4294/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
