@coderabbitai[bot] commented on this pull request.
> + /* Plain streams use physical file offsets. Compressed streams align the
+ * canonical cpio relative to its decompressed start. */
+ if (fdIsPlain(fd)) {
+ off_t base = Ftell(fd);
+ cpio->base = (base > 0) ? base : 0;
+ }
`@daandemeyer`, this explanation appears to address a different test-coverage
comment.
The finding here concerns `lib/cpio.cc`. It concerns the handling of `Ftell()`
failure for a plain nonseekable payload stream. The direct-call and `runroot`
test mix does not affect that alignment-base calculation.
<sub>You are interacting with an AI system.</sub>
<!-- This is an auto-generated reply by CodeRabbit -->
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4294#discussion_r3735577073
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4294/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint