@dralley commented on this pull request.
> + case RPMSIGTAG_BADSHA1_2:
+ case RPMTAG_PUBKEYS:
+ case RPMSIGTAG_SHA1:
+ case RPMSIGTAG_SHA256:
+ case RPMSIGTAG_FILESIGNATURES:
+ case RPMSIGTAG_FILESIGNATURELENGTH:
+ case RPMSIGTAG_VERITYSIGNATURES:
+ case RPMSIGTAG_VERITYSIGNATUREALGO:
+ case RPMSIGTAG_SHA3_256:
+ case RPMSIGTAG_RESERVED:
+ /* The archive sizes describe canonical uncompressed cpio and
+ * remain valid for the materialized representation. */
+ case RPMSIGTAG_PAYLOADSIZE:
+ case RPMSIGTAG_LONGARCHIVESIZE:
+ break;
+ case RPMSIGTAG_SIZE:
The V4 format documentation declares SIZE / LONGSIZE as required for a V4
header.
https://github.com/rpm-software-management/rpm/blob/master/docs/manual/format_v4.md?plain=1#L67
So unfortunately I think that tag value would need to be updated, not just
stripped.
I wish it was only a theoretical concern, but it's not :(
https://github.com/rpm-rs/rpm-rs/pull/289#issuecomment-3361279950
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4294#pullrequestreview-4799727875
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4294/review/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
