This was originally done to support native test-suite mode on developer workstations running a Fedora release that's behind or ahead of the one specified in the Dockerfile's FROM. However, that was just confusing and non-obvious unless one knew about the override, especially if some parts of the Dockerfile (or the dependencies installed within) weren't written with that particular version of Fedora in mind, which then caused build issues or false positives.
So, drop the override and make the FROM autoritative. This is the only correct and sane way since the Dockerfile is declarative and static by design. As a result, if the host Fedora release is different than the one in the FROM directive, the test-suite will fall back to "standalone" mode where the build happens completely in a container and is not cached in between runs (other than the base image). This change will inevitably hit some folks but there's a workaround for that: Use a toolbox(1) container based on tests/Dockerfile.fedora. See commit ef948df97821da97949adf18969fb020f8c69e31 for the how. This should really go into a proper documentation file in the repo, but that's for some other day... Fixes: #4213 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/4260 -- Commit Summary -- * Drop FROM override from mktree -- File Changes -- M tests/CMakeLists.txt (1) M tests/Dockerfile.fedora (1) M tests/mktree.oci (8) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/4260.patch https://github.com/rpm-software-management/rpm/pull/4260.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/4260 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________ Rpm-maint mailing list [email protected] https://lists.rpm.org/mailman/listinfo/rpm-maint
