Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java: http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@43 PS6, Line 43: if (!view.isValid(i)) { : throw new IllegalStateException("Null element at " + i); : } > I'm not sure I understand this correctly: does this mean there isn't a way In this, yes the reason being avoid silently losing null information. I was planning to add more methods like toNullableInt8Array() in followup patches so the caller is aware of the behavior. Let me know if you think it would make sense to add those in further revisions of this patch. http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@54 PS6, Line 54: for (int i = 0; i < n; i++) { : if (!view.isValid(i)) { : throw new IllegalStateException("Null element at " + i); : } : result[i] = view.getInt16(i); : } > Instead of these very ineffective code path (involving creating a temporary Yes, I briefly explored it but since it was not straightforward I did not pursue it. I think I can address it in the followup patches to improve the performance. -- To view, visit http://gerrit.cloudera.org:8080/23483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52 Gerrit-Change-Number: 23483 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 20:04:53 +0000 Gerrit-HasComments: Yes
