Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java: http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@54 PS6, Line 54: for (int i = 0; i < n; i++) { : if (!view.isValid(i)) { : throw new IllegalStateException("Null element at " + i); : } : result[i] = view.getInt16(i); : } Instead of these very ineffective code path (involving creating a temporary object in every call to ArrayCellView.getInt16(idx)), is it possible to provide more streamlined access to the underlying data stored in memory, just wrapped into Java-native container? Did you explore such an alternative? -- To view, visit http://gerrit.cloudera.org:8080/23483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52 Gerrit-Change-Number: 23483 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 18:53:39 +0000 Gerrit-HasComments: Yes
