Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@682 PS5, Line 682: getArray this method is never used, is it necessary? http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@700 PS5, Line 700: "Column (name: " + col.getName() + ", index: " + columnIndex + ") is not an array"); consider using String.format("Column (name: %s, index: %d) is not an array", col.getName(), columnIndex)); instead of concatenation http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java: http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@287 PS5, Line 287: // LE what does LE stand for? http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@344 PS5, Line 344: "Column " + col.getName() + " is not varlen"); consider using String.format() -- To view, visit http://gerrit.cloudera.org:8080/23483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52 Gerrit-Change-Number: 23483 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 02 Oct 2025 13:01:24 +0000 Gerrit-HasComments: Yes
