Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23016 )
Change subject: KUDU-1457 [2/n] add IPv6 support to squeasel function ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch File thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch: http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@10 PS6, Line 10: -ldl > I guess that wouldn't work on macOS, but it's not a big deal. At least, it Even without these changes (i.e. on a clean squeasel branch), the build fails on macOS. It requires include library paths to ssl. I haven't explored but maybe there are more issues. I suspect this was not extensively tested on macOS. If you are only concerned about libdl, I did a quick check. It worked for me on Sonoma 14.2.1. However, to make it work for macOS, I had to add ssl/crypto library and include paths. Since it is not tested on macOS, it would make sense to add TODO comment for the same. http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@265 PS6, Line 265: 100 > Why not INET6_ADDRSTRLEN? Isn't it enough or there is some other issue her INET6_ADDRSTRLEN can accommodate them all, so no issues there. I may have left it there inadvertently while testing boundary conditions. Changed back to INET6_ADDRSTRLEN. Thanks for pointing this out! http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@288 PS6, Line 288: 100 > ditto ditto -- To view, visit http://gerrit.cloudera.org:8080/23016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9 Gerrit-Change-Number: 23016 Gerrit-PatchSet: 6 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 31 Jul 2025 11:08:04 +0000 Gerrit-HasComments: Yes
