Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23016 )
Change subject: KUDU-1457 [2/n] add IPv6 support to squeasel function ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch File thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch: http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@46 PS5, Line 46: *) > I think Alexey meant we’re using sizeof(struct sockaddr_in *) (pointer size Oh! I totally misread probably because I may have highlighted the struct name while going through the comment at the time. So to answer the original question, yes it was a bug. It got caught when the size of the structure exceeded 16 bytes for IPv6 case (by introduction of sockaddr_storage). It used to 'luckily' work for IPv4 because all the useful fields are inside first 8-bytes and rest of 8-bytes are struct padding. Thanks for clearing the confusion, Marton! -- To view, visit http://gerrit.cloudera.org:8080/23016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9 Gerrit-Change-Number: 23016 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 28 Jul 2025 16:28:19 +0000 Gerrit-HasComments: Yes
