Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23016 )
Change subject: KUDU-1457 [2/n] add IPv6 support to squeasel function ...................................................................... Patch Set 6: Code-Review+1 (5 comments) Overall looks good to me. Just a few more nits I overlooked in the first round of review -- sorry I missed them, but it should be a big deal to address those nits, I hope. Thank you for revving this patch! http://gerrit.cloudera.org:8080/#/c/23016/5/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: PS5: > I have a separate patch for webserver changes that includes testing for cor Thanks -- that sounds good to me. http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch File thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch: http://gerrit.cloudera.org:8080/#/c/23016/5/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@46 PS5, Line 46: *) > Oh! I totally misread probably because I may have highlighted the struct na Thank you for the clarification, guys! It's nice to know this bug is addressed with this patch. http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch File thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch: http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@10 PS6, Line 10: -ldl I guess that wouldn't work on macOS, but it's not a big deal. At least, it shouldn't break building Kudu's 3rd-party on macOS since the unit_test isn't built as a part of it. Maybe, add a TODO comment to make people aware of the fact that this needs to be updated to build unit_test on macOS. http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@265 PS6, Line 265: 100 Why not INET6_ADDRSTRLEN? Isn't it enough or there is some other issue here? http://gerrit.cloudera.org:8080/#/c/23016/6/thirdparty/patches/squeasel-support-get-bound-addresses-for-ipv6.patch@288 PS6, Line 288: 100 ditto -- To view, visit http://gerrit.cloudera.org:8080/23016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee175a00a7ac9e20a31ddb8396468cfcd8f3b6f9 Gerrit-Change-Number: 23016 Gerrit-PatchSet: 6 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 30 Jul 2025 19:05:06 +0000 Gerrit-HasComments: Yes
