Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24162 )

Change subject: IMPALA-14872: Perform work outside DoFuncForAllEntries
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc@3075
PS1, Line 3075: Offer() in
              :     // case the cancellation_thread_pool_ queue is full.
Nit:  BlockingQueue::Offer() only returns false if the queue is shut down.  
Otherwise, it blocks until there is space in the queue.



--
To view, visit http://gerrit.cloudera.org:8080/24162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49f92bf4fe1b773ee8643422091b7252ddd81685
Gerrit-Change-Number: 24162
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 02 Apr 2026 17:46:12 +0000
Gerrit-HasComments: Yes

Reply via email to