Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24162 )
Change subject: IMPALA-14872: Perform work outside DoFuncForAllEntries ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc@3066 PS1, Line 3066: DoFuncForAllEntries > I saw in callstacks other uses of DoFuncForAllEntries from Impala's webui ( I'll look at them. All of these are tricky: we need to be careful about memory management, but it may be that we could just return a list of shared_ptr<QueryDriver> instead of iterating with the lock. http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc@3081 PS1, Line 3081: if (query_driver->finalized()) continue; : ClientRequestState* request_state = query_driver->GetActiveClientRequestState(); > Can it be a problem if finalization happens just after query_driver->finali finalized() is a read on an atomic. If it gets finalized after, I don't think that makes any changes that would prevent the rest of this from working. This code could have previously been acting on a finalized query that hadn't been removed from query_driver_map_ yet. http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc@3082 PS1, Line 3082: : Coordinator* coord = request_state->GetCoordinator(); > I am not very familiar with query retry, but AFAIK query_driver->GetActive Good point about rechecking coordinator. I didn't see a way to safely retain the memory for ClientRequestState without holding a shared_ptr<QueryDriver>, but another option would be to collect both. I think it makes sense to recheck here for the latest ClientRequestState and verify it's not null. -- To view, visit http://gerrit.cloudera.org:8080/24162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49f92bf4fe1b773ee8643422091b7252ddd81685 Gerrit-Change-Number: 24162 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2026 15:32:50 +0000 Gerrit-HasComments: Yes
