Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24162 )
Change subject: IMPALA-14872: Perform work outside DoFuncForAllEntries ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/24162/1/be/src/service/impala-server.cc@3082 PS1, Line 3082: : Coordinator* coord = request_state->GetCoordinator(); > Good point about rechecking coordinator. I didn't see a way to safely retai Need to hold ClientRequestState::lock() before calling GetCoordinator() https://github.com/apache/impala/blob/ca5c8e03383ef5c210a5aefeb9284d3f1b2b382f/be/src/service/client-request-state.h#L598-L604 -- To view, visit http://gerrit.cloudera.org:8080/24162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49f92bf4fe1b773ee8643422091b7252ddd81685 Gerrit-Change-Number: 24162 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2026 17:24:05 +0000 Gerrit-HasComments: Yes
