Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running ...................................................................... Patch Set 3: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3284 PS1, Line 3284: cls.iceberg_rest_server.start_rest_server(300) > Thanks, good idea. Done http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3285 PS1, Line 3285: except Exception as e: > Added a check that we don't have HIVE_CONF_DIR set. Manually validated the Done http://gerrit.cloudera.org:8080/#/c/23183/3/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23183/3/tests/authorization/test_ranger.py@3281 PS3, Line 3281: def init_infra_services(cls): Nit: init_infra_services does not need to be its own method. All this code can go in setup_class. http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@49 PS1, Line 49: > Done Done http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@50 PS1, Line 50: @classmethod > Done Done http://gerrit.cloudera.org:8080/#/c/23183/3/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/23183/3/tests/custom_cluster/test_iceberg_rest_catalog.py@51 PS3, Line 51: def init_infra_services(cls): Nit: init_infra_services does not need to be its own method. All this code can go in setup_class. -- To view, visit http://gerrit.cloudera.org:8080/23183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b Gerrit-Change-Number: 23183 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 22 Jul 2025 20:54:11 +0000 Gerrit-HasComments: Yes
