Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running ...................................................................... Patch Set 1: (6 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3284 PS1, Line 3284: self.init_infra_services() > Is it possible to start/stop HMS in the setup_class() and teardown_class() Thanks, good idea. HMS is only started/restarted when HIVE_CONF_DIR is set for the test method. Added a check to setup_method that we don't have HIVE_CONF_DIR specified. http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3285 PS1, Line 3285: super(TestRangerIcebergRestCatalog, self).setup_method(method) > Looks as if there is a chance HMS could get restarted in CustomClusterTestS Added a check that we don't have HIVE_CONF_DIR set. Manually validated the check by trying to set hive_conf_dir the following way: @CustomClusterTestSuite.with_args( impalad_args=ICEBERG_REST_IMPALAD_ARGS, hive_conf_dir='asdf') def test_rest_catalog_fgac(self, vector): Also manually checked that HiveMetastore is not running during the tests. http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@24 PS1, Line 24: from tests.stress.stress_util import Task, run_tasks > flake8: F401 'tests.stress.stress_util.Task' imported but unused Done http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@24 PS1, Line 24: from tests.stress.stress_util import Task, run_tasks > flake8: F401 'tests.stress.stress_util.run_tasks' imported but unused Done http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@49 PS1, Line 49: self.init_infra_services() > Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_rang Done http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@50 PS1, Line 50: super(TestIcebergRestCatalog, self).setup_method(method) > Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_rang Done -- To view, visit http://gerrit.cloudera.org:8080/23183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b Gerrit-Change-Number: 23183 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 18 Jul 2025 15:22:56 +0000 Gerrit-HasComments: Yes
