Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3284 PS1, Line 3284: self.init_infra_services() Is it possible to start/stop HMS in the setup_class() and teardown_class() functions? That way, HMS would only have to be stopped/started one time instead of being stopped/started for each test. It doesn't seem to me that is possible without also changing https://github.com/apache/impala/blob/438461db9e82be1d91f4320cce5ab08bc895a305/tests/common/custom_cluster_test_suite.py#L406 as HMS is started in that particular code path. http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3285 PS1, Line 3285: super(TestRangerIcebergRestCatalog, self).setup_method(method) Looks as if there is a chance HMS could get restarted in CustomClusterTestSuite.setup_method(). That function calls CustomClusterTestSuite.cluster_setup() which has a code path that starts HMS at https://github.com/apache/impala/blob/438461db9e82be1d91f4320cce5ab08bc895a305/tests/common/custom_cluster_test_suite.py#L310 http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@49 PS1, Line 49: self.init_infra_services() Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_ranger.py#3284 http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@50 PS1, Line 50: super(TestIcebergRestCatalog, self).setup_method(method) Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_ranger.py#3285 -- To view, visit http://gerrit.cloudera.org:8080/23183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b Gerrit-Change-Number: 23183 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 17 Jul 2025 17:18:36 +0000 Gerrit-HasComments: Yes
