Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22815 )
Change subject: IMPALA-13991: Skip CROSS_JOIN rewrite if subquery is in disjunctive ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22815/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/22815/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@775 PS5, Line 775: !isDisjunctive > I saw the test cases are around only scalar subqueries within the disjuncti If it is not a scalar subquery, an Exception will be thrown at L793. So it looks like we don't support non-scalar subquery yet. http://gerrit.cloudera.org:8080/#/c/22815/5/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: http://gerrit.cloudera.org:8080/#/c/22815/5/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test@4122 PS5, Line 4122: 7.3 > I am curious why this changed to 100 while the distributed plan shows 7.3K. It is a mistake. patch set 6 shows the right cardinality number. -- To view, visit http://gerrit.cloudera.org:8080/22815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac0deb0b2fb1536684cce2e004156a20b769b9ab Gerrit-Change-Number: 22815 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 28 Apr 2025 19:32:42 +0000 Gerrit-HasComments: Yes
