Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22815 )
Change subject: IMPALA-13991: Skip CROSS_JOIN rewrite if subquery is in disjunctive ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/22815/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22815/3//COMMIT_MSG@11 PS3, Line 11: disjunctiv > typo Done http://gerrit.cloudera.org:8080/#/c/22815/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/22815/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@674 PS3, Line 674: if (joinCon > about the joinConjunct = null case: Make sense. Added comment noting this. http://gerrit.cloudera.org:8080/#/c/22815/3/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test File testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test: http://gerrit.cloudera.org:8080/#/c/22815/3/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test@364 PS3, Line 364: 20B > probably not related to the patch, but I don't get why row-size is 89B - th Done http://gerrit.cloudera.org:8080/#/c/22815/3/testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test File testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test: http://gerrit.cloudera.org:8080/#/c/22815/3/testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test@228 PS3, Line 228: disjunctiv > typo Done -- To view, visit http://gerrit.cloudera.org:8080/22815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac0deb0b2fb1536684cce2e004156a20b769b9ab Gerrit-Change-Number: 22815 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 25 Apr 2025 15:30:14 +0000 Gerrit-HasComments: Yes
