Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22815 )
Change subject: IMPALA-13991: Skip CROSS_JOIN rewrite if subquery is in disjunctive ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/22815/4/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/22815/4/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@29 PS4, Line 29: import org.apache.impala.util.AcidUtils; > Why was this needed? javadoc + vscode auto add this line. I removed it now. http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test File testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test: http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test@344 PS4, Line 344: 03:NESTED LOOP JOIN [LEFT OUTER JOIN, BROADCAST] > This description seems strange; would it match anything? Both hand of join has the same name, but they are different SlotRef. Tweak the query a bit with function so it is clearer which one is which. http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test@4112 PS4, Line 4112: where (t.int_col = 0 or > Is there some reason to replace the test case rather than adding a new one? I can add this as separate one, but this test case plan will change anyway. The old test case is also bad because t.int_col is never null. Thus, if I copy-paste the query to impala-shell, result will look correct (lucky) but the plan is wrong. -- To view, visit http://gerrit.cloudera.org:8080/22815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac0deb0b2fb1536684cce2e004156a20b769b9ab Gerrit-Change-Number: 22815 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 25 Apr 2025 20:59:33 +0000 Gerrit-HasComments: Yes
