On Mon, 13 Feb 2023 at 20:31, Fabiano Rosas <[email protected]> wrote: > > The debug_helper.c file will move into a tcg-specific directory, so > take the cpregs code out of it. That code needs to be present in KVM > builds as well. > > Signed-off-by: Fabiano Rosas <[email protected]> > Reviewed-by: Richard Henderson <[email protected]> > Tested-by: Philippe Mathieu-Daudé <[email protected]> > --- > target/arm/cpregs.c | 473 ++++++++++++++++++++++++++++++++++++++ > target/arm/debug_helper.c | 459 ------------------------------------ > target/arm/internals.h | 9 - > 3 files changed, 473 insertions(+), 468 deletions(-)
I definitely think this is not an improvement. Currently we have a file debug_helper.c with a reasonably well defined purpose (debug related cpregs and code). This patch moves half of that into the already massively too large cpregs.c, thus undoing the cleanup we did by separating out the debug register code from the huge pile of code in helper.c. thanks -- PMM
