Re: [Qemu-devel] [PATCH 16/28] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

[Bastian Koppelmann]

On 10/13/18 8:53 PM, Richard Henderson wrote:

Choose return false or raise exception. Except...
I wonder if we might write this as

     int shamt = a->shamt;
     if (shamt == 0) {
         shamt = 64;
     }

Good catch. I'll add a comment, that a shamt of 0 is intended for RV128.


Cheers,

Bastian