On 10/12/18 10:30 AM, Bastian Koppelmann wrote: > return false in trans_* instructions is no longer used as a fallback to > the old decoder. We can therefore now use 'return false' to indicate an > illegal > instruction. > > Signed-off-by: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> > Signed-off-by: Peer Adelt <peer.ad...@hni.uni-paderborn.de> > --- > .../riscv/insn_trans/trans_privileged.inc.c | 6 ++---- > target/riscv/insn_trans/trans_rvc.inc.c | 21 +++++++------------ > target/riscv/insn_trans/trans_rvd.inc.c | 14 ++++++------- > target/riscv/insn_trans/trans_rvf.inc.c | 10 ++++----- > target/riscv/insn_trans/trans_rvi.inc.c | 18 ++++++---------- > target/riscv/translate.c | 1 + > 6 files changed, 28 insertions(+), 42 deletions(-)
I don't see the need to make this distinction in the early patches. I think this should be folded back to the previous patches. r~