On Wed, Mar 04, 2026 at 09:25:05PM +0800, Max Chou wrote: > The Zvfbfa extension adds more complete BF16 vector compute support > and requires the Zve32f and Zfbfmin extensions. > typo in commit subject -- "properities" should be "properties".
Otherwise looks good. Reviewed-by: Chao Liu <[email protected]> Thanks, Chao > Reviewed-by: Daniel Henrique Barboza <[email protected]> > Reviewed-by: Nutty Liu <[email protected]> > Signed-off-by: Max Chou <[email protected]> > --- > target/riscv/cpu.c | 1 + > target/riscv/cpu_cfg_fields.h.inc | 1 + > target/riscv/tcg/tcg-cpu.c | 8 ++++++++ > 3 files changed, 10 insertions(+) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 9be79622f4..2ddc26c837 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -189,6 +189,7 @@ const RISCVIsaExtData isa_edata_arr[] = { > ISA_EXT_DATA_ENTRY(zve64f, PRIV_VERSION_1_10_0, ext_zve64f), > ISA_EXT_DATA_ENTRY(zve64d, PRIV_VERSION_1_10_0, ext_zve64d), > ISA_EXT_DATA_ENTRY(zve64x, PRIV_VERSION_1_10_0, ext_zve64x), > + ISA_EXT_DATA_ENTRY(zvfbfa, PRIV_VERSION_1_13_0, ext_zvfbfa), > ISA_EXT_DATA_ENTRY(zvfbfmin, PRIV_VERSION_1_12_0, ext_zvfbfmin), > ISA_EXT_DATA_ENTRY(zvfbfwma, PRIV_VERSION_1_12_0, ext_zvfbfwma), > ISA_EXT_DATA_ENTRY(zvfh, PRIV_VERSION_1_12_0, ext_zvfh), > diff --git a/target/riscv/cpu_cfg_fields.h.inc > b/target/riscv/cpu_cfg_fields.h.inc > index 70ec650abf..3696f02ee0 100644 > --- a/target/riscv/cpu_cfg_fields.h.inc > +++ b/target/riscv/cpu_cfg_fields.h.inc > @@ -99,6 +99,7 @@ BOOL_FIELD(ext_zvks) > BOOL_FIELD(ext_zvksc) > BOOL_FIELD(ext_zvksg) > BOOL_FIELD(ext_zmmul) > +BOOL_FIELD(ext_zvfbfa) > BOOL_FIELD(ext_zvfbfmin) > BOOL_FIELD(ext_zvfbfwma) > BOOL_FIELD(ext_zvfh) > diff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c > index 988b2d905f..720ff0c2a3 100644 > --- a/target/riscv/tcg/tcg-cpu.c > +++ b/target/riscv/tcg/tcg-cpu.c > @@ -720,6 +720,14 @@ void riscv_cpu_validate_set_extensions(RISCVCPU *cpu, > Error **errp) > return; > } > > + if (cpu->cfg.ext_zvfbfa) { > + if (!cpu->cfg.ext_zve32f || !cpu->cfg.ext_zfbfmin) { > + error_setg(errp, "Zvfbfa extension requires Zve32f extension " > + "and Zfbfmin extension"); > + return; > + } > + } > + > if ((cpu->cfg.ext_zdinx || cpu->cfg.ext_zhinxmin) && > !cpu->cfg.ext_zfinx) { > error_setg(errp, "Zdinx/Zhinx/Zhinxmin extensions require Zfinx"); > return; > -- > 2.52.0 >
