On 7/1/26 06:11, Thomas Huth wrote:
On 06/01/2026 21.29, Eric Farman wrote:
On Wed, 2025-12-24 at 17:20 +0100, Philippe Mathieu-Daudé wrote:
All S390x-related binaries are buildable without a single use
of the legacy "native endian" API. Unset the transitional
TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid
further uses of the legacy API.
One nit is that this text confuses me, because the code below sets
TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API rather than unsetting
TARGET_USE_LEGACY_NATIVE_ENDIAN_API.
Oops, I'll reword.
End goal seems the same though.
By the way, both definitions seem to be completely unused in QEMU
currently, so this patch is currently for no real use yet? Unless some
more infrastructure gets merged that consumes this setting, I think we
should rather not merge this patch yet.
Oh. I usually add 'Based-on' in my cover letters when there are
dependencies between series. I did that in the previous version
(which was not covering s390x) but Pierrick told me this was not
practical to apply and test, and suggested to share a branch/tag
with all series; which is what I did (sharing a tag,
https://gitlab.com/philmd/qemu/-/tags/endian_s390x-v1), however
I failed to precise the other series. In particular, this is
based on:
https://lore.kernel.org/qemu-devel/[email protected]/
See these patches:
system: Allow restricting the legacy ld/st_phys() 'native-endian' API
system: Allow restricting the legacy ld/st_he() 'native-endian' API
system: Allow restricting legacy address_space_ldst() native-endian API
system: Allow restricting the legacy cpu_ld/st() 'native-endian' API
system: Allow restricting the legacy translator_ld() 'native-endian' API
system: Allow restricting the legacy tswap() 'native-endian' API
system: Allow restricting the legacy MO_TE* 'native-endian' definitions
system: Allow restricting the legacy DEVICE_NATIVE_ENDIAN definition
I'll queue patches 1-7 for my
next pull request.
Thanks!
