On 06/01/2026 21.29, Eric Farman wrote:
On Wed, 2025-12-24 at 17:20 +0100, Philippe Mathieu-Daudé wrote:
All S390x-related binaries are buildable without a single use
of the legacy "native endian" API. Unset the transitional
TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid
further uses of the legacy API.
One nit is that this text confuses me, because the code below sets
TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API rather than unsetting
TARGET_USE_LEGACY_NATIVE_ENDIAN_API.
End goal seems the same though.
By the way, both definitions seem to be completely unused in QEMU currently,
so this patch is currently for no real use yet? Unless some more
infrastructure gets merged that consumes this setting, I think we should
rather not merge this patch yet. I'll queue patches 1-7 for my next pull
request.
Thomas