On Wed, 2025-12-24 at 17:20 +0100, Philippe Mathieu-Daudé wrote: > All S390x-related binaries are buildable without a single use > of the legacy "native endian" API. Unset the transitional > TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid > further uses of the legacy API.
One nit is that this text confuses me, because the code below sets TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API rather than unsetting TARGET_USE_LEGACY_NATIVE_ENDIAN_API. End goal seems the same though. Thanks, Eric > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > configs/targets/s390x-linux-user.mak | 1 + > configs/targets/s390x-softmmu.mak | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/configs/targets/s390x-linux-user.mak > b/configs/targets/s390x-linux-user.mak > index 68c2f288724..e3723f5dc54 100644 > --- a/configs/targets/s390x-linux-user.mak > +++ b/configs/targets/s390x-linux-user.mak > @@ -4,3 +4,4 @@ TARGET_SYSTBL=syscall.tbl > TARGET_BIG_ENDIAN=y > TARGET_XML_FILES= gdb-xml/s390x-core64.xml gdb-xml/s390-acr.xml > gdb-xml/s390-fpr.xml gdb-xml/s390-vx.xml gdb-xml/s390-cr.xml > gdb-xml/s390-virt.xml gdb-xml/s390-virt-kvm.xml gdb-xml/s390-gs.xml > TARGET_LONG_BITS=64 > +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=y > diff --git a/configs/targets/s390x-softmmu.mak > b/configs/targets/s390x-softmmu.mak > index 76dd5de6584..544657cfe2d 100644 > --- a/configs/targets/s390x-softmmu.mak > +++ b/configs/targets/s390x-softmmu.mak > @@ -3,3 +3,4 @@ TARGET_BIG_ENDIAN=y > TARGET_KVM_HAVE_GUEST_DEBUG=y > TARGET_XML_FILES= gdb-xml/s390x-core64.xml gdb-xml/s390-acr.xml > gdb-xml/s390-fpr.xml gdb-xml/s390-vx.xml gdb-xml/s390-cr.xml > gdb-xml/s390-virt.xml gdb-xml/s390-virt-kvm.xml gdb-xml/s390-gs.xml > TARGET_LONG_BITS=64 > +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=y
