On 7/8/25 1:52 PM, Peter Maydell wrote:
> We don't generally like DPRINTF debug macros, preferring tracepoints.
> In this case the macro is used in only three places (reset, realize,
> and in the unlikely event the host kernel doesn't have GICv3 register
> access support). These don't seem worth converting to tracepoints,
> so simply delete the macro and its uses.
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Eric Auger <eric.au...@redhat.com>
Eric
> ---
> If anybody needs to debug this code they can add useful tracepoints
> at that point. I don't think these DPRINTFs will help at all.
> ---
> hw/intc/arm_gicv3_kvm.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
> index 8e34d08b415..e118c1b1f04 100644
> --- a/hw/intc/arm_gicv3_kvm.c
> +++ b/hw/intc/arm_gicv3_kvm.c
> @@ -34,14 +34,6 @@
> #include "target/arm/cpregs.h"
>
>
> -#ifdef DEBUG_GICV3_KVM
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, "kvm_gicv3: " fmt, ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
> -#endif
> -
> #define TYPE_KVM_ARM_GICV3 "kvm-arm-gicv3"
> typedef struct KVMARMGICv3Class KVMARMGICv3Class;
> /* This is reusing the GICv3State typedef from ARM_GICV3_ITS_COMMON */
> @@ -721,14 +713,11 @@ static void kvm_arm_gicv3_reset_hold(Object *obj,
> ResetType type)
> KVMARMGICv3Class *kgc = KVM_ARM_GICV3_GET_CLASS(s);
> uint32_t reg;
>
> - DPRINTF("Reset\n");
> -
> if (kgc->parent_phases.hold) {
> kgc->parent_phases.hold(obj, type);
> }
>
> if (s->migration_blocker) {
> - DPRINTF("Cannot put kernel gic state, no kernel interface\n");
> return;
> }
>
> @@ -807,8 +796,6 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Error
> **errp)
> Error *local_err = NULL;
> int i;
>
> - DPRINTF("kvm_arm_gicv3_realize\n");
> -
> kgc->parent_realize(dev, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
