I think I'd be most useful to rebase, and create a PR from this, then we can see whether tests pass and we can run prombench (although I don't think there are any perf tests that involve the proto parts). Then we can discuss on there and figure out where to take this.
Thank you so much for the work you have already put into this! On Mon, 21 Jun 2021 at 19:53, Austin Cawley-Edwards <[email protected]> wrote: > I've updated my branch ( > https://github.com/austince/prometheus/tree/feat/drop-gogo) to use both > the vitess plugin and the buf tool, which indeed fit very nicely together. > > I've only updated the code enough for it to compile, have not investigated > the semantic differences. This is likely the furthest I'll be able to take > this for a bit, so feedback and playing around are welcome and appreciated > if this is where we'd like protobuf in Prometheus to go :) > > Best, > Austin > > On Thu, Jun 17, 2021 at 12:56 PM Frederic Branczyk <[email protected]> > wrote: > >> I have heard great thing, but haven’t used it. Wrongfully thought that >> they are mutually exclusive but turns out they are actually complementary: >> https://twitter.com/fredbrancz/status/1405192828049838080?s=21 >> >> We should probably do an investigation of the combination. >> >> On Thu 17. Jun 2021 at 18:26, Austin Cawley-Edwards < >> [email protected]> wrote: >> >>> Just saw this on the CNCF blog as well, seems like a promising library. >>> >>> Tangentially, have you heard of https://github.com/bufbuild/buf? It >>> seems much nicer than compiling with shell scripts and protoc. >>> >>> >>> -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAOs1UmyzDvuVoFEET3w1Syp9OrKnhG2HO%2BiD%3DhifvgjhMS25eQ%40mail.gmail.com.
